Patch Detail
Show a patch.
GET /api/1.1/patches/17109/?format=api
{ "id": 17109, "url": "https://patchwork.libcamera.org/api/1.1/patches/17109/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17109/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220812223351.22609-2-laurent.pinchart@ideasonboard.com>", "date": "2022-08-12T22:33:49", "name": "[libcamera-devel,v3,1/3] ipa: rkisp1: Add enable field for AWB algorithm in IPA context", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "af00377a91b05acf183b2a7281adfcbf1ef2a614", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17109/mbox/", "series": [ { "id": 3411, "url": "https://patchwork.libcamera.org/api/1.1/series/3411/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3411", "date": "2022-08-12T22:33:48", "name": "Add DPF tuning support for RkISP1", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3411/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17109/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17109/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 242D8C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Aug 2022 22:34:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF2496118E;\n\tSat, 13 Aug 2022 00:34:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED68A61189\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Aug 2022 00:34:06 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30CD247C;\n\tSat, 13 Aug 2022 00:34:06 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660343648;\n\tbh=FTkwjcfhwBH+7CVgqtjMApCdzgjDoffvXj3hHP45IPI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=NYRSF4VH37a3V9rSYCwsVRWpPz0eVgYvO7wlwz4swsGD+WEI+mdZ0ptlw4UMnjds9\n\tPmSG4vddPS1+ckLmrQo1MWqAr++1eG+mvU5uTWm8zrvHJHD4KP2Z5wWskQAS8YGf/q\n\tU1loxhHt7c6ZFIkDOZpH87s4nxSEUiO3bCAScmB++kDPNFkcpy8MJkfRUBifJmrsAO\n\t+mr7c/RSZrXbb2sLDAXeJTL+NENrEjnPj6X/3/W3owsYizEbPCMAyvbZKYFa4lTpEt\n\t227MhxKTvgdppDTm8OSbQ/qc5+t6LkJ6n19Rc1VuFLCqlEvJI9QjY2+g1LJm5TSPWC\n\thVaTQ9Fbdp0fQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660343646;\n\tbh=FTkwjcfhwBH+7CVgqtjMApCdzgjDoffvXj3hHP45IPI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rLwl+dXoJ8mR2iK9UVts/V1dDjHf0DSU91FyjBzJeSevEHJDSbfG5IotNSWEkilBl\n\tNxuZEtXNas1pfn9AXSxKFOnsOtzyZmj753H1AFB7DZZxN8gbVGyvMUWv9llHIxh/dx\n\tqpikxtKuZWfBJa43CUV2gkBo+dKkKCGDakkEuKdY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rLwl+dXo\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 13 Aug 2022 01:33:49 +0300", "Message-Id": "<20220812223351.22609-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220812223351.22609-1-laurent.pinchart@ideasonboard.com>", "References": "<20220812223351.22609-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/3] ipa: rkisp1: Add enable field for\n\tAWB algorithm in IPA context", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Florian Sylvestre <fsylvestre@baylibre.com>\n\nAdd an enable variable in the awb struct in IPASessionConfiguration which\nindicates if the awb algorithm has been configured. This will allow other\nalgorithms to retrieve this information.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 1 +\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 9f00364d12b1..d1328f011081 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -48,6 +48,8 @@ int Awb::configure(IPAContext &context,\n \tcontext.configuration.awb.measureWindow.h_size = 3 * configInfo.outputSize.width / 4;\n \tcontext.configuration.awb.measureWindow.v_size = 3 * configInfo.outputSize.height / 4;\n \n+\tcontext.configuration.awb.enabled = true;\n+\n \treturn 0;\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex ef8bb8e931c8..23a63f8c6e25 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -87,6 +87,9 @@ namespace libcamera::ipa::rkisp1 {\n *\n * \\var IPASessionConfiguration::awb.measureWindow\n * \\brief AWB measure window\n+ *\n+ * \\var IPASessionConfiguration::awb.enabled\n+ * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n */\n \n /**\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 2bdb6a81d7c9..7f7b3e4d88fa 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -29,6 +29,7 @@ struct IPASessionConfiguration {\n \n \tstruct {\n \t\tstruct rkisp1_cif_isp_window measureWindow;\n+\t\tbool enabled;\n \t} awb;\n \n \tstruct {\n", "prefixes": [ "libcamera-devel", "v3", "1/3" ] }