Patch Detail
Show a patch.
GET /api/1.1/patches/17106/?format=api
{ "id": 17106, "url": "https://patchwork.libcamera.org/api/1.1/patches/17106/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17106/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220812124651.27496-11-utkarsh02t@gmail.com>", "date": "2022-08-12T12:46:50", "name": "[libcamera-devel,v2,10/11] qcam: ControlFrame: Add GUI way to interact with ControlTypeIntger32", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e6651a72430aacd591aff4c26bc44c07fb0bca3b", "submitter": { "id": 114, "url": "https://patchwork.libcamera.org/api/1.1/people/114/?format=api", "name": "Utkarsh Tiwari", "email": "utkarsh02t@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17106/mbox/", "series": [ { "id": 3410, "url": "https://patchwork.libcamera.org/api/1.1/series/3410/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3410", "date": "2022-08-12T12:46:40", "name": "Introduce control interaction to qcam", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3410/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17106/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17106/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D3A8BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Aug 2022 12:47:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12B2F6333D;\n\tFri, 12 Aug 2022 14:47:26 +0200 (CEST)", "from mail-pg1-x535.google.com (mail-pg1-x535.google.com\n\t[IPv6:2607:f8b0:4864:20::535])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BD7C6332F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Aug 2022 14:47:23 +0200 (CEST)", "by mail-pg1-x535.google.com with SMTP id 12so720603pga.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Aug 2022 05:47:23 -0700 (PDT)", "from localhost.localdomain ([2404:bd00:3:dc0d:d8e:96a2:2dbe:5a83])\n\tby smtp.gmail.com with ESMTPSA id\n\te6-20020a17090a728600b001f069352d73sm1431785pjg.25.2022.08.12.05.47.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Aug 2022 05:47:22 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660308446;\n\tbh=wQeQ1Ln3iAWeCQ+hlJFdS8O+yK8fw3jxJ25JPQM2QF0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=eOnbt7uawKm63O2YUWF4+IsVNJjpvU2Isqh5Y+tFJPgRnE+STohVlzZAKVQAXZHtr\n\tKGbgyaAau2FLG+m5uU/3aFdDuznHB6xF56i180S9vA531y9KepWzikRJ8FmnW6KYNb\n\t/ksJjl4epc2YP2t/qocvR5yO931t/BuJkHLkG1z2fVJOceAe0pMJ+N4AliI3f6YPHb\n\tCMQwpCNFSIyuuXbEM+NtLlbhQmvmSBMU+uwEZV+1oO77alonNExvh8QiTKTyx0EBrE\n\t4z8TodGcsdRPcihnAa1IUHVmjWVRvsGLnnPgfiqUhjcjvRMIWZzbGshfJrDdoptjIX\n\tmpIBRAVnO+BAA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=0mSGTAJYgBUn9gbfDNStPGozQZftpJdLDYTBsC3J34U=;\n\tb=ese1uDVr2Ioe9MXvV6lsFBm4CcK+nfxa2ki3gbYGytDgWbXf+LLSUO/zImr10kWj57\n\tda21LOta4o7D1sXP4qOHgjXD1yEhzrxJRGAbjDYU1GYJmrWNE4lZvhBeFIO/mOVxuTNc\n\tYMBZMshB50qtwNHNNFVrslAvVgWIFsh+47lArVRuCBtIGzkV3WZJOt2MmoOD2j5vjq9U\n\t2KBg3PxlpNxbUOF/T78KKHR02UTtfc7a/UrdBX7dcM/vn7LgiveUqueBA03vc0DqTC6D\n\tRnBPP34a8E3RrmMKY0T98yVAsgzIu5JDZlmwbw8z1ONgpXxYsyOnC+VY+8OJmX7apvKc\n\t2KgA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ese1uDVr\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=0mSGTAJYgBUn9gbfDNStPGozQZftpJdLDYTBsC3J34U=;\n\tb=KqUU1t3qg4pWjpR1vMTxjGr/6srRCl9nBimJhBhXAaX1Al/EiZwd4LOVqp22YILnWn\n\tBq98vgcaQmxeuYr1RGwyNYvLxM8vJCL6wz3curPhqi5mdJPVx81oTwYQg5rQQbQzhQ6B\n\tfd9D0t/ALyIQ669DkHd8R701CdECQZ+GvFBqT/jLWyKFG5+wmyr25gYKB4/92f/rymGl\n\tmWKtECYboMeJFkv4XUda7GSYHZII7futsViCE2uiYakXGFkqUTVExlR9yywdUHZCXSzX\n\txO1C0yTn+euX6Rgpa8ooAWNVI7TknvqfZhtLSAudVDElQT29Yuh8gPE9aM8ouy/g1P14\n\t1b/Q==", "X-Gm-Message-State": "ACgBeo1OXLdDiQDykxUOElYQ4X6wuaMXkTG0UmgQ3uXRromXbHpFJy2w\n\tLCFB2PHV3fNNNo8UnPiZbj4Lc0m473I=", "X-Google-Smtp-Source": "AA6agR5jb4sRx+6hsjr5LHI78qLpQPN2Mm6asLt7lKeW0z4qbS3K+yPpS6zjhyqpIbiwQbeBFogAmA==", "X-Received": "by 2002:a63:dd4b:0:b0:41d:e855:7137 with SMTP id\n\tg11-20020a63dd4b000000b0041de8557137mr3075434pgj.595.1660308442826; \n\tFri, 12 Aug 2022 05:47:22 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Aug 2022 18:16:50 +0530", "Message-Id": "<20220812124651.27496-11-utkarsh02t@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220812124651.27496-1-utkarsh02t@gmail.com>", "References": "<20220812124651.27496-1-utkarsh02t@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 10/11] qcam: ControlFrame: Add GUI way\n\tto interact with ControlTypeIntger32", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Utkarsh Tiwari via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Utkarsh Tiwari <utkarsh02t@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an integer slider for ControlTypeIntger32 control types.\nThe default value on the slider is the default value for the control\nand it may not be the current value for the control.\n\nSigned-off-by: Utkarsh Tiwari <utkarsh02t@gmail.com>\n---\n src/qcam/settings/control_frame.cpp | 16 ++++++++++++++++\n src/qcam/settings/control_frame.h | 1 +\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/src/qcam/settings/control_frame.cpp b/src/qcam/settings/control_frame.cpp\nindex 9e38da37..d9c294a2 100644\n--- a/src/qcam/settings/control_frame.cpp\n+++ b/src/qcam/settings/control_frame.cpp\n@@ -93,6 +93,19 @@ QWidget *ControlFrame::controlInteraction(QWidget *parent)\n \t\tSliderLayout *fSliderLayout = new SliderLayout(floatSlider_, this);\n \t\treturn fSliderLayout;\n \t}\n+\tcase ControlTypeInteger32: {\n+\t\tintSlider_ = new Slider(this);\n+\t\tintSlider_->setRange(controlInfo_.min().get<int32_t>(),\n+\t\t\t\t controlInfo_.max().get<int32_t>());\n+\t\tintSlider_->setValue(controlInfo_.def().get<int32_t>());\n+\t\tintSlider_->setOrientation(Qt::Orientation::Horizontal);\n+\n+\t\tconnect(intSlider_, &Slider::valueChanged,\n+\t\t\tthis, &ControlFrame::notifyControlChange);\n+\n+\t\tSliderLayout *iSliderLayout = new SliderLayout(intSlider_, this);\n+\t\treturn iSliderLayout;\n+\t}\n \tdefault:\n \t\treturn (new QLabel(\"Currently Unavailable\"));\n \t}\n@@ -162,6 +175,9 @@ void ControlFrame::notifyControlChange()\n \tcase ControlTypeFloat:\n \t\tcontrolValue.set<float>(floatSlider_->value());\n \t\tbreak;\n+\tcase ControlTypeInteger32:\n+\t\tcontrolValue.set<int32_t>(intSlider_->value());\n+\t\tbreak;\n \tdefault:\n \t\t/* Nothing to emit so return */\n \t\treturn;\ndiff --git a/src/qcam/settings/control_frame.h b/src/qcam/settings/control_frame.h\nindex e9e256aa..205bb96b 100644\n--- a/src/qcam/settings/control_frame.h\n+++ b/src/qcam/settings/control_frame.h\n@@ -47,6 +47,7 @@ private:\n \tQCheckBox *controlCheckBox_;\n \tQLabel *currentValue_;\n \tFloatSlider *floatSlider_;\n+\tSlider *intSlider_;\n \n \t/* Helper Hunctions */\n \tQString getDefaultValueQStr();\n", "prefixes": [ "libcamera-devel", "v2", "10/11" ] }