Patch Detail
Show a patch.
GET /api/1.1/patches/17081/?format=api
{ "id": 17081, "url": "https://patchwork.libcamera.org/api/1.1/patches/17081/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17081/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220811150219.62066-6-jacopo@jmondi.org>", "date": "2022-08-11T15:02:18", "name": "[libcamera-devel,v2,5/6] ipa: rkisp1: Remove AE-related controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "618f97b241e38707a28a9e085583fe439e966ad9", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/1.1/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/17081/mbox/", "series": [ { "id": 3404, "url": "https://patchwork.libcamera.org/api/1.1/series/3404/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3404", "date": "2022-08-11T15:02:13", "name": "AEGC controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3404/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17081/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17081/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EDD2BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Aug 2022 15:02:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F11086333C;\n\tThu, 11 Aug 2022 17:02:42 +0200 (CEST)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D91CB63330\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Aug 2022 17:02:39 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id E70151BF205;\n\tThu, 11 Aug 2022 15:02:38 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660230163;\n\tbh=hOZPkh2xuR9o9pecJHmkjnSBInfMf4EmLkB0U2PWgc4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=NKIrdhG4NOGelB5O+1IxKt5pYlrHah546zXfvcQRU3m2AjPuvtF7br3n9CXW3rja7\n\tLJBOKEAHR7tuBeAVFLbMtOtHVGRv6stH+RRnH/+ktu14kWQf4YfIPsgLA5D70L40jZ\n\tGhWqvRAewaY1SshgyiKPuCwrFbeheFfSJy9dnO7fqx57+M85S0M/qlh5yok33fWy/G\n\ttHoK1H2TMoj1xwtdWcaW/e9+9AjjO8HXr7G10I96fGoZQ6Zrh+Z+p4xpvf9BncITjQ\n\tRNJ55XYcPZ1yt+hl0EONXPc58gpcTuUQ2FwJ1bkaGtcIk3e9tBiZ49LNfHdspdDpej\n\tmVdf4YqgEoMGA==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 11 Aug 2022 17:02:18 +0200", "Message-Id": "<20220811150219.62066-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20220811150219.62066-1-jacopo@jmondi.org>", "References": "<20220811150219.62066-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 5/6] ipa: rkisp1: Remove AE-related\n\tcontrols", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The RkISP1 IPA registers the AeEnabled control as available but\ndoes not handle it yet and returns the AeLocked control in\nthe prepareMetadata() function with a value currently hard-coded to 0.\n\nRemove the AEGC-related controls as they currently have no purpose and\nboth AeLocked and AeEnable will be removed in the next patch.\n\nA proper handling of the AEGC algorithm will have to be implemented\nusing the newly introduced AEGC controls.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/ipa/rkisp1/rkisp1.cpp | 19 ++++---------------\n 1 file changed, 4 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 17d42d38eb45..dac3a43f803d 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -64,7 +64,6 @@ protected:\n \n private:\n \tvoid setControls(unsigned int frame);\n-\tvoid prepareMetadata(unsigned int frame, unsigned int aeState);\n \n \tstd::map<unsigned int, FrameBuffer> buffers_;\n \tstd::map<unsigned int, MappedFrameBuffer> mappedBuffers_;\n@@ -91,7 +90,6 @@ namespace {\n \n /* List of controls handled by the RkISP1 IPA */\n const ControlInfoMap::Map rkisp1Controls{\n-\t{ &controls::AeEnable, ControlInfo(false, true) },\n \t{ &controls::Brightness, ControlInfo(-1.0f, 0.993f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n@@ -321,14 +319,15 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n \tcontext_.frameContext.sensor.gain =\n \t\tcamHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get<int32_t>());\n \n-\tunsigned int aeState = 0;\n-\n \tfor (auto const &algo : algorithms())\n \t\talgo->process(context_, nullptr, stats);\n \n \tsetControls(frame);\n \n-\tprepareMetadata(frame, aeState);\n+\t/* \\todo: prepare metadata. */\n+\n+\tControlList ctrls(controls::controls);\n+\tmetadataReady.emit(frame, ctrls);\n }\n \n void IPARkISP1::setControls(unsigned int frame)\n@@ -343,16 +342,6 @@ void IPARkISP1::setControls(unsigned int frame)\n \tsetSensorControls.emit(frame, ctrls);\n }\n \n-void IPARkISP1::prepareMetadata(unsigned int frame, unsigned int aeState)\n-{\n-\tControlList ctrls(controls::controls);\n-\n-\tif (aeState)\n-\t\tctrls.set(controls::AeLocked, aeState == 2);\n-\n-\tmetadataReady.emit(frame, ctrls);\n-}\n-\n } /* namespace ipa::rkisp1 */\n \n /*\n", "prefixes": [ "libcamera-devel", "v2", "5/6" ] }