Patch Detail
Show a patch.
GET /api/1.1/patches/1706/?format=api
{ "id": 1706, "url": "https://patchwork.libcamera.org/api/1.1/patches/1706/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1706/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190716060042.23035-1-laurent.pinchart@ideasonboard.com>", "date": "2019-07-16T06:00:42", "name": "[libcamera-devel] libcamera: stream: Initialise pixelFormat in StreamConfiguration()", "commit_ref": "a68cec65c196c24d122026bbc980028cc7d266cc", "pull_url": null, "state": "accepted", "archived": false, "hash": "27a557b14edd557423de1b5e3d9a2996339f72ce", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1706/mbox/", "series": [ { "id": 434, "url": "https://patchwork.libcamera.org/api/1.1/series/434/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=434", "date": "2019-07-16T06:00:42", "name": "[libcamera-devel] libcamera: stream: Initialise pixelFormat in StreamConfiguration()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/434/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1706/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1706/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D1A1618D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jul 2019 08:01:15 +0200 (CEST)", "from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a00:79e1:abc:3602:59ec:6c:1869:337])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42D12564\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jul 2019 08:01:13 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563256875;\n\tbh=fX/xYLk4WVordVhYdt2eP+uE0yE9XH8fVSTkceWlasU=;\n\th=From:To:Subject:Date:From;\n\tb=ernsie2eoD3i2fYRbJmypAqwMXh/qLPqiiQONbUw2YJpnNjkDcEYR2uxKqJdsdeiz\n\tlGi8lXDZ5PANplkTgjepGGqnQH+r11eu6A37TQbRqEx7auolg30qanTkditmu3JXzt\n\tWP6Y5X9XlWOLmvWKphuJHP7ofvX8L9b3rqfCu18k=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 16 Jul 2019 09:00:42 +0300", "Message-Id": "<20190716060042.23035-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: stream: Initialise pixelFormat\n\tin StreamConfiguration()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 16 Jul 2019 06:01:15 -0000" }, "content": "To avoid depending on unitialised values, set the pixelFormat field of\nthe StreamConfiguration class to 0 in the constructor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/stream.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\nindex de505d12c07a..c28b4cd669b2 100644\n--- a/src/libcamera/stream.cpp\n+++ b/src/libcamera/stream.cpp\n@@ -289,7 +289,7 @@ SizeRange StreamFormats::range(unsigned int pixelformat) const\n * handlers provied StreamFormats.\n */\n StreamConfiguration::StreamConfiguration()\n-\t: memoryType(InternalMemory), stream_(nullptr)\n+\t: pixelFormat(0), memoryType(InternalMemory), stream_(nullptr)\n {\n }\n \n@@ -297,7 +297,8 @@ StreamConfiguration::StreamConfiguration()\n * \\brief Construct a configuration with stream formats\n */\n StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n-\t: memoryType(InternalMemory), stream_(nullptr), formats_(formats)\n+\t: pixelFormat(0), memoryType(InternalMemory), stream_(nullptr),\n+\t formats_(formats)\n {\n }\n \n", "prefixes": [ "libcamera-devel" ] }