Patch Detail
Show a patch.
GET /api/1.1/patches/16991/?format=api
{ "id": 16991, "url": "https://patchwork.libcamera.org/api/1.1/patches/16991/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16991/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220805181850.848886-5-umang.jain@ideasonboard.com>", "date": "2022-08-05T18:18:49", "name": "[libcamera-devel,4/5] utils: ipu3: Executable helper to read statistics", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "e8e2276ea1305d5a5580467f0f840e8649af7087", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16991/mbox/", "series": [ { "id": 3378, "url": "https://patchwork.libcamera.org/api/1.1/series/3378/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3378", "date": "2022-08-05T18:18:45", "name": "IMGU standalone streaming", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3378/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16991/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16991/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E4DF8BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 5 Aug 2022 18:19:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4CD963338;\n\tFri, 5 Aug 2022 20:19:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A6E663338\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Aug 2022 20:19:05 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3e:69e0:a479:4ccc:ab2a:bf48])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 61D9A480;\n\tFri, 5 Aug 2022 20:19:04 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659723546;\n\tbh=fGrdO2TuEep+O+72BRzStN55XplH5FweOMO9CGFaOEk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=erFMzaWUWt6NoJESgtlimtVKVQpl4T3/XigjYRULK/i9wfFEAYAK9zjyRQdnx9wjh\n\tOjGzdaPXVatEebY6liYC765DXhF2u3qstHZ4Bvy6OwyD1WtvUWyZD5hEXD3lKpo2aX\n\txM8yBPv9mtIDkQZ4rJkzhY2yJuaW2cGAtUO5mYi/bebIOZzLsTKUb6fEXovy8oytd+\n\tEO9QB6oYrx9OS8usXoAaJ12Cw0ImHU/LAxaPhKHsz+k6s6Z6/yTf622JiPH/BsxVJP\n\tPRIXrzk+yl4Q3AMQt6L3gpLUiD9V/bNo5kun1X7tR8xaalDFhVQKkwcZ78NZPi/+uE\n\ta4JxMdP2e5VWw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659723545;\n\tbh=fGrdO2TuEep+O+72BRzStN55XplH5FweOMO9CGFaOEk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uEWCf5SoQE8DuL//UVHlSPxaDjd9XG+uDOYsdMkJEz5vuXy8IE2wvEPKP75uRKnMf\n\tdVbdJCdUu3J8K5pWWdmQ6bIM8nXWFryykToWYhfwDjzdK7PtuEcefXygE1uEbZI+cr\n\tRijytFdvSnvkGy1hjQoRDtzDEbC7SveriT0uH0Ss=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uEWCf5So\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Aug 2022 23:48:49 +0530", "Message-Id": "<20220805181850.848886-5-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220805181850.848886-1-umang.jain@ideasonboard.com>", "References": "<20220805181850.848886-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 4/5] utils: ipu3: Executable helper to\n\tread statistics", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Usage: ipu3-read-stats input-file output-file\n\n[Currently only reads R,G,B averages out of AWB]\nTo be extended to dump more meaningful stats.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n utils/ipu3/ipu3-read-stats.c | 168 +++++++++++++++++++++++++++++++++++\n utils/ipu3/meson.build | 2 +\n 2 files changed, 170 insertions(+)\n create mode 100644 utils/ipu3/ipu3-read-stats.c", "diff": "diff --git a/utils/ipu3/ipu3-read-stats.c b/utils/ipu3/ipu3-read-stats.c\nnew file mode 100644\nindex 00000000..cd342a63\n--- /dev/null\n+++ b/utils/ipu3/ipu3-read-stats.c\n@@ -0,0 +1,168 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * ipu3-read-stats - Dump IPU3 statistics\n+ *\n+ * Copyright 2022 Umang Jain <umang.jain@ideasonboard.com>\n+ */\n+#define _GNU_SOURCE\n+\n+#include <errno.h>\n+#include <fcntl.h>\n+#include <limits.h>\n+#include <stdint.h>\n+#include <stdio.h>\n+#include <stdlib.h>\n+#include <string.h>\n+#include <unistd.h>\n+\n+#include \"../../include/linux/intel-ipu3.h\"\n+\n+static void usage(const char *argv0)\n+{\n+\tprintf(\"Utility for dumping IPU3 statistics\\n\");\n+\tprintf(\"Usage: %s --if <size> --bds <size> --gdc <size> input-file output-file\\n\",\n+\t basename(argv0));\n+\tprintf(\"<size> widthxheight\\n\");\n+\tprintf(\"If the output-file '-', output data will be written to standard output\\n\");\n+}\n+\n+void readSize(const char *size, unsigned int *w, unsigned int *h)\n+{\n+\tchar *sz = strdup(size);\n+\tconst char *delim = \"x\";\n+\tchar *token = strtok(sz, delim);\n+\tif (token)\n+\t\t*w = atoi(token);\n+\n+\ttoken = strtok(NULL, delim);\n+\tif (token)\n+\t\t*h = atoi(token);\n+}\n+\n+int main(int argc, char *argv[])\n+{\n+\tint in_fd;\n+\tFILE *fout;\n+\tint ret;\n+\tunsigned int bds_w, bds_h = 0;\n+\tunsigned int iif_w, iif_h = 0;\n+\tunsigned int gdc_w, gdc_h = 0;\n+\n+\tif (argc != 9) {\n+\t\tusage(argv[0]);\n+\t\treturn 1;\n+\t}\n+\n+\tif (strcmp(argv[1], \"--if\") == 0) {\n+\t\treadSize(argv[2], &iif_w, &iif_h);\n+\t}\n+\n+\tif (strcmp(argv[3], \"--bds\") == 0) {\n+\t\treadSize(argv[4], &bds_w, &bds_h);\n+\t}\n+\n+\tif (strcmp(argv[5], \"--gdc\") == 0) {\n+\t\treadSize(argv[6], &gdc_w, &gdc_h);\n+\t}\n+\n+\tif (!bds_w || !bds_h || !iif_w || !iif_h || !gdc_w || !gdc_h) {\n+\t\tusage(argv[0]);\n+\t\treturn 1;\n+\t}\n+\n+\tin_fd = open(argv[7], O_RDONLY);\n+\tif (in_fd == -1) {\n+\t\tfprintf(stderr, \"Failed to open statistics file '%s': %s\\n\",\n+\t\t\targv[1], strerror(errno));\n+\t\treturn 1;\n+\t}\n+\n+\tif (strcmp(argv[8], \"-\") == 0) {\n+\t\tfout = stdout;\n+\t} else {\n+\t\tfout = fopen(argv[8], \"w\");\n+\t\tif (!fout) {\n+\t\t\tfprintf(stderr, \"Failed to open output file '%s': %s\\n\",\n+\t\t\t\targv[4], strerror(errno));\n+\t\t\tclose(in_fd);\n+\t\t\treturn 1;\n+\t\t}\n+\t}\n+\n+\tint frame = 0;\n+\tstruct ipu3_uapi_stats_3a *stats = (struct ipu3_uapi_stats_3a *) malloc(sizeof(struct ipu3_uapi_stats_3a));\n+\n+\twhile (1) {\n+\t\tret = read(in_fd, stats, sizeof(struct ipu3_uapi_stats_3a));\n+\t\tif (ret < 0) {\n+\t\t\tfprintf(stderr, \"Failed to read stats data: %s\\n\",\n+\t\t\t\tstrerror(errno));\n+\t\t\tgoto done;\n+\t\t}\n+\n+\t\tif ((unsigned)ret < sizeof(struct ipu3_uapi_stats_3a)) {\n+\t\t\tif (ret != 0)\n+\t\t\t\tfprintf(stderr, \"%u bytes of stray data at end of input\\n\",\n+\t\t\t\t\tret);\n+\t\t\tgoto done;\n+\t\t}\n+\n+\t\t/* ================ Dump AWB stats ================ */\n+\n+\t\tuint32_t k_min_grid_w = 16;\n+\t\tuint32_t k_max_grid_w = 80;\n+\t\tuint32_t minError = UINT_MAX;\n+\t\tuint32_t best_log2 = 0;\n+\t\tuint32_t stride = 0;\n+\n+\t\tstruct ipu3_uapi_grid_config grid = stats->stats_4a_config.awb_config.grid;\n+\n+\t\tfor (uint32_t shift = grid.block_width_log2; shift <= 6; ++shift) {\n+\t\t\tuint32_t width = bds_w >> shift;\n+\t\t\tif (width < k_min_grid_w)\n+\t\t\t\twidth = k_min_grid_w;\n+\t\t\telse if (width > k_max_grid_w)\n+\t\t\t\twidth = k_max_grid_w;\n+\n+\t\t\twidth = width << shift;\n+\t\t\tuint32_t error = bds_w > width ? bds_w - width : width - bds_w;\n+\t\t\tif (error >= minError)\n+\t\t\t\tcontinue;\n+\n+\t\t\tminError = error;\n+\t\t\tstride = width;\n+\t\t\tbest_log2 = shift;\n+\t\t}\n+\n+\t\tstride = stride >> best_log2;\n+\n+\t\t/* Sum the per-channel averages */\n+\t\tdouble red_sum = 0, green_sum = 0, blue_sum = 0;\n+\t\tfor (unsigned int cellY = 0; cellY < grid.height; cellY++) {\n+\t\t\tfor (unsigned int cellX = 0; cellX < grid.width; cellX++) {\n+\t\t\t\tuint32_t cell_pos = cellY * stride + cellX;\n+\n+\t\t\t\tconst struct ipu3_uapi_awb_set_item *cell =\n+\t\t\t\t\t(const struct ipu3_uapi_awb_set_item *)(\n+\t\t\t\t\t\t&stats->awb_raw_buffer.meta_data[cell_pos]\n+\t\t\t\t\t);\n+\t\t\t\tconst uint8_t G_avg = (cell->Gr_avg + cell->Gb_avg) / 2;\n+\n+\t\t\t\tred_sum += cell->R_avg;\n+\t\t\t\tgreen_sum += G_avg;\n+\t\t\t\tblue_sum += cell->B_avg;\n+\t\t\t}\n+\t\t}\n+\n+\t\tfprintf(fout, \"Frame: %d, redSum: %.1f, greenSum: %.1f, blueSum: %.1f\\n\",\n+\t\t\tframe, red_sum, green_sum, blue_sum);\n+\t\tframe++;\n+\t}\n+\n+done:\n+\tfree(stats);\n+\tclose(in_fd);\n+\tfclose(fout);\n+\n+\treturn ret ? 1 : 0;\n+}\ndiff --git a/utils/ipu3/meson.build b/utils/ipu3/meson.build\nindex c92cc658..88fc2a1b 100644\n--- a/utils/ipu3/meson.build\n+++ b/utils/ipu3/meson.build\n@@ -2,3 +2,5 @@\n \n ipu3_pack = executable('ipu3-pack', 'ipu3-pack.c')\n ipu3_unpack = executable('ipu3-unpack', 'ipu3-unpack.c')\n+\n+ipu3_read_stats = executable('ipu3-read-stats', 'ipu3-read-stats.c')\n", "prefixes": [ "libcamera-devel", "4/5" ] }