Patch Detail
Show a patch.
GET /api/1.1/patches/16977/?format=api
{ "id": 16977, "url": "https://patchwork.libcamera.org/api/1.1/patches/16977/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16977/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220805135312.47497-3-jacopo@jmondi.org>", "date": "2022-08-05T13:53:04", "name": "[libcamera-devel,v2,02/10] libcamera: pipeline: uvcvideo: Report control errors", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "5bebb14ce8086cf2d88147a831f1f390886a792f", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16977/mbox/", "series": [ { "id": 3376, "url": "https://patchwork.libcamera.org/api/1.1/series/3376/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3376", "date": "2022-08-05T13:53:02", "name": "libcamera: Align IPU3 and RKISP1 interfaces", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3376/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16977/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16977/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E002C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 5 Aug 2022 13:53:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CFE2D63334;\n\tFri, 5 Aug 2022 15:53:25 +0200 (CEST)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D262603E4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Aug 2022 15:53:23 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 53BA11C0004;\n\tFri, 5 Aug 2022 13:53:22 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659707605;\n\tbh=JDasz4YVrK4E+L/SvZPCkQc1lQ9cWlzn+yfqm/fq91U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Q1xP8uB7gEV6GSk6st4lpmQtjqCH+pM8zXuei9atGw6EaG17fr92M47o509Im9Vd2\n\t77J2kETjfgekhVP8507QQjsjK8Smsk2wUDYZ1D5J13+ZOIRygGVIvZVMDxu1RrAI0E\n\t+V7Qrh1OFVr/toMLi5+ichwzHzIv08bgGPkZrnGQkusrTBgRs+Nfx15BhM8PFHACgk\n\tVq9u8w6LGhH2yMDmyF8m9T9re/+zNB6KpqCV40gG+RUH8EE3+YztStgnFP1Dhn8FX3\n\tKlSB1YKxZd8uJNAdkqU4NtV3TTREV1uBesOdgeF6WOaLsZBmOSnPOqJfV3UL4RfhxH\n\t7yhHsi7B3sPBA==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Aug 2022 15:53:04 +0200", "Message-Id": "<20220805135312.47497-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20220805135312.47497-1-jacopo@jmondi.org>", "References": "<20220805135312.47497-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 02/10] libcamera: pipeline: uvcvideo:\n\tReport control errors", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham via libcamera-devel <libcamera-devel@lists.libcamera.org>\n\nReport an error when failing to process controls, but still allow the\nrequest to process and complete where possible.\n\nThe Request ControlError flag is raised on the request.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=135\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex fbe02cdcd520..8ffa27b1337b 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -26,6 +26,7 @@\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/request.h\"\n #include \"libcamera/internal/sysfs.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n@@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n \t}\n \n \tint ret = processControls(data, request);\n-\tif (ret < 0)\n-\t\treturn ret;\n+\tif (ret < 0) {\n+\t\tLOG(UVC, Error) << \"Failed to process controls\";\n+\t\trequest->_d()->setError(Request::ControlError);\n+\t}\n \n \tret = data->video_->queueBuffer(buffer);\n \tif (ret < 0)\n", "prefixes": [ "libcamera-devel", "v2", "02/10" ] }