Patch Detail
Show a patch.
GET /api/1.1/patches/16972/?format=api
{ "id": 16972, "url": "https://patchwork.libcamera.org/api/1.1/patches/16972/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16972/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220805124027.530212-2-fsylvestre@baylibre.com>", "date": "2022-08-05T12:40:25", "name": "[libcamera-devel,v2,1/3] ipa: rkisp1: Add enable field for AWB algorithm in IPA context", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "af00377a91b05acf183b2a7281adfcbf1ef2a614", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16972/mbox/", "series": [ { "id": 3375, "url": "https://patchwork.libcamera.org/api/1.1/series/3375/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3375", "date": "2022-08-05T12:40:24", "name": "Add DPF tuning support for RkISP1", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3375/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16972/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16972/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B2F7BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 5 Aug 2022 12:40:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ECD863330;\n\tFri, 5 Aug 2022 14:40:34 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ADD263313\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Aug 2022 14:40:32 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id n185so1361189wmn.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 05 Aug 2022 05:40:32 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:997d:fb84:b99a:cc47])\n\tby smtp.gmail.com with ESMTPSA id\n\tw13-20020adff9cd000000b0021db7b0162esm3869206wrr.105.2022.08.05.05.40.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 05 Aug 2022 05:40:31 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659703234;\n\tbh=jA1/7M/RCBjreSLkpxhny7j2mPWk69IyCShtV2DVL3A=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1XCi0lzyFHf7x8H5AUMy6UxrPK7R0wBa/j9NZLqYAKwAIV/V/mrwyYlSt043iWU6+\n\tkBKoy5scODh0AHarIiLoS1HdrpoyjZMlDNTPCZ1pehAKAriAlJ9EU2KAX4rA0lcwc0\n\tABrq0PeWUBEtyGLaOvg/pleaHFh14c1ljN3DdKxPYPW9TKh3mYdKrZjOJF2VDerFhF\n\t9rA0jnKOWBRRuUsnnA4IJws78N3mEQgWAVsgBE0ON2f9w+eF1lGLqWOBy3GBkXm0K6\n\tGf2STPjbHVtnYaWGsh4UyRBUGx3QaRTP41iU+UCQy4c2C0z6F49jIdMqkTmwr5qgjv\n\tqiG4t2HxveGPA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc;\n\tbh=CYikZf9gDAhn+XN0urxGrNKw7RUkr01ALRPdrjmuwMs=;\n\tb=hM1x823gxTdPx3ligq7XY5tbwkKcMZDEajKec2qr/cJ2K5KXXMnI+qZZQtMiDq+Qc4\n\tsRZX/Z/uOccAH6DHbNlQ//JZwyeq0Do9WY+J4EuDhjz7fLYEl9bCqhH6aNzcKDKST7s3\n\tpBarNhtmkP/F4Ay6ze0+ZZ+fPxb+6MTDhwiHLs/NIPpBdZNPGjRJKRHx2rZhLPdVuQE9\n\ta/rX1okL1csVibF1n+/pIJd4OfKpZpPEr8/Tn+oEJO4X4YP74hY4ed5feKn43guIghJC\n\teOSgsSYNsw0q2OsEHaVQ1eWDUpaWKU+XJMeORJ+vJ86qSoKjpmeqtBiUUbt10kzbytk7\n\tV3SA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"hM1x823g\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc;\n\tbh=CYikZf9gDAhn+XN0urxGrNKw7RUkr01ALRPdrjmuwMs=;\n\tb=h0ZTNx++LwIPwFrPnesEdEQEknulvwIx7Cs5bq05iNXMhjA6sVBMfU6HRaWNG+sJJZ\n\trQsgg+94IdDxE5ttx9xv6C+WHt2khm+poDD1Cc3XskF9U5KlQ3fHPYo/ea0AuxyxcxD4\n\t0zCK3Ht9Zx86DzQDT8T6F3IeefDUxPy5fYza6mlRndPgVusbmA4c4i1Xg/xVbZjn5VeN\n\tSD/Dn9agqFoZ4G5LLa2d4JP75bATJXHjsPuzmjB2t1sfGRqKpixHAC34pHXj71oTZU6Z\n\tDoF1KbeiiUhAM1fP9BUHLnwoxADomlA2+opVP+CyeLrlpKaS+SrEfIiUhFeaGz754jgy\n\t7B5A==", "X-Gm-Message-State": "ACgBeo0irz/AjfSkZw9y5u1/t0B6wnc0CQSMCf634/l1unr+2eTDTklM\n\tKzw8/qNrNN7s44W66WGVEUnu8r25Z8OtNs7r", "X-Google-Smtp-Source": "AA6agR7drcaVXTgMRQ/Bln4lAcP0UpARPl00GdS5Nzs/V3dwzIaYSPySbyi73IuvB1Vax5yTvram9Q==", "X-Received": "by 2002:a05:600c:5120:b0:3a3:2ae4:fb20 with SMTP id\n\to32-20020a05600c512000b003a32ae4fb20mr4454951wms.81.1659703231600; \n\tFri, 05 Aug 2022 05:40:31 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 5 Aug 2022 14:40:25 +0200", "Message-Id": "<20220805124027.530212-2-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220805124027.530212-1-fsylvestre@baylibre.com>", "References": "<20220805124027.530212-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/3] ipa: rkisp1: Add enable field for\n\tAWB algorithm in IPA context", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an enable variable in the awb struct in IPASessionConfiguration which\nindicates if the awb algorithm has been configured. This will allow other\nalgorithms to retrieve this information.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 1 +\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 9f00364d..d1328f01 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -48,6 +48,8 @@ int Awb::configure(IPAContext &context,\n \tcontext.configuration.awb.measureWindow.h_size = 3 * configInfo.outputSize.width / 4;\n \tcontext.configuration.awb.measureWindow.v_size = 3 * configInfo.outputSize.height / 4;\n \n+\tcontext.configuration.awb.enabled = true;\n+\n \treturn 0;\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex ef8bb8e9..23a63f8c 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -87,6 +87,9 @@ namespace libcamera::ipa::rkisp1 {\n *\n * \\var IPASessionConfiguration::awb.measureWindow\n * \\brief AWB measure window\n+ *\n+ * \\var IPASessionConfiguration::awb.enabled\n+ * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n */\n \n /**\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 2bdb6a81..7f7b3e4d 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -29,6 +29,7 @@ struct IPASessionConfiguration {\n \n \tstruct {\n \t\tstruct rkisp1_cif_isp_window measureWindow;\n+\t\tbool enabled;\n \t} awb;\n \n \tstruct {\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }