Patch Detail
Show a patch.
GET /api/1.1/patches/16968/?format=api
{ "id": 16968, "url": "https://patchwork.libcamera.org/api/1.1/patches/16968/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16968/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220804141228.417211-2-fsylvestre@baylibre.com>", "date": "2022-08-04T14:12:26", "name": "[libcamera-devel,1/3] ipa: rkisp1: Add enable field for AWB algorithm in IPA context", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "493f694a788775abd44f634ac268b39cf13c8b42", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16968/mbox/", "series": [ { "id": 3374, "url": "https://patchwork.libcamera.org/api/1.1/series/3374/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3374", "date": "2022-08-04T14:12:25", "name": "Add DPF tuning support for RkISP1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3374/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16968/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16968/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B945C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Aug 2022 14:12:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 410CB6332F;\n\tThu, 4 Aug 2022 16:12:36 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9342B6330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Aug 2022 16:12:34 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id bv3so11510724wrb.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Aug 2022 07:12:34 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:d073:c231:2c43:c9cf])\n\tby smtp.gmail.com with ESMTPSA id\n\ti5-20020a05600c2d8500b003a325bd8517sm1616948wmg.5.2022.08.04.07.12.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Aug 2022 07:12:32 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659622356;\n\tbh=Z8enGdwh8QvFKXJjbPxTGArPxMbzZaH3mArrLRmY19o=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=llaRRLlrIqJqjfWnwk5HfD8TnmKQ4dpqgvFGusqTkIgKlDKp7jwVC3wb+hx8hdFFd\n\tHXFFVrHZqM52FZNNIly98ssQV7x2KU8gk/4GK7o333Q15Kwtqtd6aKrLNw1JJSdhXo\n\tyxghqIAC2jk5UNSs419cBgpQJN7Snxda9fVJJdBydn4zmmPu2f4kwyD23/uDXNm9+A\n\t/JPE8T1k8WZYd+zwcgifWMAx+mQ5xdW+1sYd1F9RXacoKl3oEY4kL0skMdJRmazGm8\n\tSr392KaYFWSEVexta0SYCwteKih7/S+O39XSsKrFIZuVa6q0TDVANirhs/uCSXy60r\n\tudJq0uOGALsjA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KiE3kzDMQPEGN7jLQ2xZUp7u49vuV8YvBM6aut3iZoc=;\n\tb=5x2zuZd9UR2edOcY9LlULZ5Wk72YCBo5UEAw0jzUWxNn1FSA5itSUd8Z3HJGhQVoTg\n\tegzzK6Xkmnxd5XQmBbgeklja+ryVIPGrCCsb70gK53cd9jQbpGnz9x+Vpj5KkaWxqltI\n\t4DF8BPSCc1MGPtN6QNVX3NDDjqIit3pPv2EblXdVGzr1m1WJkwH2FcaGJHgms5D1PcRR\n\txaPDIcNzy12eDW/0EDA9mO1gorbl5MJGTNlqQczZMPUtMoi5hGBj5Xfyev0GPtaINWCg\n\tJ9XcIwN3kGa78WGorUBQfxKXKx42WGUIHXRVzGY/shyLwU67KA+daQUJvy3Gp8KewXFV\n\t2p3g==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"5x2zuZd9\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=KiE3kzDMQPEGN7jLQ2xZUp7u49vuV8YvBM6aut3iZoc=;\n\tb=DvgJag+Z7ReKSCzJn/ONSG2fngqXz12QP/tRxwWuAiCqkOFJcjYUwFGiQXO/wH71pv\n\tVxU/1xBDAjJ0HpyEP43l6FVTboRT9vrZ0+ikUSLeVsDRpBvcU2wZzNLkDxFV0Idbfm0S\n\tLgswzqfNNOtOGTbpajg98/ikcbwCtfcdJW2BRWo6m6bWcWaA7caIeV1h90coe374YvZb\n\trJqPcYDpaPfxVUGc8GollTQ7Hx2968ZuQL9wcan0JiZoYuNaaEmSrtaLcZ0BKzsYBtfZ\n\t68THcYUU2mkyH3pu+Mhuav2YtfCeaky3BZrNRj8CpN4AIvAkjAxz0Z/sDDLEwV3UwRd/\n\t4K/Q==", "X-Gm-Message-State": "ACgBeo1EvuJ887mV/i9+Ae6XdD45ZQtE96PUnxtZ4sjyIbEFjYbtYNT/\n\twOu6+QJRXVLHraIu7qRSH7Sc55hFbKTIIzoP", "X-Google-Smtp-Source": "AA6agR5kzn0IjP9Vdoo1SIby8+4QGxgOjalBKzVCWBUyRDF/Kt/KiO7ElWDr5sy5XW18DAw6oUxi2Q==", "X-Received": "by 2002:adf:ce0e:0:b0:220:7eed:3ce3 with SMTP id\n\tp14-20020adfce0e000000b002207eed3ce3mr1523835wrn.148.1659622353904; \n\tThu, 04 Aug 2022 07:12:33 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Aug 2022 16:12:26 +0200", "Message-Id": "<20220804141228.417211-2-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220804141228.417211-1-fsylvestre@baylibre.com>", "References": "<20220804141228.417211-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] ipa: rkisp1: Add enable field for AWB\n\talgorithm in IPA context", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an enable variable in the awb struct in IPASessionConfiguration which\nindicates if the awb algorithm has been configured. This will allow other\nalgorithms to retrieve this information.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n src/ipa/rkisp1/ipa_context.cpp | 3 +++\n src/ipa/rkisp1/ipa_context.h | 1 +\n 3 files changed, 6 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 9f00364d..d1328f01 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -48,6 +48,8 @@ int Awb::configure(IPAContext &context,\n \tcontext.configuration.awb.measureWindow.h_size = 3 * configInfo.outputSize.width / 4;\n \tcontext.configuration.awb.measureWindow.v_size = 3 * configInfo.outputSize.height / 4;\n \n+\tcontext.configuration.awb.enabled = true;\n+\n \treturn 0;\n }\n \ndiff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\nindex ef8bb8e9..d833b8c7 100644\n--- a/src/ipa/rkisp1/ipa_context.cpp\n+++ b/src/ipa/rkisp1/ipa_context.cpp\n@@ -87,6 +87,9 @@ namespace libcamera::ipa::rkisp1 {\n *\n * \\var IPASessionConfiguration::awb.measureWindow\n * \\brief AWB measure window\n+ *\n+ * \\var IPASessionConfiguration::awb.enabled\n+ * \\brief Indicates if AWB is enabled\n */\n \n /**\ndiff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\nindex 2bdb6a81..7f7b3e4d 100644\n--- a/src/ipa/rkisp1/ipa_context.h\n+++ b/src/ipa/rkisp1/ipa_context.h\n@@ -29,6 +29,7 @@ struct IPASessionConfiguration {\n \n \tstruct {\n \t\tstruct rkisp1_cif_isp_window measureWindow;\n+\t\tbool enabled;\n \t} awb;\n \n \tstruct {\n", "prefixes": [ "libcamera-devel", "1/3" ] }