Patch Detail
Show a patch.
GET /api/1.1/patches/16961/?format=api
{ "id": 16961, "url": "https://patchwork.libcamera.org/api/1.1/patches/16961/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16961/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220804104550.4600-2-david.plowman@raspberrypi.com>", "date": "2022-08-04T10:45:49", "name": "[libcamera-devel,1/2] libcamera: formats: Fix colour encoding for \"R\" raw greyscale formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c9522c704e2bb21d8d93e0f929a3d38f380f917", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16961/mbox/", "series": [ { "id": 3371, "url": "https://patchwork.libcamera.org/api/1.1/series/3371/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3371", "date": "2022-08-04T10:45:48", "name": "Fixes for raw monochrome stream configurations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3371/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16961/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16961/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE42BBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Aug 2022 10:45:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92AB363331;\n\tThu, 4 Aug 2022 12:45:56 +0200 (CEST)", "from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 987406330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Aug 2022 12:45:55 +0200 (CEST)", "by mail-wr1-x42d.google.com with SMTP id q30so20346862wra.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Aug 2022 03:45:55 -0700 (PDT)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\te27-20020adfa45b000000b0021e519eba9bsm829695wra.42.2022.08.04.03.45.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Aug 2022 03:45:54 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659609956;\n\tbh=+XYWrQXBC1YNIdr5eRCe+J2mIAO8PoT4lguqeMhGZxc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=OmLlAbN/taN2SjiaYWvz49QJBXnig7b2m8hLQmuE+DtEO3jQ/khILGYQ9Vtlfe4CM\n\tOnA23zxW8YWqdm5bQjCblOu4yJoe6Oywd0f2xdhNaL6PLEfd1HHReW37l7riCFxZwY\n\tj/Sx6uHoYCnohTm6zvzRHoHktmOicEv169UKVxC9mEtMWN6ue2JXUVve5SLcKaocDS\n\tmiMwLm1aACfFQ4b5wTo1On/PFM1YQ8S1NvujNCPgZKit3TjNps5Pxx/dzok9vo551Y\n\tOFwDQw0U7cmN7kehoecQ3Ejen0BqIZ5xjMihCfk2g0qgUEXM0NDHI0IoJF2WJUh5v7\n\t2PUARgrkEBA6A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Xlzw8YCSMK5F64SjR8GkML66gVdV8/mu1+tBgl+fyk0=;\n\tb=B8YcjTNihQqpXx4/Rdy8e/NzBaJGzYa2erD2I2qU2k3CXBmyHjfZ9x9ZIKpi9vl72E\n\tOOnpUCZtF8L6MH1V1WAQkkRdhTa8prD/urCEnafkoYJVCPdy/5LZnUuEXbvYjRQvO2Js\n\tz84QJ4DWx7CwpSHiQrtQgTn2V38+deQrVimIsgTodCSbNtv3dHUYE7fz2iJxuTJfLymB\n\tXDnFqG/UzYqItBuDCmbwBiS0Uw4Ub4QEN3gbt11QcRO9m9IPUbtGk85RIRe+Ejna8i/f\n\twrSBGF4TVmIAMI5+sBQ35rKDCGNQu89HqYWtT3ioT2Ii+fci3ioSmre5CFZSAGz4dsi2\n\tuNHw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"B8YcjTNi\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Xlzw8YCSMK5F64SjR8GkML66gVdV8/mu1+tBgl+fyk0=;\n\tb=GLrk2VDhNNmC4KkMlqxkRGdo5YvvdPnsIqMenivMe8it7WkxzhnliZg6+dQ/9il3nC\n\t9ZAc/Jdf9YNMOH1gGZmJmeTx9KnPuwe16nfJTvai4MoAY8NKuw+lsJd3Kf+0632fBYb1\n\tmAs60hvzHaC7+IBpjUXUwz5I3cu/nLwY8zztREnuBLVvKRHidRVDi5pwFiOZgrw3qk3e\n\ty2WvBQKDzRWhqFAfJUKQ5ZXPhHWEtdIGOtMQjhOUCks2yGbA4T17JV4gw8PbluYQxWtb\n\tJ1edQC8cvzdrBT+6Qz4CfeIjLPCw0Tw3WJjzXDJ0kBIW6DmQf5mCr/WFqEyFEp2M7bEb\n\tcHug==", "X-Gm-Message-State": "ACgBeo0cWe+lrSTLO0rbZLpm1rOFAqFwk9m2Vkzuegak+z3GHRjKURMa\n\tOFPMqhr7H95Cx3GLvafWTaiFqf+U3Cnm+tM1", "X-Google-Smtp-Source": "AA6agR63yj3DEm9qx088iJqn+wJzYa7pcKpAuhtNgUzGS/UUaYPXXxpxhD7618OuTcWoiUMCr+yYeA==", "X-Received": "by 2002:a5d:6102:0:b0:220:6382:eab1 with SMTP id\n\tv2-20020a5d6102000000b002206382eab1mr987738wrt.539.1659609955051; \n\tThu, 04 Aug 2022 03:45:55 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 4 Aug 2022 11:45:49 +0100", "Message-Id": "<20220804104550.4600-2-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220804104550.4600-1-david.plowman@raspberrypi.com>", "References": "<20220804104550.4600-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/2] libcamera: formats: Fix colour\n\tencoding for \"R\" raw greyscale formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "These are being used for raw monochrome sensors and so the colour\nencoding should be \"raw\".\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/formats.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 283ecb3d..7b98fef2 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -531,7 +531,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t\t.multi = V4L2PixelFormat(),\n \t\t},\n \t\t.bitsPerPixel = 8,\n-\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 1, 1 }, { 0, 0 }, { 0, 0 } }},\n@@ -544,7 +544,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t\t.multi = V4L2PixelFormat(),\n \t\t},\n \t\t.bitsPerPixel = 10,\n-\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n@@ -557,7 +557,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t\t.multi = V4L2PixelFormat(),\n \t\t},\n \t\t.bitsPerPixel = 12,\n-\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = false,\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 2, 1 }, { 0, 0 }, { 0, 0 } }},\n@@ -570,7 +570,7 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t\t.multi = V4L2PixelFormat(),\n \t\t},\n \t\t.bitsPerPixel = 10,\n-\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n \t\t.packed = true,\n \t\t.pixelsPerGroup = 4,\n \t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n", "prefixes": [ "libcamera-devel", "1/2" ] }