Patch Detail
Show a patch.
GET /api/1.1/patches/16871/?format=api
{ "id": 16871, "url": "https://patchwork.libcamera.org/api/1.1/patches/16871/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16871/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220729160014.101503-3-jacopo@jmondi.org>", "date": "2022-07-29T16:00:10", "name": "[libcamera-devel,v3,2/6] libcamera: formats: Search PixelFormatInfo on multiple formats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a170844490a247da7ec71d169713021064b1ce86", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16871/mbox/", "series": [ { "id": 3350, "url": "https://patchwork.libcamera.org/api/1.1/series/3350/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3350", "date": "2022-07-29T16:00:08", "name": "libcamera: Map multiple V4L2 formats to a single libcamera::format", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3350/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16871/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16871/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 771D4C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Jul 2022 16:00:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3331763311;\n\tFri, 29 Jul 2022 18:00:29 +0200 (CEST)", "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E44CA63311\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jul 2022 18:00:24 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id D22B64000E;\n\tFri, 29 Jul 2022 16:00:23 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659110429;\n\tbh=PvdhqUVPD0MXc/Hi+kBKdnqskrwvRs8ReQgM5OnNk9w=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3HL0xPjD5i+sP4l6NP5S53LYw+WyRNcbARZnSd7gqF6sXnz6dQol+uN80sGkxzGd3\n\tzpFn6SL00hIFK+cxha15lRcKioUGz4dqWK+sRIBWGlJCI9pOqmY1e6JMfIE8FhTUMa\n\tDj7B6fnjboyVi2NAFHhVJdRmdB/HgFDA73PIHqRNBd6l044OpWefv3Xr+tQnFNN+d0\n\tHTmOoWya6uTujYEPPRK/XD2H1Bz0fMiWrkcaQLTENNYWE68F/MjQrUKPTrw/+B6DXK\n\t5yay8p/reP/WZvu+JQmQT3zwJ4Pjs3lJCX4lJgVbW2JEYX7whADloYaiYW/QxIy/Iy\n\toQdSrwipDguqA==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Jul 2022 18:00:10 +0200", "Message-Id": "<20220729160014.101503-3-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20220729160014.101503-1-jacopo@jmondi.org>", "References": "<20220729160014.101503-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/6] libcamera: formats: Search\n\tPixelFormatInfo on multiple formats", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Cc": "jozef@mlich.cz, Pavel Machek <pavel@ucw.cz>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The PixelFormatInfo::info(const V4L2PixelFormat &format) function\nreturns the PixelFormatInfo associated with a V4L2 pixel format.\n\nTo correctly support multiple V4L2 formats mapped to a single\nPixelFormatInfo rework the function to search the given V4L2 format\nin a list.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/formats.cpp | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)\n\n--\n2.37.1", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 3c536722f375..6921d5c43bcb 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -829,9 +829,18 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n */\n const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n {\n+\tauto matchFormats = [&format](const std::vector<V4L2PixelFormat> &formats) {\n+\t\tconst auto &it = std::find_if(formats.begin(), formats.end(),\n+\t\t\t\t\t [&format](const V4L2PixelFormat &fmt) {\n+\t\t\t\t\t\t return format == fmt;\n+\t\t\t\t\t });\n+\n+\t\treturn it != formats.end();\n+\t};\n+\n \tconst auto &info = std::find_if(pixelFormatInfo.begin(), pixelFormatInfo.end(),\n-\t\t\t\t\t[format](auto pair) {\n-\t\t\t\t\t\treturn pair.second.v4l2Formats[0] == format;\n+\t\t\t\t\t[&matchFormats](auto &pair) {\n+\t\t\t\t\t\treturn matchFormats(pair.second.v4l2Formats);\n \t\t\t\t\t});\n \tif (info == pixelFormatInfo.end())\n \t\treturn pixelFormatInfoInvalid;\n", "prefixes": [ "libcamera-devel", "v3", "2/6" ] }