Patch Detail
Show a patch.
GET /api/1.1/patches/16835/?format=api
{ "id": 16835, "url": "https://patchwork.libcamera.org/api/1.1/patches/16835/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16835/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220727084052.590421-5-fsylvestre@baylibre.com>", "date": "2022-07-27T08:40:51", "name": "[libcamera-devel,v4,4/5] include: linux: Update rkisp1 kernel header for DPCC configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cdf093f6c557941c39ebcfaeb31d036236bd45f0", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16835/mbox/", "series": [ { "id": 3334, "url": "https://patchwork.libcamera.org/api/1.1/series/3334/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3334", "date": "2022-07-27T08:40:47", "name": "Add GSL, LSC and DPCC tuning support for rkisp1", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3334/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16835/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16835/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66228BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 27 Jul 2022 08:41:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5B3B563323;\n\tWed, 27 Jul 2022 10:41:04 +0200 (CEST)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B80A63311\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Jul 2022 10:41:02 +0200 (CEST)", "by mail-wr1-x436.google.com with SMTP id h9so23239232wrm.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Jul 2022 01:41:02 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:5810:316e:87c:fc17])\n\tby smtp.gmail.com with ESMTPSA id\n\t16-20020a05600c241000b003a2f6367049sm1464275wmp.48.2022.07.27.01.41.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 27 Jul 2022 01:41:01 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658911264;\n\tbh=cq44WZNq0MH9EY9MPKJqmMxgjVTz9+P5Weyej4POxxs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Q4KgWk/xGHWSJM4BaGLW1cPEL1ghPK2sHDdkLkt85UliLf8ziMS4/T4ZX/KUfSEYr\n\t19UuuTphtLoaQzCXa8fsJXsk1BASPXES93sTx3XPy9aMzDcF+FHyTv4t9/niql8qUx\n\tGa0YFTavQrhAfpbWV6VATRbHVY9K7STJmgyJ0AG49LqUBNgQFlwyZox3nb9wEi1JpK\n\tneuZpqmygE+BeaXeaCH6DU7jPma5jO51J0ieCqpI9ps7yuhCoNa+MBd72m8oTorajc\n\thMGz9L+cUkA0Bq64IJIAOsO2fA6n6cMbRyKDWaCOQRcVGWSMXe4s4snM6QfAmdZ3PR\n\tHO6m77l05LfXA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=rXYLN3M+VURrLxs1TBEH4lG+n/DsAPURZjYMrvBhEAc=;\n\tb=njJcKOMzhV02mnCClam+9+OczRCDF0mgGRVE1a8x9RPv8ihauuwzMLx64BOGRJysQ0\n\tfmiNT4xdswWi4ILSqO5zeHqxRKvqXF933chwJLBLSds53wofpof4CXGwtSTJybh67ZIb\n\tCFE3jCuIWY0/8xtItaWQXl/peR91Fga3dwkaT3tOPYFxYVbaXLqNvKXaAnHYY4cBe9zI\n\toE/ggqFrHNG/CPfgD6a/Y390FnIKdTYVQyfVvPLek/6oVH9vRL9RVMKl/R4hrOGz4Ro0\n\to/i2jtLKnq+SkIozTATCETgB5mdTdloRq+38IOGdbGXjsS6oqz/QepwkckwKfGT6c/kQ\n\tAnkw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"njJcKOMz\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=rXYLN3M+VURrLxs1TBEH4lG+n/DsAPURZjYMrvBhEAc=;\n\tb=lTIC3ChWoji7VnXrxcKBTZVoZg8NbXVXJucBmPeRSwkcPmD5TOOI8u9Be2cDQwaNHc\n\tRSCR3iHAraBgcrPX4/kI1g8SImBzO0yuR0Cg41z1UukPsGwRSrDiP+h4I7j6L0QojqXu\n\thono2LQEvdF5AHpf6hGI0RJ/Gcs/a476Ohax/WAqHy5eXdVjJ5cGIphi1biPJceLo295\n\tAzmRUzuLLf11Ymnzp4uDnzIR5LtZu36RdCJa+ZKzqUjTxFqfbY4z97RIT0b0y/xvZwfc\n\t47k2C6VclvUpoFixvEqi+nGgCmQrFT8FqXzhyvlcepQej/ioc2InUI9RuIdaAe3LqZK3\n\tN8PQ==", "X-Gm-Message-State": "AJIora/YeGmIpRi2ao7JZ9vctZM8ag96p2PxN+5QQxqikguTFwXN4ehY\n\t1bdinzz5cEjHY+pm7IEFjikfYa4xV2KEhyjM", "X-Google-Smtp-Source": "AGRyM1txaUUqXJ3VpraxZmK5Nx4gArWglxDSIQmjNucbzXKjDeeQrkRlIT7MEEppMkDmQb/tER6zeg==", "X-Received": "by 2002:a05:6000:887:b0:21e:24a0:f302 with SMTP id\n\tca7-20020a056000088700b0021e24a0f302mr12944854wrb.466.1658911261913; \n\tWed, 27 Jul 2022 01:41:01 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 27 Jul 2022 10:40:51 +0200", "Message-Id": "<20220727084052.590421-5-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220727084052.590421-1-fsylvestre@baylibre.com>", "References": "<20220727084052.590421-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/5] include: linux: Update rkisp1\n\tkernel header for DPCC configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To improve the kernel interface, a proposal has been made to the\nlinux-kernel [1] to improve the configuration of the Defective\nPixel Cluster Correction (DPCC).\n\n[1]\nhttps://lore.kernel.org/linux-media/20220616160456.21549-1-laurent.pinchart@ideasonboard.com/\n\nUpdate the local copy of the rkisp1-config.h to match the proposal.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nAcked-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/linux/rkisp1-config.h | 77 +++++++++++++++++++++++++++--------\n 1 file changed, 61 insertions(+), 16 deletions(-)", "diff": "diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\nindex 9be67d63..0ed3dca8 100644\n--- a/include/linux/rkisp1-config.h\n+++ b/include/linux/rkisp1-config.h\n@@ -117,7 +117,46 @@\n /*\n * Defect Pixel Cluster Correction\n */\n-#define RKISP1_CIF_ISP_DPCC_METHODS_MAX 3\n+#define RKISP1_CIF_ISP_DPCC_METHODS_MAX\t\t\t\t3\n+\n+#define RKISP1_CIF_ISP_DPCC_MODE_STAGE1_ENABLE\t\t\t(1U << 2)\n+\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_G_CENTER\t(1U << 0)\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_RB_CENTER\t(1U << 1)\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_G_3X3\t\t(1U << 2)\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_RB_3X3\t\t(1U << 3)\n+\n+/* 0-2 for sets 1-3 */\n+#define RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_SET(n)\t\t((n) << 0)\n+#define RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_FIX_SET\t\t(1U << 3)\n+\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_PG_GREEN_ENABLE\t\t(1U << 0)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_LC_GREEN_ENABLE\t\t(1U << 1)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RO_GREEN_ENABLE\t\t(1U << 2)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RND_GREEN_ENABLE\t(1U << 3)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RG_GREEN_ENABLE\t\t(1U << 4)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_PG_RED_BLUE_ENABLE\t(1U << 8)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_LC_RED_BLUE_ENABLE\t(1U << 9)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RO_RED_BLUE_ENABLE\t(1U << 10)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RND_RED_BLUE_ENABLE\t(1U << 11)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RG_RED_BLUE_ENABLE\t(1U << 12)\n+\n+#define RKISP1_CIF_ISP_DPCC_LINE_THRESH_G(v)\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_LINE_THRESH_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_G(v)\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_PG_FAC_G(v)\t\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_PG_FAC_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_RND_THRESH_G(v)\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_RND_THRESH_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_RG_FAC_G(v)\t\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_RG_FAC_RB(v)\t\t\t((v) << 8)\n+\n+#define RKISP1_CIF_ISP_DPCC_RO_LIMITS_n_G(n, v)\t\t\t((v) << ((n) * 4))\n+#define RKISP1_CIF_ISP_DPCC_RO_LIMITS_n_RB(n, v)\t\t((v) << ((n) * 4 + 2))\n+\n+#define RKISP1_CIF_ISP_DPCC_RND_OFFS_n_G(n, v)\t\t\t((v) << ((n) * 4))\n+#define RKISP1_CIF_ISP_DPCC_RND_OFFS_n_RB(n, v)\t\t\t((v) << ((n) * 4 + 2))\n \n /*\n * Denoising pre filter\n@@ -250,16 +289,20 @@ struct rkisp1_cif_isp_bls_config {\n };\n \n /**\n- * struct rkisp1_cif_isp_dpcc_methods_config - Methods Configuration used by DPCC\n+ * struct rkisp1_cif_isp_dpcc_methods_config - DPCC methods set configuration\n *\n- * Methods Configuration used by Defect Pixel Cluster Correction\n+ * This structure stores the configuration of one set of methods for the DPCC\n+ * algorithm. Multiple methods can be selected in each set (independently for\n+ * the Green and Red/Blue components) through the @method field, the result is\n+ * the logical AND of all enabled methods. The remaining fields set thresholds\n+ * and factors for each method.\n *\n- * @method: Method enable bits\n- * @line_thresh: Line threshold\n- * @line_mad_fac: Line MAD factor\n- * @pg_fac: Peak gradient factor\n- * @rnd_thresh: Rank Neighbor Difference threshold\n- * @rg_fac: Rank gradient factor\n+ * @method: Method enable bits (RKISP1_CIF_ISP_DPCC_METHODS_SET_*)\n+ * @line_thresh: Line threshold (RKISP1_CIF_ISP_DPCC_LINE_THRESH_*)\n+ * @line_mad_fac: Line Mean Absolute Difference factor (RKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_*)\n+ * @pg_fac: Peak gradient factor (RKISP1_CIF_ISP_DPCC_PG_FAC_*)\n+ * @rnd_thresh: Rank Neighbor Difference threshold (RKISP1_CIF_ISP_DPCC_RND_THRESH_*)\n+ * @rg_fac: Rank gradient factor (RKISP1_CIF_ISP_DPCC_RG_FAC_*)\n */\n struct rkisp1_cif_isp_dpcc_methods_config {\n \t__u32 method;\n@@ -273,14 +316,16 @@ struct rkisp1_cif_isp_dpcc_methods_config {\n /**\n * struct rkisp1_cif_isp_dpcc_config - Configuration used by DPCC\n *\n- * Configuration used by Defect Pixel Cluster Correction\n+ * Configuration used by Defect Pixel Cluster Correction. Three sets of methods\n+ * can be configured and selected through the @set_use field. The result is the\n+ * logical OR of all enabled sets.\n *\n- * @mode: dpcc output mode\n- * @output_mode: whether use hard coded methods\n- * @set_use: stage1 methods set\n- * @methods: methods config\n- * @ro_limits: rank order limits\n- * @rnd_offs: differential rank offsets for rank neighbor difference\n+ * @mode: DPCC mode (RKISP1_CIF_ISP_DPCC_MODE_*)\n+ * @output_mode: Interpolation output mode (RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_*)\n+ * @set_use: Methods sets selection (RKISP1_CIF_ISP_DPCC_SET_USE_*)\n+ * @methods: Methods sets configuration\n+ * @ro_limits: Rank order limits (RKISP1_CIF_ISP_DPCC_RO_LIMITS_*)\n+ * @rnd_offs: Differential rank offsets for rank neighbor difference (RKISP1_CIF_ISP_DPCC_RND_OFFS_*)\n */\n struct rkisp1_cif_isp_dpcc_config {\n \t__u32 mode;\n", "prefixes": [ "libcamera-devel", "v4", "4/5" ] }