Patch Detail
Show a patch.
GET /api/1.1/patches/16799/?format=api
{ "id": 16799, "url": "https://patchwork.libcamera.org/api/1.1/patches/16799/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16799/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220726143635.518227-5-fsylvestre@baylibre.com>", "date": "2022-07-26T14:36:34", "name": "[libcamera-devel,v3,4/5] include: linux: Update rkisp1 kernel header for DPCC configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cdf093f6c557941c39ebcfaeb31d036236bd45f0", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16799/mbox/", "series": [ { "id": 3328, "url": "https://patchwork.libcamera.org/api/1.1/series/3328/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3328", "date": "2022-07-26T14:36:30", "name": "Add GSL, LSC and DPCC tuning support for rkisp1", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3328/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16799/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16799/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F00DC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Jul 2022 14:36:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 143016331B;\n\tTue, 26 Jul 2022 16:36:50 +0200 (CEST)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3231F60487\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jul 2022 16:36:45 +0200 (CEST)", "by mail-wm1-x334.google.com with SMTP id\n\t8-20020a05600c024800b003a2fe343db1so8293769wmj.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Jul 2022 07:36:45 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:c7b2:2183:8a06:b4dc])\n\tby smtp.gmail.com with ESMTPSA id\n\tm184-20020a1c26c1000000b003a04722d745sm22447386wmm.23.2022.07.26.07.36.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Jul 2022 07:36:43 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658846210;\n\tbh=cq44WZNq0MH9EY9MPKJqmMxgjVTz9+P5Weyej4POxxs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=P8x/oMB7rXgcVvqn2kPWT7J9oHHqlPxNz9a43a5jcPu5Ha/UBDQKAtdP/N2GgCHgg\n\t7Q/RWq67qhF4OaA20iIEh2fwTMhx7YgPf1Naj0fmBuk3gr04edesw66FDcilkPoQaH\n\tmZ9v6+dkam3hXxU7pCMq/U1GMvL4V5Wzsm1+7/Y5k14Z7p2+lMublRl5lKM4m565Ee\n\tIx9WFUIYWUL0lUPbKRzfIRxOqXlgV4tqg1t9z7V2FTo7sVaujm41eFFu4sGyFBsvIJ\n\tp4MLHjoN9qrfC/rlP6EIWrmIzysntvy3qauQOrCsaMyzH5T9fNflDn28fqBB7seQqT\n\tRnKpoW6EWONWQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=rXYLN3M+VURrLxs1TBEH4lG+n/DsAPURZjYMrvBhEAc=;\n\tb=el4TYKv2tS65bzurpJqwSIMGBgPIZI/iwEwUOP53cl+7Ru4ereEEXPgKNdhSA9DGzj\n\ttZbMyYGm5AVT80pASeF7nEONFxv49e8vuxoxSB3ebWoj0UIGiU1vCej3/s1G9AAfmi2w\n\tYUAnwruSC57GlZY59wEbjFRtP/HMxJnQGRnypYZ5KYYmIv0lWGH7sXeYcBKEUz20XSXd\n\taRNKNYBPFQr+5yZ3Nz0B050rq7H6ax99sIiY47g0GatFxVyzdpLhxwZJJslL0185vdjJ\n\tB1+FWGCvcyY9XRBea57MbkgpEiwbvPstmVnxQACGdcYGfK6bxF3ZryaJrtEf+zhibonC\n\tpf4g==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"el4TYKv2\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=rXYLN3M+VURrLxs1TBEH4lG+n/DsAPURZjYMrvBhEAc=;\n\tb=sw5ySLNhGpNR7ajTVmrt+Td3/sHsySymLoTPSLHsnkRv4/oGMgfrijxSDpT1UVt+r3\n\tF/3MoFGPTC3H7v8bnqmjhFhB0bw9G8bJ1xgOps2qBfzKgsk3UnMCvuqjlF3ZJ1oiaFth\n\tew5O2YiiQg3TJA8GvYsCtUOtk5VvtaXwqJZETRoQjbUWQyFnQwJm2KggGQhTU6fv0aNA\n\tY28luF0t2lLX6gQpCDiUD9QaFVzADSFkPChhjp8m+jsEXNUBZKS230K1HWarnE1jFnZw\n\tjt1sutmOLghDeIrTUt3Daa7mD0Sm2qvAalTp8PzRgFyqUFH1h/t2dbGeUoDJWaBmQ4hd\n\t3w8w==", "X-Gm-Message-State": "AJIora8WP0D6GpQ9Yiuv0A/YsqQXLRTwcf5JcwafRqcrit6ync+ylab1\n\tfzHc7RS4eGmBt0p56rxN+ypaiO5AyEJy0aDA", "X-Google-Smtp-Source": "AGRyM1uwlGc7FtK367qjVHlduJLfvmIkBu7pvLAay6uSwMKS86wCu5UIU8grwEUIh4b/k8JpPBbODg==", "X-Received": "by 2002:a1c:19c3:0:b0:39c:6479:3ca with SMTP id\n\t186-20020a1c19c3000000b0039c647903camr24538001wmz.27.1658846204307; \n\tTue, 26 Jul 2022 07:36:44 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Jul 2022 16:36:34 +0200", "Message-Id": "<20220726143635.518227-5-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220726143635.518227-1-fsylvestre@baylibre.com>", "References": "<20220726143635.518227-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 4/5] include: linux: Update rkisp1\n\tkernel header for DPCC configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To improve the kernel interface, a proposal has been made to the\nlinux-kernel [1] to improve the configuration of the Defective\nPixel Cluster Correction (DPCC).\n\n[1]\nhttps://lore.kernel.org/linux-media/20220616160456.21549-1-laurent.pinchart@ideasonboard.com/\n\nUpdate the local copy of the rkisp1-config.h to match the proposal.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nAcked-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/linux/rkisp1-config.h | 77 +++++++++++++++++++++++++++--------\n 1 file changed, 61 insertions(+), 16 deletions(-)", "diff": "diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h\nindex 9be67d63..0ed3dca8 100644\n--- a/include/linux/rkisp1-config.h\n+++ b/include/linux/rkisp1-config.h\n@@ -117,7 +117,46 @@\n /*\n * Defect Pixel Cluster Correction\n */\n-#define RKISP1_CIF_ISP_DPCC_METHODS_MAX 3\n+#define RKISP1_CIF_ISP_DPCC_METHODS_MAX\t\t\t\t3\n+\n+#define RKISP1_CIF_ISP_DPCC_MODE_STAGE1_ENABLE\t\t\t(1U << 2)\n+\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_G_CENTER\t(1U << 0)\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_INCL_RB_CENTER\t(1U << 1)\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_G_3X3\t\t(1U << 2)\n+#define RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_STAGE1_RB_3X3\t\t(1U << 3)\n+\n+/* 0-2 for sets 1-3 */\n+#define RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_SET(n)\t\t((n) << 0)\n+#define RKISP1_CIF_ISP_DPCC_SET_USE_STAGE1_USE_FIX_SET\t\t(1U << 3)\n+\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_PG_GREEN_ENABLE\t\t(1U << 0)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_LC_GREEN_ENABLE\t\t(1U << 1)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RO_GREEN_ENABLE\t\t(1U << 2)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RND_GREEN_ENABLE\t(1U << 3)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RG_GREEN_ENABLE\t\t(1U << 4)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_PG_RED_BLUE_ENABLE\t(1U << 8)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_LC_RED_BLUE_ENABLE\t(1U << 9)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RO_RED_BLUE_ENABLE\t(1U << 10)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RND_RED_BLUE_ENABLE\t(1U << 11)\n+#define RKISP1_CIF_ISP_DPCC_METHODS_SET_RG_RED_BLUE_ENABLE\t(1U << 12)\n+\n+#define RKISP1_CIF_ISP_DPCC_LINE_THRESH_G(v)\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_LINE_THRESH_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_G(v)\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_PG_FAC_G(v)\t\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_PG_FAC_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_RND_THRESH_G(v)\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_RND_THRESH_RB(v)\t\t\t((v) << 8)\n+#define RKISP1_CIF_ISP_DPCC_RG_FAC_G(v)\t\t\t\t((v) << 0)\n+#define RKISP1_CIF_ISP_DPCC_RG_FAC_RB(v)\t\t\t((v) << 8)\n+\n+#define RKISP1_CIF_ISP_DPCC_RO_LIMITS_n_G(n, v)\t\t\t((v) << ((n) * 4))\n+#define RKISP1_CIF_ISP_DPCC_RO_LIMITS_n_RB(n, v)\t\t((v) << ((n) * 4 + 2))\n+\n+#define RKISP1_CIF_ISP_DPCC_RND_OFFS_n_G(n, v)\t\t\t((v) << ((n) * 4))\n+#define RKISP1_CIF_ISP_DPCC_RND_OFFS_n_RB(n, v)\t\t\t((v) << ((n) * 4 + 2))\n \n /*\n * Denoising pre filter\n@@ -250,16 +289,20 @@ struct rkisp1_cif_isp_bls_config {\n };\n \n /**\n- * struct rkisp1_cif_isp_dpcc_methods_config - Methods Configuration used by DPCC\n+ * struct rkisp1_cif_isp_dpcc_methods_config - DPCC methods set configuration\n *\n- * Methods Configuration used by Defect Pixel Cluster Correction\n+ * This structure stores the configuration of one set of methods for the DPCC\n+ * algorithm. Multiple methods can be selected in each set (independently for\n+ * the Green and Red/Blue components) through the @method field, the result is\n+ * the logical AND of all enabled methods. The remaining fields set thresholds\n+ * and factors for each method.\n *\n- * @method: Method enable bits\n- * @line_thresh: Line threshold\n- * @line_mad_fac: Line MAD factor\n- * @pg_fac: Peak gradient factor\n- * @rnd_thresh: Rank Neighbor Difference threshold\n- * @rg_fac: Rank gradient factor\n+ * @method: Method enable bits (RKISP1_CIF_ISP_DPCC_METHODS_SET_*)\n+ * @line_thresh: Line threshold (RKISP1_CIF_ISP_DPCC_LINE_THRESH_*)\n+ * @line_mad_fac: Line Mean Absolute Difference factor (RKISP1_CIF_ISP_DPCC_LINE_MAD_FAC_*)\n+ * @pg_fac: Peak gradient factor (RKISP1_CIF_ISP_DPCC_PG_FAC_*)\n+ * @rnd_thresh: Rank Neighbor Difference threshold (RKISP1_CIF_ISP_DPCC_RND_THRESH_*)\n+ * @rg_fac: Rank gradient factor (RKISP1_CIF_ISP_DPCC_RG_FAC_*)\n */\n struct rkisp1_cif_isp_dpcc_methods_config {\n \t__u32 method;\n@@ -273,14 +316,16 @@ struct rkisp1_cif_isp_dpcc_methods_config {\n /**\n * struct rkisp1_cif_isp_dpcc_config - Configuration used by DPCC\n *\n- * Configuration used by Defect Pixel Cluster Correction\n+ * Configuration used by Defect Pixel Cluster Correction. Three sets of methods\n+ * can be configured and selected through the @set_use field. The result is the\n+ * logical OR of all enabled sets.\n *\n- * @mode: dpcc output mode\n- * @output_mode: whether use hard coded methods\n- * @set_use: stage1 methods set\n- * @methods: methods config\n- * @ro_limits: rank order limits\n- * @rnd_offs: differential rank offsets for rank neighbor difference\n+ * @mode: DPCC mode (RKISP1_CIF_ISP_DPCC_MODE_*)\n+ * @output_mode: Interpolation output mode (RKISP1_CIF_ISP_DPCC_OUTPUT_MODE_*)\n+ * @set_use: Methods sets selection (RKISP1_CIF_ISP_DPCC_SET_USE_*)\n+ * @methods: Methods sets configuration\n+ * @ro_limits: Rank order limits (RKISP1_CIF_ISP_DPCC_RO_LIMITS_*)\n+ * @rnd_offs: Differential rank offsets for rank neighbor difference (RKISP1_CIF_ISP_DPCC_RND_OFFS_*)\n */\n struct rkisp1_cif_isp_dpcc_config {\n \t__u32 mode;\n", "prefixes": [ "libcamera-devel", "v3", "4/5" ] }