Patch Detail
Show a patch.
GET /api/1.1/patches/16746/?format=api
{ "id": 16746, "url": "https://patchwork.libcamera.org/api/1.1/patches/16746/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16746/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220723095330.43542-8-jacopo@jmondi.org>", "date": "2022-07-23T09:53:29", "name": "[libcamera-devel,v2,7/8] libcamera: formats: Map V4L2_PIX_FMT_JPEG to formats::MJPEG", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "855e6cb2f0a6a06af378c75ba5927c1c7f3d6a84", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16746/mbox/", "series": [ { "id": 3320, "url": "https://patchwork.libcamera.org/api/1.1/series/3320/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3320", "date": "2022-07-23T09:53:22", "name": "libcamera: Map multiple V4L2 formats to a single libcamera::format", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3320/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16746/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16746/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1E0ABE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 23 Jul 2022 09:54:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B363F63313;\n\tSat, 23 Jul 2022 11:54:19 +0200 (CEST)", "from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D81C26330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Jul 2022 11:54:18 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id F3DDB1BF207;\n\tSat, 23 Jul 2022 09:54:15 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658570059;\n\tbh=LjB52t49HIdA+C3UCIW3Kz6qybxJwlduNjpfr85aPvw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FWFRVZ/aQo0p0WDRa4LbLK5ey43jtfkbX9RGTPZvpqwYkreK9zZCnxfRNENRyMGvM\n\tNBJtUWWVMloVewK+1GRpNa6YnOfJqielH2tZanFWv0sBdf0C46eHdezv7hhuT91gqy\n\tGcfV5dI7eo+Y/FyFFENpklgY2oCavubwASq8VIpi+hlQY7A0JQku9XsdvmF+HOC7+2\n\tFFWrx2JcKR54i6SnrEovycQBXYJ5ZpPNW4SXRzJ9tsMQNiK4HuDt5A1VhP4pBci4Fm\n\t/DHUmqficd4p4d620EaYYWjRRHDor/FMKVcqOXKtEjersJz0G80b9vpvUkfLunFjKt\n\tBg93Cs7WvR0Dg==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 23 Jul 2022 11:53:29 +0200", "Message-Id": "<20220723095330.43542-8-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20220723095330.43542-1-jacopo@jmondi.org>", "References": "<20220723095330.43542-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 7/8] libcamera: formats: Map\n\tV4L2_PIX_FMT_JPEG to formats::MJPEG", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Cc": "jozef@mlich.cz, Pavel Machek <pavel@ucw.cz>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The V4L2_PIX_FMT_JPEG and V4L2_PIX_FMT_MJPEG formats are under-specified\nand are used interchangeably by kernel drivers.\n\nMap both of them to formats::MJPEG and use the newly re-introduced\nV4L2VideoDevice::toV4L2PixelFormat() to map to the one actually used by\nthe video device.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/formats.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 86fc698a0f4e..564ccc1b5a62 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -948,7 +948,10 @@ const std::map<PixelFormat, PixelFormatInfo> pixelFormatInfo{\n \t\t.name = \"MJPEG\",\n \t\t.format = formats::MJPEG,\n \t\t.v4l2Formats = {\n-\t\t\t.single = { V4L2PixelFormat(V4L2_PIX_FMT_MJPEG) },\n+\t\t\t.single = {\n+\t\t\t\t\tV4L2PixelFormat(V4L2_PIX_FMT_MJPEG),\n+\t\t\t\t\tV4L2PixelFormat(V4L2_PIX_FMT_JPEG),\n+\t\t\t},\n \t\t\t.multi = { V4L2PixelFormat() },\n \t\t},\n \t\t.bitsPerPixel = 0,\n", "prefixes": [ "libcamera-devel", "v2", "7/8" ] }