Patch Detail
Show a patch.
GET /api/1.1/patches/16714/?format=api
{ "id": 16714, "url": "https://patchwork.libcamera.org/api/1.1/patches/16714/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16714/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>", "date": "2022-07-21T12:13:00", "name": "[libcamera-devel,RFC,02/12] libcamera: pipeline: uvcvideo: Report control errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0734db6d78452a2264006c28087a36aeff52e06f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16714/mbox/", "series": [ { "id": 3313, "url": "https://patchwork.libcamera.org/api/1.1/series/3313/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3313", "date": "2022-07-21T12:12:58", "name": "libcamera: Align IPU3 and RKISP1 interfaces", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3313/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16714/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16714/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29ADCBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 21 Jul 2022 12:13:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D0436331F;\n\tThu, 21 Jul 2022 14:13:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DA826330E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Jul 2022 14:13:14 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDB44A38;\n\tThu, 21 Jul 2022 14:13:13 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658405599;\n\tbh=IGBbScQGZcbTQmRMFjagqowF/O41SSAC2/ooNjSvQ8s=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ipieflcWKf22sWHughbEW0fjqI5QsUXAXUBfqn92LkrNjJvVQ+FTq9WAYQi3pDMWs\n\tcXAkcIGFduO2xluLQ61nnSdclLxQD4vFXrQzi9aN6zxUrsN2ERFI9bAxA7RXTqpnVr\n\tuVK1R8sKGqJavfs1moMoKpkGg0CWQ8XOoIu3oy1InKGpWEJTPqbFUZD6+TGIkpvhmH\n\tfb4+mkY8nzqUTqItEHcqeBSNPAsFPr4Uz/m8ABsNpM6BTBEsnqYMRJVf9w+wjJqlDa\n\tlHuRyObpzcWtXwThrCmiusGy9H1tiCFomR7v2rj85XpwgYh4VNCvPlXB20rIEf+FEP\n\tCIBqZo9lwAaqw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658405593;\n\tbh=IGBbScQGZcbTQmRMFjagqowF/O41SSAC2/ooNjSvQ8s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=A67ADneJ7E7I51SRRW22et8m0Kg3eptavGa1kNovPE9xrWSjEA85HdwPKcwx1D9bW\n\toG98SsN/kiNcYCJnwiqBa4+LR/7M5ACBk5lI+478km0tET15It8nax2OeF1RNM/vw8\n\tdkN8G6Nbximsr7OnSToUgjbzpbLwRG1ZBrSzkV4g=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"A67ADneJ\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 21 Jul 2022 13:13:00 +0100", "Message-Id": "<20220721121310.1286862-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "References": "<20220721121310.1286862-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 02/12] libcamera: pipeline: uvcvideo:\n\tReport control errors", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report an error when failing to process controls, but still allow the\nrequest to process and complete where possible.\n\nThe Request ControlError flag is raised on the request.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=135\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 53b2f23ab029..1f282f26bec3 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -26,6 +26,7 @@\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/request.h\"\n #include \"libcamera/internal/sysfs.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n@@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n \t}\n \n \tint ret = processControls(data, request);\n-\tif (ret < 0)\n-\t\treturn ret;\n+\tif (ret < 0) {\n+\t\tLOG(UVC, Error) << \"Failed to process controls\";\n+\t\trequest->_d()->setErrorFlags(Request::ControlError);\n+\t}\n \n \tret = data->video_->queueBuffer(buffer);\n \tif (ret < 0)\n", "prefixes": [ "libcamera-devel", "RFC", "02/12" ] }