Patch Detail
Show a patch.
GET /api/1.1/patches/1671/?format=api
{ "id": 1671, "url": "https://patchwork.libcamera.org/api/1.1/patches/1671/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1671/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190712085057.9240-1-paul.elder@ideasonboard.com>", "date": "2019-07-12T08:50:57", "name": "[libcamera-devel] libcamera: process: fix error checking", "commit_ref": "bfbc25785fcafb0ed2e14a19d2508238594065d3", "pull_url": null, "state": "accepted", "archived": false, "hash": "d4e6e798a2f4a4f845ea0dcb48991d27c0cd14e3", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1671/mbox/", "series": [ { "id": 423, "url": "https://patchwork.libcamera.org/api/1.1/series/423/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=423", "date": "2019-07-12T08:50:57", "name": "[libcamera-devel] libcamera: process: fix error checking", "version": 1, "mbox": "https://patchwork.libcamera.org/series/423/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1671/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1671/checks/", "tags": {}, "headers": { "Return-Path": "<paul.elder@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7189C6156A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jul 2019 10:51:08 +0200 (CEST)", "from neptunite.amanokami.net (softbank126209254147.bbtec.net\n\t[126.209.254.147])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D113C2B2;\n\tFri, 12 Jul 2019 10:51:06 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562921468;\n\tbh=X3TwngGlrLchRNeHlMXyWIwiKGEUm+ZTb78GHL4CM38=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Go0vw3Q/u4AagZ34Wtd/u9keUVub/GMzs5kYItACcKDjOmXsW0PoN2NBEl6FETcpn\n\tnAxde7eh1zrgFPT/iBWZArYzLuCkANl6uoOO54lTbz3US7SLvNuQt7SzGvJxZ1G1XE\n\ttV+wYIqxEh7heun74DA/fb+68LXbitCywR34gERM=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 12 Jul 2019 17:50:57 +0900", "Message-Id": "<20190712085057.9240-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: process: fix error checking", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 12 Jul 2019 08:51:08 -0000" }, "content": "The return value of a read() call is mistakenly checked for nonzero\nrather than less than zero. Fix this.\n\nFixes: df23ab95f3d7 (\"libcamera: process: fix compilation on Chromium OS\")\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/process.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex aee3373..6c41da2 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -87,7 +87,8 @@ void sigact(int signal, siginfo_t *info, void *ucontext)\n void ProcessManager::sighandler(EventNotifier *notifier)\n {\n \tchar data;\n-\tif (read(pipe_[0], &data, sizeof(data))) {\n+\tssize_t ret = read(pipe_[0], &data, sizeof(data));\n+\tif (ret < 0) {\n \t\tLOG(Process, Error)\n \t\t\t<< \"Failed to read byte from signal handler pipe\";\n \t\treturn;\n", "prefixes": [ "libcamera-devel" ] }