Patch Detail
Show a patch.
GET /api/1.1/patches/16704/?format=api
{ "id": 16704, "url": "https://patchwork.libcamera.org/api/1.1/patches/16704/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16704/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220720130740.15300-1-laurent.pinchart@ideasonboard.com>", "date": "2022-07-20T13:07:40", "name": "[libcamera-devel] ipa: rkisp1: Drop unnecessary forward declarations and includes", "commit_ref": "cf66dee4accca7607b6c9d4461060af5275147a9", "pull_url": null, "state": "accepted", "archived": false, "hash": "396be33b2069961d0834baa7f00e4d9184547ad5", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16704/mbox/", "series": [ { "id": 3309, "url": "https://patchwork.libcamera.org/api/1.1/series/3309/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3309", "date": "2022-07-20T13:07:40", "name": "[libcamera-devel] ipa: rkisp1: Drop unnecessary forward declarations and includes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3309/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16704/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16704/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E370BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 20 Jul 2022 13:08:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8337263311;\n\tWed, 20 Jul 2022 15:08:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25235601B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 20 Jul 2022 15:08:18 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 500A16DB;\n\tWed, 20 Jul 2022 15:08:17 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658322499;\n\tbh=SejG5UnOv2IuIsaxU1irfhGtnAyHlhAiEZRAYgV56bk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=PFRlApAjII2kwKdQ290188lLeL1tCXy7iyp86iYdzPz9WgAdUHVKeNg1SE5w0Tlhi\n\tXdH4DWB8xP3Rju/JREa4GijvXqwSsC+4cs9/MvkIDnBTOSCmXgCbgAvKMMmOmIeG1W\n\tBevsG1AS3TUlBwEuiHOis2BnvLztOYb9KeDE3QGn0wtf8ulBW1cj9FeOg2ZDBuciEm\n\tdmZEU2g0DCMGhrOo3BeEDLHnBxTAwPvWVK+9T485rTsKmGpRljK8U5TyKfM5DBuJwc\n\thDW9vZWKvZDpTF6srs/xLU5p9+izKbnQr7lwk6CewFkfTig+7T/0T56SMqOwU3v6c7\n\tBvwv+Noxm2efg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658322497;\n\tbh=SejG5UnOv2IuIsaxU1irfhGtnAyHlhAiEZRAYgV56bk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=WcnaA7ViGIHygnQ+arhzlSR76nEL4Gvg2ZNAncaES8fEKi6JIKkDOMa/uDmHrwclu\n\tHYSeV5n26ALlMVFNtmdDYLoAcVutz6aoNlvCj66X6CJaApIFt/hkCH6iHs9dCgK849\n\tIulD6a/ULyLsKcbubTl0pbMYOaTjZJDCU9VGpWho=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WcnaA7Vi\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 20 Jul 2022 16:07:40 +0300", "Message-Id": "<20220720130740.15300-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] ipa: rkisp1: Drop unnecessary forward\n\tdeclarations and includes", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Forward declarations of IPACameraSensorInfo and inclusion of\nlinux/rkisp1-config.h are not needed in headers that use them only for\narguments to functions defined by the Algorithm base class, as inclusion\nof algorithm.h will bring the necessary declarations for function\narguments. Drop them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.h | 2 --\n src/ipa/rkisp1/algorithms/awb.h | 2 --\n src/ipa/rkisp1/algorithms/blc.h | 4 ----\n 3 files changed, 8 deletions(-)\n\n\nbase-commit: 8b02645845bf404fba83910818b285b652f14f89", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\nindex 22c02779d311..1c9818b7db2a 100644\n--- a/src/ipa/rkisp1/algorithms/agc.h\n+++ b/src/ipa/rkisp1/algorithms/agc.h\n@@ -17,8 +17,6 @@\n \n namespace libcamera {\n \n-struct IPACameraSensorInfo;\n-\n namespace ipa::rkisp1::algorithms {\n \n class Agc : public Algorithm\ndiff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\nindex 7647842f6609..667a8beb7689 100644\n--- a/src/ipa/rkisp1/algorithms/awb.h\n+++ b/src/ipa/rkisp1/algorithms/awb.h\n@@ -7,8 +7,6 @@\n \n #pragma once\n \n-#include <linux/rkisp1-config.h>\n-\n #include \"algorithm.h\"\n \n namespace libcamera {\ndiff --git a/src/ipa/rkisp1/algorithms/blc.h b/src/ipa/rkisp1/algorithms/blc.h\nindex c2649dd7736e..5fc3a80fb638 100644\n--- a/src/ipa/rkisp1/algorithms/blc.h\n+++ b/src/ipa/rkisp1/algorithms/blc.h\n@@ -7,14 +7,10 @@\n \n #pragma once\n \n-#include <linux/rkisp1-config.h>\n-\n #include \"algorithm.h\"\n \n namespace libcamera {\n \n-struct IPACameraSensorInfo;\n-\n namespace ipa::rkisp1::algorithms {\n \n class BlackLevelCorrection : public Algorithm\n", "prefixes": [ "libcamera-devel" ] }