Patch Detail
Show a patch.
GET /api/1.1/patches/16690/?format=api
{ "id": 16690, "url": "https://patchwork.libcamera.org/api/1.1/patches/16690/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16690/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220719122604.20709-1-laurent.pinchart@ideasonboard.com>", "date": "2022-07-19T12:26:04", "name": "[libcamera-devel] simple-cam: Update to the new ControList::get() API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bff215cab5cb160c233d6db7082fbd6f8eb60ab8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16690/mbox/", "series": [ { "id": 3301, "url": "https://patchwork.libcamera.org/api/1.1/series/3301/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3301", "date": "2022-07-19T12:26:04", "name": "[libcamera-devel] simple-cam: Update to the new ControList::get() API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3301/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16690/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16690/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33DBCBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jul 2022 12:26:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A366363312;\n\tTue, 19 Jul 2022 14:26:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DD1A603F4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jul 2022 14:26:42 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91B466EE;\n\tTue, 19 Jul 2022 14:26:41 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658233603;\n\tbh=Sct2NOXcleZIay+bPcicpJH51w1vAjY4meaZjk7glfY=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=iilQF6VwkNlfMedPXiWwgPJUmG7etEo1si8eRTRVChat/H6TTHgCaQmuxVlRTseG7\n\tji7cRwv7xf8lx3yvCR6DbTzBTToOJlFhXo4xYqFM0YrSReGSchPTdbd8OcL4ZmSPWb\n\t+IABACoYrK4Kzjz3ImSNX8M9fD7PbboBqsfW4mCFUzSROl3G4W3KG0aK9TF53WkL2O\n\tDOHg+NqN3y+cXGLI15YJp1D+BNn9LARj0JcQFoCBiSuDiZeG1zu7/JBKVdLkfA84ju\n\t0iLf/vRdIoNpJzEIZEqv9DTPsm7mFmam5T7JtpTPqDhDRV8lLNWTpStGyFc3KCjD7G\n\tgSGutTST4iQww==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658233601;\n\tbh=Sct2NOXcleZIay+bPcicpJH51w1vAjY4meaZjk7glfY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=oCVAKu8n5f+5Xoe5lWlBSMSFY16oW7Z92/LJPdpYq8gEHmXTnG1HqCFEtljmYauM6\n\tHq7dZRXG5FforFIK2YId/MB6oCYYxLvyzmpTCANIDDF55dEPXsx6c0e0Px9Cf+ydOR\n\tYvX9Y9/L1M7KkPHpH7CD3hwnIUzWs8cDC3iUp10I=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oCVAKu8n\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 19 Jul 2022 15:26:04 +0300", "Message-Id": "<20220719122604.20709-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] simple-cam: Update to the new\n\tControList::get() API", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The ControlList::get() function has changed and now returns a\nstd::optional<T>. Adapt simple-cam accordingly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n simple-cam.cpp | 28 ++++++++++++++++------------\n 1 file changed, 16 insertions(+), 12 deletions(-)\n\n\nbase-commit: bb97f3bbd96a9d347e1b7f6cb68d94efaf8db574", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 4de1b7de9ced..3e17839d17e6 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -133,18 +133,22 @@ std::string cameraName(Camera *camera)\n \tconst ControlList &props = camera->properties();\n \tstd::string name;\n \n-\tswitch (props.get(properties::Location)) {\n-\tcase properties::CameraLocationFront:\n-\t\tname = \"Internal front camera\";\n-\t\tbreak;\n-\tcase properties::CameraLocationBack:\n-\t\tname = \"Internal back camera\";\n-\t\tbreak;\n-\tcase properties::CameraLocationExternal:\n-\t\tname = \"External camera\";\n-\t\tif (props.contains(properties::Model))\n-\t\t\tname += \" '\" + props.get(properties::Model) + \"'\";\n-\t\tbreak;\n+\tconst auto &location = props.get(properties::Location);\n+\tif (location) {\n+\t\tswitch (*location) {\n+\t\tcase properties::CameraLocationFront:\n+\t\t\tname = \"Internal front camera\";\n+\t\t\tbreak;\n+\t\tcase properties::CameraLocationBack:\n+\t\t\tname = \"Internal back camera\";\n+\t\t\tbreak;\n+\t\tcase properties::CameraLocationExternal:\n+\t\t\tname = \"External camera\";\n+\t\t\tconst auto &model = props.get(properties::Model);\n+\t\t\tif (model)\n+\t\t\t\tname = \" '\" + *model + \"'\";\n+\t\t\tbreak;\n+\t\t}\n \t}\n \n \tname += \" (\" + camera->id() + \")\";\n", "prefixes": [ "libcamera-devel" ] }