Patch Detail
Show a patch.
GET /api/1.1/patches/16686/?format=api
{ "id": 16686, "url": "https://patchwork.libcamera.org/api/1.1/patches/16686/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16686/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220719103144.3686313-3-kieran.bingham@ideasonboard.com>", "date": "2022-07-19T10:31:44", "name": "[libcamera-devel,2/2] libcamera: pipeline: uvcvideo: Report control errors", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0734db6d78452a2264006c28087a36aeff52e06f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16686/mbox/", "series": [ { "id": 3299, "url": "https://patchwork.libcamera.org/api/1.1/series/3299/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3299", "date": "2022-07-19T10:31:42", "name": "request: Support non fatal errors", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3299/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16686/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16686/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB731BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jul 2022 10:31:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8904463317;\n\tTue, 19 Jul 2022 12:31:52 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B523660489\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jul 2022 12:31:48 +0200 (CEST)", "from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D8BA8B1;\n\tTue, 19 Jul 2022 12:31:48 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658226712;\n\tbh=IGBbScQGZcbTQmRMFjagqowF/O41SSAC2/ooNjSvQ8s=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=MMh1Yj8Odsf3KqiM02oXW91LSOQwVmCgtE3p/6zqcKaqjAPP2HSyEfcu8XvJx3SPq\n\tjlitQhyiP2N5cYFfWb2HejKww74WS9LR/casyNsej4WJZibJs1wxysxuZWjgngauwH\n\t4u/Ej9skqZOMPWmXTvlZ4YYSh+sq7crESXPjuVe+/QPc+bpaUDU8C67dWnG32XZuhJ\n\tNZFUKxLD+zplR1kexo4gmZ9lqaM3sCZFaq6dtzX44j3GkAllpNzKLcsr6CYKT6DRPS\n\tqO7dHPT8z8fGIVgIvDBw3ZRWsG8vxgsB4w+kwnrhc9cURA8F/SObh4qAVvjfbBm0QD\n\tiNkqV6mDUSIbQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658226708;\n\tbh=IGBbScQGZcbTQmRMFjagqowF/O41SSAC2/ooNjSvQ8s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CaaWYwDtmFq5llvTiwQga6d72o4DuBpxmzcT+kjZNvpCE5IRs32G7F+ot7g+tcoJj\n\taYrYGAsjCi6WnCslQ3upr+5awB/OkkASJGUOBQigdYYMPKUsotVuZkhmnA6s9xXm/T\n\tayF4gsEyI41RD70Csq8T9jahvlCuHY/5ry/gvavI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CaaWYwDt\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 19 Jul 2022 11:31:44 +0100", "Message-Id": "<20220719103144.3686313-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220719103144.3686313-1-kieran.bingham@ideasonboard.com>", "References": "<20220719103144.3686313-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: pipeline: uvcvideo: Report\n\tcontrol errors", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Report an error when failing to process controls, but still allow the\nrequest to process and complete where possible.\n\nThe Request ControlError flag is raised on the request.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=135\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 53b2f23ab029..1f282f26bec3 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -26,6 +26,7 @@\n #include \"libcamera/internal/device_enumerator.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/request.h\"\n #include \"libcamera/internal/sysfs.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n@@ -373,8 +374,10 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n \t}\n \n \tint ret = processControls(data, request);\n-\tif (ret < 0)\n-\t\treturn ret;\n+\tif (ret < 0) {\n+\t\tLOG(UVC, Error) << \"Failed to process controls\";\n+\t\trequest->_d()->setErrorFlags(Request::ControlError);\n+\t}\n \n \tret = data->video_->queueBuffer(buffer);\n \tif (ret < 0)\n", "prefixes": [ "libcamera-devel", "2/2" ] }