Patch Detail
Show a patch.
GET /api/1.1/patches/16679/?format=api
{ "id": 16679, "url": "https://patchwork.libcamera.org/api/1.1/patches/16679/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16679/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220719074013.846726-2-paul.elder@ideasonboard.com>", "date": "2022-07-19T07:40:13", "name": "[libcamera-devel,v2,2/2] pipeline: rkisp1: Add support for YUV422", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d2ee2326df64d3e8a949adc791a7af99e717db09", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16679/mbox/", "series": [ { "id": 3296, "url": "https://patchwork.libcamera.org/api/1.1/series/3296/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3296", "date": "2022-07-19T07:40:12", "name": "[libcamera-devel,v2,1/2] pipeline: rkisp1: Add output support for YUV420 and YVU420", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3296/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16679/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16679/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7582BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jul 2022 07:40:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C9CA63315;\n\tTue, 19 Jul 2022 09:40:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BCCC6330E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jul 2022 09:40:43 +0200 (CEST)", "from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 330836EE;\n\tTue, 19 Jul 2022 09:40:41 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658216446;\n\tbh=tI42qEgQsveM4r7sKYvuo+HxLAXL8Tf2UyHY5/DmHUQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=osoAvo3JY2jrgR0CMQxx1bAgJFXLXtdO+1zCcaddxX126NMLALdgUq5MGYQUb6uow\n\tL8UZlRGeT1SBITteehXz+MfU4wNBV2TIxKqBXUT6iN4qP2GCpoGpuGtBNPJYfeZam5\n\tkQDhzeU8QB8Bbks1KKgpWOYFVgelZKgpnDESiSKUiyoDKyrdWplnQF/Ubo5O9Z+DUn\n\tF15TJHmbTuMf9290BEJ22KgBvjol3IOI9JcJxkOe+JXSjA96F/SkaKYHHm9pEN+wX2\n\tI1t26h2hGx1I/YtwGmzN1X6SmC0kkaVhS1me7O++8FNbcbLLSLj8nmUREGE9TTyZIg\n\tbujbxkoG5/PMw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658216443;\n\tbh=tI42qEgQsveM4r7sKYvuo+HxLAXL8Tf2UyHY5/DmHUQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hmPmogm4/7pjwKKoDWbKnq57xf/lAquZ158gMa+KiZae1SMQlYDs3qWQtuweLm9wr\n\tBwEEUGYwyETA+9mtY0einLSvlLixXSs7N9ODooBUokOYvdV8lmzPATI95SneM4IeGi\n\tTi0eoXbgyb3TSkaB9wZBaivW4l2Sr76ch0Sl7gpM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hmPmogm4\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 19 Jul 2022 16:40:13 +0900", "Message-Id": "<20220719074013.846726-2-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220719074013.846726-1-paul.elder@ideasonboard.com>", "References": "<20220719074013.846726-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] pipeline: rkisp1: Add support for\n\tYUV422", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "YUV422 is already supported as an output format by the rkisp1 driver.\nAdd them to the pipeline handler to support them in libcamera as well.\n\nYVU422 is also supported by the driver, but there only exists a\nmultiplanar V4L2 format, which libcamera is currently unable to map to\nfrom the libcamera YVU422 format. This will be fixed later.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- remove YVU422\n- reorder formats\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex c070929d..856554b3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -209,7 +209,7 @@ void RkISP1Path::stop()\n namespace {\n constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n-constexpr std::array<PixelFormat, 8> RKISP1_RSZ_MP_FORMATS{\n+constexpr std::array<PixelFormat, 9> RKISP1_RSZ_MP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n@@ -217,13 +217,14 @@ constexpr std::array<PixelFormat, 8> RKISP1_RSZ_MP_FORMATS{\n \tformats::NV12,\n \tformats::YUV420,\n \tformats::YVU420,\n+\tformats::YUV422,\n \tformats::R8,\n \t/* \\todo Add support for RAW formats. */\n };\n \n constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n-constexpr std::array<PixelFormat, 10> RKISP1_RSZ_SP_FORMATS{\n+constexpr std::array<PixelFormat, 11> RKISP1_RSZ_SP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n@@ -231,6 +232,7 @@ constexpr std::array<PixelFormat, 10> RKISP1_RSZ_SP_FORMATS{\n \tformats::NV12,\n \tformats::YUV420,\n \tformats::YVU420,\n+\tformats::YUV422,\n \tformats::R8,\n \tformats::RGB565,\n \tformats::XRGB8888,\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }