Patch Detail
Show a patch.
GET /api/1.1/patches/16678/?format=api
{ "id": 16678, "url": "https://patchwork.libcamera.org/api/1.1/patches/16678/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16678/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220719074013.846726-1-paul.elder@ideasonboard.com>", "date": "2022-07-19T07:40:12", "name": "[libcamera-devel,v2,1/2] pipeline: rkisp1: Add output support for YUV420 and YVU420", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0b067a398e1a6bd89a6e4073af43627573bcf421", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16678/mbox/", "series": [ { "id": 3296, "url": "https://patchwork.libcamera.org/api/1.1/series/3296/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3296", "date": "2022-07-19T07:40:12", "name": "[libcamera-devel,v2,1/2] pipeline: rkisp1: Add output support for YUV420 and YVU420", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3296/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16678/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16678/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A22F2BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 19 Jul 2022 07:40:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D046163313;\n\tTue, 19 Jul 2022 09:40:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFA5C6330D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 19 Jul 2022 09:40:41 +0200 (CEST)", "from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4400C6EE;\n\tTue, 19 Jul 2022 09:40:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658216444;\n\tbh=yj4kFUkhoQxA/sirNocycMR/0UpHkomScMwRmYOlO1g=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=X4cnL0YptbYioSqaTbHDX9xgyLAN2cddhoGQF9jqGUSjsj9EJ/hVAQDpvhPKPuiMG\n\trQ7KUpDXc2N1/nd5XXIUEz/ePB3XfJCxn3spXpDa1mPjV7WmUuz8elMaYerg6VAxRJ\n\tBCifElWiXcdryeHKQ0KK3yAK5RSrTplPxat32qw50Z5zOBfeyz+1/LfiBsAlUeVqly\n\tKADDZIICwgA8qCPZb2lHvSXu8UFGJAY9I2R0COlMtz7inElfBOxYioHNw2KJJQLU/+\n\tkXGBW1cpl/yZW4iGrrwwPJLXG0z1Qbzuzm3/hQViXrwrptRfjNyRg4ys1EM4Ycma9V\n\tJQ/8g5MHjNSrQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658216441;\n\tbh=yj4kFUkhoQxA/sirNocycMR/0UpHkomScMwRmYOlO1g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=qISv40c96CyKg8De6t77UpodgK9tPSceQo2wiNU0B6SwMqcvga75dcVKkjr21UZ6y\n\t0fh4Po6EOMF26Ga3XIHsveirrN8WXB0US5gvyDeE32qckA0cgD+aCFFxC8LD2I3Fh6\n\tFYncKRfrOpc3MtMYCH7JYKm8mV55leh7KYxTYQD8=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qISv40c9\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 19 Jul 2022 16:40:12 +0900", "Message-Id": "<20220719074013.846726-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/2] pipeline: rkisp1: Add output\n\tsupport for YUV420 and YVU420", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "YUV420 and YVU420 are already supported as output formats by the rkisp1\ndriver. Add them to the pipeline handler to support them in libcamera as\nwell.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v2:\n- move to after NV formats\n- add to self path too\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 6f175758..c070929d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -130,6 +130,8 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n \tswitch (config.pixelFormat) {\n \tcase formats::NV12:\n \tcase formats::NV21:\n+\tcase formats::YUV420:\n+\tcase formats::YVU420:\n \t\tispFormat.mbus_code = MEDIA_BUS_FMT_YUYV8_1_5X8;\n \t\tbreak;\n \tdefault:\n@@ -207,24 +209,28 @@ void RkISP1Path::stop()\n namespace {\n constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n-constexpr std::array<PixelFormat, 6> RKISP1_RSZ_MP_FORMATS{\n+constexpr std::array<PixelFormat, 8> RKISP1_RSZ_MP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n \tformats::NV21,\n \tformats::NV12,\n+\tformats::YUV420,\n+\tformats::YVU420,\n \tformats::R8,\n \t/* \\todo Add support for RAW formats. */\n };\n \n constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n-constexpr std::array<PixelFormat, 8> RKISP1_RSZ_SP_FORMATS{\n+constexpr std::array<PixelFormat, 10> RKISP1_RSZ_SP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n \tformats::NV21,\n \tformats::NV12,\n+\tformats::YUV420,\n+\tformats::YVU420,\n \tformats::R8,\n \tformats::RGB565,\n \tformats::XRGB8888,\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }