Patch Detail
Show a patch.
GET /api/1.1/patches/16665/?format=api
{ "id": 16665, "url": "https://patchwork.libcamera.org/api/1.1/patches/16665/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16665/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220715191400.890976-11-utkarsh02t@gmail.com>", "date": "2022-07-15T19:13:59", "name": "[libcamera-devel,10/11] qcam: ControlFrame: Add GUI way to interact with ControlTypeIntger32", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e6651a72430aacd591aff4c26bc44c07fb0bca3b", "submitter": { "id": 114, "url": "https://patchwork.libcamera.org/api/1.1/people/114/?format=api", "name": "Utkarsh Tiwari", "email": "utkarsh02t@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16665/mbox/", "series": [ { "id": 3292, "url": "https://patchwork.libcamera.org/api/1.1/series/3292/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3292", "date": "2022-07-15T19:13:49", "name": "Introduce control interaction to qcam", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3292/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16665/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16665/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E1D9BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 15 Jul 2022 19:14:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1E9463316;\n\tFri, 15 Jul 2022 21:14:26 +0200 (CEST)", "from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4DB46331B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 21:14:22 +0200 (CEST)", "by mail-pj1-x1029.google.com with SMTP id o15so6466540pjh.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 15 Jul 2022 12:14:22 -0700 (PDT)", "from localhost.localdomain\n\t([2406:3003:2005:1c27:d8e8:f9ac:919c:9ac8])\n\tby smtp.gmail.com with ESMTPSA id\n\ts10-20020a170903214a00b0016be834d544sm3834315ple.237.2022.07.15.12.14.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Jul 2022 12:14:21 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657912466;\n\tbh=M/bGKICe+abowWk3enf/2u14NjFcx2yU0xmzMayWrY0=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=toEPvn2Y2+5rP1MOHWqkrP/LWFplwbYgUwMSG/qeE26Jed0flDeoIrfxyMqHe7rdg\n\t33TiCT0o+Vycg0DUvA6S7i+MGFJf48oZZen31RlchYOgj1pNURxjw0lIxV8BzYYd6U\n\tKbNp5TE8M6cEjhjfhIKpU370fZL1+WsC0QPAqdHlN+q2wRnLE5ZE4zxAMt5xwOEWQI\n\tsgu+MgVCyWqX2DRTv4j36QXvGbDXmA7jAqG5Zr8xpcPLsZYEu12C3szDVjmYXF5YVD\n\twBGWAMIx9PRKCiRaBrCFUMsTkZ+46oTh9X/rS9L3CCaxeobBycBTcJpyRXmT0cDMbd\n\tiLUpTlehTcFtQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=h3ZqblOF9y1/2pt7SDzz4eO84BlwOPFX1e1bby5aPGw=;\n\tb=pmE4IXLF5sRND4BjxT5oqXIZb1+Eb6FpwUTgvSUaoYANXTgIbYAgHwAIErQLsDDLpe\n\tqPi9YS4CeHU7ntVtgckW2HUGQRo7sbIeUSCxA2i8uNwYpZfg0rXLIjHzQ3QrBIF5S+ug\n\tceAvFrZXiF6fBPER/umlPyMZ5djj3Xc/899tD7Xa6C5HaZp9ad4/8h8CsSySEbOJu5a8\n\tcC2fG/8147/KikmsGI61wlpLvV2atSKLwS3L2TLSwqS3xVO6oUHC7tRJU7zqL/mC4ZqM\n\tTiN2ZgT3J4L9kHJX7B4njFnjozjR870Ytp/TX6oKLzr/dTyy5JQkBAXOVTvibIrNAUXB\n\t9BHw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"pmE4IXLF\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=h3ZqblOF9y1/2pt7SDzz4eO84BlwOPFX1e1bby5aPGw=;\n\tb=x6paNRmYoWtT0IYdWXmNV2KAekHAamtu40TpgBcMizXukOPMYNf++ZHtTR7aos7bny\n\tifxKJ1IL2HbrlNg+isBdmHNo1/GdRREFPxy6yHh17Rzgyky+u8dvP/zesg13xdQ6EQP3\n\tEiRp2MWKbzX8LElj7lXMh/a7F3P4kumVGYgw2rIgR0tNenybk9B6b9GtjgmgeqtagTRW\n\tvJMWmNl0Z7uqo3nmFSXLZ7TFgW2vBbQXHHjslGY650lrsMz3Vl/+K78gVqp1Mz8aZcoQ\n\tPeRqdEraeuzYrW+ExFrMPLoqMb4OyPpToHKZ9ygN1ApaagtP9ojhqWDqdtEuaPFXI90f\n\tIqFQ==", "X-Gm-Message-State": "AJIora+g0zm/wY+C9RsViUyH76S3xIimaFmgHkgLbL9kkEmxOijs+kiO\n\twi1IM1o/VuZA3GKWMnkcKtUYdf9A65Pwjw==", "X-Google-Smtp-Source": "AGRyM1ueWhsBaD8haQW6xuvTmLmaEiaXu41tEqdvLi34xkJXMgG5ZpZRZRO0MM519asqpMGXnz4bag==", "X-Received": "by 2002:a17:90b:3008:b0:1ef:86a3:3699 with SMTP id\n\thg8-20020a17090b300800b001ef86a33699mr23900996pjb.240.1657912462072; \n\tFri, 15 Jul 2022 12:14:22 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 16 Jul 2022 03:13:59 +0800", "Message-Id": "<20220715191400.890976-11-utkarsh02t@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220715191400.890976-1-utkarsh02t@gmail.com>", "References": "<20220715191400.890976-1-utkarsh02t@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 10/11] qcam: ControlFrame: Add GUI way to\n\tinteract with ControlTypeIntger32", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Utkarsh Tiwari via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Utkarsh Tiwari <utkarsh02t@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add an integer slider for ControlTypeIntger32 control types.\nThe default value on the slider is the default value for the control\nand it may not be the current value for the control.\n\nSigned-off-by: Utkarsh Tiwari <utkarsh02t@gmail.com>\n---\n src/qcam/settings/control_frame.cpp | 16 ++++++++++++++++\n src/qcam/settings/control_frame.h | 1 +\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/src/qcam/settings/control_frame.cpp b/src/qcam/settings/control_frame.cpp\nindex 10dcd05a..5a3258d6 100644\n--- a/src/qcam/settings/control_frame.cpp\n+++ b/src/qcam/settings/control_frame.cpp\n@@ -94,6 +94,19 @@ QWidget *ControlFrame::controlInteraction(QWidget *parent)\n \t\tSliderLayout *fSliderLayout = new SliderLayout(floatSlider_, this);\n \t\treturn fSliderLayout;\n \t}\n+\tcase ControlTypeInteger32: {\n+\t\tintSlider_ = new Slider(this);\n+\t\tintSlider_->setRange(controlInfo_.min().get<int32_t>(),\n+\t\t\t\t controlInfo_.max().get<int32_t>());\n+\t\tintSlider_->setValue(controlInfo_.def().get<int32_t>());\n+\t\tintSlider_->setOrientation(Qt::Orientation::Horizontal);\n+\n+\t\tconnect(intSlider_, &Slider::valueChanged,\n+\t\t\tthis, &ControlFrame::notifyControlChange);\n+\n+\t\tSliderLayout *iSliderLayout = new SliderLayout(intSlider_, this);\n+\t\treturn iSliderLayout;\n+\t}\n \tdefault:\n \t\treturn (new QLabel(\"Currently Unavailable\"));\n \t}\n@@ -163,6 +176,9 @@ void ControlFrame::notifyControlChange()\n \tcase ControlTypeFloat:\n \t\tcontrolValue.set<float>(floatSlider_->value());\n \t\tbreak;\n+\tcase ControlTypeInteger32:\n+\t\tcontrolValue.set<int32_t>(intSlider_->value());\n+\t\tbreak;\n \tdefault:\n \t\t/* Nothing to emit so return */\n \t\treturn;\ndiff --git a/src/qcam/settings/control_frame.h b/src/qcam/settings/control_frame.h\nindex e9e256aa..205bb96b 100644\n--- a/src/qcam/settings/control_frame.h\n+++ b/src/qcam/settings/control_frame.h\n@@ -47,6 +47,7 @@ private:\n \tQCheckBox *controlCheckBox_;\n \tQLabel *currentValue_;\n \tFloatSlider *floatSlider_;\n+\tSlider *intSlider_;\n \n \t/* Helper Hunctions */\n \tQString getDefaultValueQStr();\n", "prefixes": [ "libcamera-devel", "10/11" ] }