Patch Detail
Show a patch.
GET /api/1.1/patches/16609/?format=api
{ "id": 16609, "url": "https://patchwork.libcamera.org/api/1.1/patches/16609/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16609/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220713084317.24268-12-dse@thaumatec.com>", "date": "2022-07-13T08:43:17", "name": "[libcamera-devel,v2,11/11] ipa: rkisp1: af: Skip one frame after changing the AF window", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ca95fab37603e5a073c8bd5ff2631d22087ec21d", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/1.1/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16609/mbox/", "series": [ { "id": 3276, "url": "https://patchwork.libcamera.org/api/1.1/series/3276/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3276", "date": "2022-07-13T08:43:06", "name": "ipa: rkisp1: Add autofocus algorithm", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3276/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16609/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16609/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19948BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 13 Jul 2022 08:43:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA3436332B;\n\tWed, 13 Jul 2022 10:43:52 +0200 (CEST)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D1016332E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Jul 2022 10:43:50 +0200 (CEST)", "by mail-wr1-x42a.google.com with SMTP id bu1so13291701wrb.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 13 Jul 2022 01:43:50 -0700 (PDT)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tbg32-20020a05600c3ca000b003a04d19dab3sm5667468wmb.3.2022.07.13.01.43.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Jul 2022 01:43:49 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657701832;\n\tbh=fCrgdVHmSEufnXYcQdlMT2beO53VjtE+VMlao3J77LU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=UEumBT40URmKujjTk4dg9ymaBXXIsdvnX2/J3awqaBv9lqV2AoEAvKNnsb0fQQNgv\n\tllNAEGYom1jnkOYcaEVzyO0aXIj5T5NDpr+cEmAItcm4Y0FWl3bQHrCzcCPxyK9Vp/\n\t6tzYynueEmGC8VL0aQGm5Hr4K4/BKN11GEPcz+IIkW1Nn3J0hbU/ji8c3p9VMOkSIx\n\t+vq3tpc54ZcufDdawJTCVPiYbqagTsfRznFfJ6mAZJgRMQ+ejeWkcN0Dc7fbIWtu8I\n\t/QsB9ttcWTIVdT9QiONpKn/DQ54DHsN1lwPkST5ZUUnHJQAMSS6IBnwL1GLK4CK3me\n\t4gIUsO/PUIesw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=d8/XWnx8OcFXS7ZpNMum4EPOd2lP94RlC727NCfsgp4=;\n\tb=ww7JBy5eKajwK1Wy+lPJ0/gdc5YpNsDcmYpQsiZYn5Llhco+sbEjRGkvb/x/SN4Zek\n\tIwZBq9jYkjmhoeyM8sVR4Jbo9dhi5TOqZF1/uR1v26dQT7yPnXj3mLRDcZ6B0Wk30RBd\n\t1xnbLQTGzD4qAlzccwZim/L+SZ6R4Ck9QacILU1XZhIWROFBYWFnylKQsolwxydJYGCc\n\tjhwTj+cOV8TevydQ/cmEWfMPGbtqwd0WdGavqoaUsT2BHdYZQZ3mVXkpPol5liyqjlil\n\tuOdGenkhKM1m2QzGqWOA2fczwqrfOMeFnNuJ50bkS6jihwW38bqj9ygk1GfAX775EFa+\n\tFqjA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"ww7JBy5e\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=d8/XWnx8OcFXS7ZpNMum4EPOd2lP94RlC727NCfsgp4=;\n\tb=Y48LibCk3c5ipYv8O8cxB6/1H0sRppupBeELLYmVSfCryMM/A891Pw4kpvB5kyaYe4\n\tjE8O06G2WOi5ZofkdXXpWp5OVKPeIpHXne3l9DZkMocwfX6nXZWz4JdFe4VsJ7xL1jxk\n\tmkCNKBOkOPpNdDBDcvKi1a1Oo+qdotuA1D8xZ6u309J8nvQ+u0mAJX8Y3KD+mPoae9zC\n\tf9JU/n7kbvrGDJa+f4zQwHvhu2XKRoK1imt9MVXC9bftF0h3HNiC+BqMWhQTlTKRylmA\n\tvlPvCel6yaa800PlBQYqd9Q9qX6CnUxP/dFb4y6fgU26U6tpjLJFvEY2FjRFWgYC3KkJ\n\tnguA==", "X-Gm-Message-State": "AJIora9rnlKbY+hgt8nsnBozWBYBVb8WzNhbRYPI2y9Yfovx2yt9YFSp\n\tJ57RqR45JLiP6c2cp8C6NUbZk5dFgYQW+w==", "X-Google-Smtp-Source": "AGRyM1scGxjVmZsLnv8qklmd5IGXQKpPwJR5krhV+XX8yCXKHUHvXlpmNPB4qxbkmoqPmHMLhk6QGw==", "X-Received": "by 2002:a5d:67c4:0:b0:21d:6d91:7b1a with SMTP id\n\tn4-20020a5d67c4000000b0021d6d917b1amr2060515wrw.313.1657701829882; \n\tWed, 13 Jul 2022 01:43:49 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 13 Jul 2022 10:43:17 +0200", "Message-Id": "<20220713084317.24268-12-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220713084317.24268-1-dse@thaumatec.com>", "References": "<20220713084317.24268-1-dse@thaumatec.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 11/11] ipa: rkisp1: af: Skip one frame\n\tafter changing the AF window", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Drop the first frame after the window change was requested to guarantee\nthat sharpness level was calculated for the new window.\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n src/ipa/rkisp1/algorithms/af.cpp | 1 +\n src/ipa/rkisp1/algorithms/af.h | 1 +\n 2 files changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/af.cpp b/src/ipa/rkisp1/algorithms/af.cpp\nindex a0d914e0..e2769e69 100644\n--- a/src/ipa/rkisp1/algorithms/af.cpp\n+++ b/src/ipa/rkisp1/algorithms/af.cpp\n@@ -128,6 +128,7 @@ void Af::updateCurrentWindow(const Rectangle &window)\n {\n \tcurrentWindow_ = window;\n \tupdateAfwindow_ = true;\n+\tsetFramesToSkip(kWindowWaitFrames);\n }\n \n REGISTER_IPA_ALGORITHM(Af, \"Af\")\ndiff --git a/src/ipa/rkisp1/algorithms/af.h b/src/ipa/rkisp1/algorithms/af.h\nindex 36d0c9b0..b2da4890 100644\n--- a/src/ipa/rkisp1/algorithms/af.h\n+++ b/src/ipa/rkisp1/algorithms/af.h\n@@ -38,6 +38,7 @@ private:\n \tbool updateAfwindow_ = false;\n \n \tstatic constexpr uint32_t kFLensWaitFrames = 2;\n+\tstatic constexpr uint32_t kWindowWaitFrames = 1;\n };\n \n } /* namespace libcamera::ipa::rkisp1::algorithms */\n", "prefixes": [ "libcamera-devel", "v2", "11/11" ] }