Patch Detail
Show a patch.
GET /api/1.1/patches/16575/?format=api
{ "id": 16575, "url": "https://patchwork.libcamera.org/api/1.1/patches/16575/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16575/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220707150310.3645858-5-paul.elder@ideasonboard.com>", "date": "2022-07-07T15:03:10", "name": "[libcamera-devel,RFC,4/4] pipeline: rkisp1: Add support for UYVY", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "fa2325d5c560029806a40cfe7807a4474ba54b27", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16575/mbox/", "series": [ { "id": 3264, "url": "https://patchwork.libcamera.org/api/1.1/series/3264/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3264", "date": "2022-07-07T15:03:06", "name": "Add more formats to rkisp1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3264/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16575/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16575/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BA1D5BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Jul 2022 15:03:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73CA36331F;\n\tThu, 7 Jul 2022 17:03:39 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50A296331B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Jul 2022 17:03:38 +0200 (CEST)", "from pyrite.rasen.tech (softbank036240121080.bbtec.net\n\t[36.240.121.80])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 899766CA;\n\tThu, 7 Jul 2022 17:03:36 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657206219;\n\tbh=wAvMxEfZn8715RVc8QhSgtUfojBsiCXx7C3tPNskzHs=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3qKI79q9005Gt7VVSchAGxZAj6nkV+UYpPdGoUWCQ+FwYmypjwI7GGoRMOViAzBWG\n\tsclCcGr+KTGkflRJiKDolPeHjySkKuJfoVbZUHT6Z+f8GnKKPhUrgq1DmDh0+5OFxi\n\tnpgJpTxho2ab0O48/S0GJ7XV1Tw3B9Xg/z8ysb9SCCzNAEe8O9o3EGiZInxtvSADjI\n\tJa2bIuwqk8dEjggmYJrgSOK7EQ7KFyKHRYzkGYwUZv6jaosnVIs2CamJFdI7isI0OD\n\tnN3FXmUemsgjGdRdqIPZ70JZAX8pd8NOSNaFoALYhDw78aZX8uqvCjTJpoalKQwkKO\n\tWkjIXPH+aPd3w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657206217;\n\tbh=wAvMxEfZn8715RVc8QhSgtUfojBsiCXx7C3tPNskzHs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uUNKU5ivFZCASDrYAvL4evUD0FRbHLajMj85ehNESPtBt+NMJV64LVL0g6Uv8p06O\n\t/Ef3cfqwaSPsOYIRSQf/M2/+fHwK10Va1/b7Rg4IGF+s8OAlwVA294jTqSJye/Ojca\n\t98uTU5dMue/OMpo6KZYqoSNf0GjOSZubNT5AEYfo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uUNKU5iv\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 8 Jul 2022 00:03:10 +0900", "Message-Id": "<20220707150310.3645858-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220707150310.3645858-1-paul.elder@ideasonboard.com>", "References": "<20220707150310.3645858-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 4/4] pipeline: rkisp1: Add support for\n\tUYVY", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Paul Elder <paul.elder@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Support for UYVY will be added soon in the rkisp1 driver. Add it to the\npipeline handler to support it in libcamera as well.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nBesides the fact that support hasn't been merged (or sent yet, for that\nmatter) in the rkisp1 driver, how do we deal with older versions of the\ndriver that won't have UYVY support? Should we enumerate the formats and\ncheck if it's available? Just for UYVY or for all formats?\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 24ff62e1..6b4c4ed5 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -209,8 +209,9 @@ void RkISP1Path::stop()\n namespace {\n constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n-constexpr std::array<PixelFormat, 10> RKISP1_RSZ_MP_FORMATS{\n+constexpr std::array<PixelFormat, 11> RKISP1_RSZ_MP_FORMATS{\n \tformats::YUYV,\n+\tformats::UYVY,\n \tformats::YUV420,\n \tformats::YVU420,\n \tformats::YUV422,\n", "prefixes": [ "libcamera-devel", "RFC", "4/4" ] }