Patch Detail
Show a patch.
GET /api/1.1/patches/16569/?format=api
{ "id": 16569, "url": "https://patchwork.libcamera.org/api/1.1/patches/16569/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16569/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220707094402.28730-4-rishikeshdonadkar@gmail.com>", "date": "2022-07-07T09:44:01", "name": "[libcamera-devel,v2,3/4] gstreamer:Convert between requested colorimetry and libcamera ColorSpace", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b24dae53db856369d95e1f30f773d54c38f7db86", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/1.1/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16569/mbox/", "series": [ { "id": 3263, "url": "https://patchwork.libcamera.org/api/1.1/series/3263/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3263", "date": "2022-07-07T09:43:58", "name": "Add colorimetry support to libcamera gstreamer element.", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3263/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16569/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16569/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FEA5BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Jul 2022 09:45:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C207E6330E;\n\tThu, 7 Jul 2022 11:45:16 +0200 (CEST)", "from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com\n\t[IPv6:2607:f8b0:4864:20::52d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E126C60401\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Jul 2022 11:45:14 +0200 (CEST)", "by mail-pg1-x52d.google.com with SMTP id o18so16312796pgu.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 07 Jul 2022 02:45:14 -0700 (PDT)", "from localhost.localdomain\n\t([2402:8100:30ae:d446:13ee:d079:112a:ac10])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp2-20020a1709027ec200b00168f08d0d12sm24530712plb.89.2022.07.07.02.45.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 07 Jul 2022 02:45:14 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657187116;\n\tbh=sJThdyBfxUyE40DY+r1wMy6yCo4WAYqM4FfbhFrsvLg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iV/TIVJFZaKMWDYNZm2Ot4OLA/r1DN/tP/vzH4OEa1BDkBW+NAc9yoOvu4cH9VHhT\n\tEN1kRLjIXRhc7ki0Em4IXrjeaY6sA5gck7S1nMUmKN17Q2X6CKt2xxjwl5EhjsMFqI\n\tmthwjQR4f7+UfaTv4ZD9vy47Gco1H8hXsrni2Qk7C2g6tnEsc5krRAeoSUV6WENqRZ\n\tmG6YNMHG2prSMhMDSdX2Kan4+U7c4/SnzNUM0yJBRa2+iFBen/hNf/hETJiFTfYmNT\n\tbVBQNViGBIgIm0ozsaRuoHMnJXZFdKAz8G6LtRFeFInaJo1PwpVhdlbIzfWG1H5e/i\n\tmrwBoRDlna+7Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=RW2JF1n1924LYd0TU9ejiNK/gAPHiBkN8cF+tJSgJjE=;\n\tb=eBO7ffzrRdMDyBft4SqZL2HWHi1LR3GVjgmBMM6vCXg4S9FHeneKbSM7yvAuChHDxc\n\trsCRLPjNhXUJQBrorPSC8nfjT402lertejUjOrB4zWhb6kQL0GllXil4my/aILS8uA0G\n\tZDtx7/OiHT+OltjxNyrHS3+ips83YxZlEtRc/yUJf77MyGCbFQyVtaPCo6v//+HZPsVN\n\tR25ifi6uns+GOs52ZYH7hr5HnOpySNGeq1WVmWfbwqt0HjGhDbxaoVhKODK14RyHO4LU\n\tHwHXVdIX61DF6PkNGI9ZyrJeZsVd04vEuwaaD9kMhf+VA0kaLz7hIbegQ/nqkAUgPdQC\n\taYzg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eBO7ffzr\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=RW2JF1n1924LYd0TU9ejiNK/gAPHiBkN8cF+tJSgJjE=;\n\tb=wnFvsMYCZTPdFMD8BSwfuiay5gd6u9aHS4YItPZG4DZmGYyOuUhrZFNivDLx25qyA+\n\tLUCqi8nKdrxp9DwFgL9aam2RwtBu6XzMh2KuYQAs+utsGt6JquXNbrUj9dqLZeVl2jox\n\tQ41mQw1LtBgYhzpYXtHAs79hCy7jTwyX5/UkDiY6CG7ZAFUMBt0iuezgzaFkz9L7VWuA\n\tm0nGXq/UxpvT51Rds1r4nLi8Qe2PZiUf7BwaYWnCFwvTpSFl4zSLx9yRrOeuobp2EVtS\n\tLFFTzpcHnkGJlLEPC8qmQZnV8BAfUa+VNItSfA/J8k4/sHuCvJJW9GvhZA7jqYWTChty\n\tIjeg==", "X-Gm-Message-State": "AJIora/siUAdnIRCH51+tJD+U8vaNrb81pswf4d76JrLvZkPFp9DMXYq\n\toTdu2yd3gC5l4RQMnjPFGMLp8YlL32Y=", "X-Google-Smtp-Source": "AGRyM1sl+CYf88sCazUQugDb4K4qJQjBqRPPOPux1eAJZfpzRXZ8F7wvQicezikrs25WxOvk1CERAA==", "X-Received": "by 2002:a17:90a:710a:b0:1ef:991c:dc67 with SMTP id\n\th10-20020a17090a710a00b001ef991cdc67mr4284919pjk.110.1657187114330; \n\tThu, 07 Jul 2022 02:45:14 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Jul 2022 15:14:01 +0530", "Message-Id": "<20220707094402.28730-4-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220707094402.28730-1-rishikeshdonadkar@gmail.com>", "References": "<20220707094402.28730-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 3/4] gstreamer:Convert between\n\trequested colorimetry and libcamera ColorSpace", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add map colorimetryToColorSpace and the function\ncolorspace_form_colorimetry() to convert from gstreamer colorimetry\nto libcamera colorspace. The obtained colorspace form the conversion\nwill be applied to the colorSpace field of the StreamConfiguration.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex eb9c49da..feefead9 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -51,6 +51,12 @@ static const std::vector<std::pair<ColorSpace, std::string>> ColorSpaceTocolorim\n \t{ ColorSpace::Rec2020, GST_VIDEO_COLORIMETRY_BT2020 },\n };\n \n+static const std::map<std::string, ColorSpace> colorimetryToColorSpace = {\n+\t{ GST_VIDEO_COLORIMETRY_SRGB, ColorSpace::Srgb },\n+\t{ GST_VIDEO_COLORIMETRY_BT709, ColorSpace::Rec709 },\n+\t{ GST_VIDEO_COLORIMETRY_BT2020, ColorSpace::Rec2020 },\n+};\n+\n static GstVideoFormat\n pixel_format_to_gst_format(const PixelFormat &format)\n {\n@@ -119,6 +125,15 @@ colorimerty_from_colorspace(std::optional<ColorSpace> colorSpace)\n \t}\n }\n \n+void colorspace_form_colorimetry(std::optional<ColorSpace> &colorspace, const gchar *colorimetry)\n+{\n+\tauto iterColorSpace = colorimetryToColorSpace.find(colorimetry);\n+\tif (iterColorSpace != colorimetryToColorSpace.end()) {\n+\t\tcolorspace = iterColorSpace->second;\n+\t\treturn;\n+\t}\n+}\n+\n GstCaps *\n gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n {\n", "prefixes": [ "libcamera-devel", "v2", "3/4" ] }