Patch Detail
Show a patch.
GET /api/1.1/patches/16559/?format=api
{ "id": 16559, "url": "https://patchwork.libcamera.org/api/1.1/patches/16559/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16559/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220706091009.2752567-1-kieran.bingham@ideasonboard.com>", "date": "2022-07-06T09:10:09", "name": "[libcamera-devel,v2] qcam: main_window: Fix include ordering", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "02b8b4b5c873f6d01287bfb0ac2bbc135cc0f923", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16559/mbox/", "series": [ { "id": 3259, "url": "https://patchwork.libcamera.org/api/1.1/series/3259/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3259", "date": "2022-07-06T09:10:09", "name": "[libcamera-devel,v2] qcam: main_window: Fix include ordering", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3259/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16559/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16559/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA711BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 6 Jul 2022 09:10:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B384363312;\n\tWed, 6 Jul 2022 11:10:14 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E29736330C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 6 Jul 2022 11:10:13 +0200 (CEST)", "from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A41A593;\n\tWed, 6 Jul 2022 11:10:13 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657098614;\n\tbh=LapQfzCYekt1Edc1PpLJScrSIC9x0jdreo7gUl+rp/I=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=uiDe42u3QucEmRhHx3picI+xf25FTDDvlb1K1yiVccwyeBaUsd2YtRsW7ugyRn9zp\n\tBYVG9nWlDtmjk4CMhoBYbX2WntFbNOPx5yuQaACdXuzX0Bj52yfGTp9aAO4xh13pVW\n\tKqKiX4o900LlL+lAJgxrMD8AYyfszvz7GUetZJ7pRpmagvPEGaAI8Jlg7HldKMCK/s\n\tgm3AJsPbbduVEnNr+v8TFE7vouVAvw6DZTDoSL8u34pExsW8vqVniv10KH4DmF5FM9\n\t3utdP/USTQVexURySJXtg7rNierFR3pc0xqRG7yzBedVqBIjsoKUpdODx79eOMhNBw\n\t/YkrJkMJxjo4A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1657098613;\n\tbh=LapQfzCYekt1Edc1PpLJScrSIC9x0jdreo7gUl+rp/I=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=h1Blt5NuXCmF/5GShx+LyP++a7vBDODUZOTNNO5xyIl9R2T9NckDu2q9gcPsltA+Z\n\thSkJOLLi/bwSwhAKARo3yF2ZEIq0qL1m4GaqVyX5fjtTiUUFohAO9BgVPBAc8DAEDV\n\tuEdbUX6DffKT4Nq5G5niVo13ObaJMDGsxJrCJX74=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"h1Blt5Nu\"; dkim-atps=neutral", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 6 Jul 2022 10:10:09 +0100", "Message-Id": "<20220706091009.2752567-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2] qcam: main_window: Fix include ordering", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix the sort order of the Qt headers to match the expected\nsort from clang-format.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv2:\n - Update .cpp file as well\n\n src/qcam/main_window.cpp | 1 +\n src/qcam/main_window.h | 17 +++++++++--------\n 2 files changed, 10 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex dd0e51f55b70..7433d647e8a0 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -29,6 +29,7 @@\n #include <QtDebug>\n \n #include \"../cam/image.h\"\n+\n #include \"dng_writer.h\"\n #ifndef QT_NO_OPENGL\n #include \"viewfinder_gl.h\"\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 3fbe872c0b5b..fc70920f990c 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -10,14 +10,6 @@\n #include <memory>\n #include <vector>\n \n-#include <QElapsedTimer>\n-#include <QIcon>\n-#include <QMainWindow>\n-#include <QMutex>\n-#include <QObject>\n-#include <QQueue>\n-#include <QTimer>\n-\n #include <libcamera/camera.h>\n #include <libcamera/camera_manager.h>\n #include <libcamera/controls.h>\n@@ -26,7 +18,16 @@\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n+#include <QElapsedTimer>\n+#include <QIcon>\n+#include <QMainWindow>\n+#include <QMutex>\n+#include <QObject>\n+#include <QQueue>\n+#include <QTimer>\n+\n #include \"../cam/stream_options.h\"\n+\n #include \"viewfinder.h\"\n \n class QAction;\n", "prefixes": [ "libcamera-devel", "v2" ] }