Patch Detail
Show a patch.
GET /api/1.1/patches/16552/?format=api
{ "id": 16552, "url": "https://patchwork.libcamera.org/api/1.1/patches/16552/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16552/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220705184350.31369-1-jacopo@jmondi.org>", "date": "2022-07-05T18:43:50", "name": "[libcamera-devel] test: delayed_controls: Remove sequenceOffset", "commit_ref": "2778c3298ca421e2ec670c10d8bab7beaa78f5e9", "pull_url": null, "state": "accepted", "archived": false, "hash": "fea188aa284beabf26d78d3f11fe7c69be2ba3eb", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16552/mbox/", "series": [ { "id": 3256, "url": "https://patchwork.libcamera.org/api/1.1/series/3256/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3256", "date": "2022-07-05T18:43:50", "name": "[libcamera-devel] test: delayed_controls: Remove sequenceOffset", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3256/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16552/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16552/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FF53BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Jul 2022 18:44:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B45E63310;\n\tTue, 5 Jul 2022 20:44:36 +0200 (CEST)", "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88FC561FB0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Jul 2022 20:44:34 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id C7FB520007;\n\tTue, 5 Jul 2022 18:44:33 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1657046676;\n\tbh=5swoiqBMTQia3hxBC6qWJ1ZJ9OqOyUePFLCvLinNH3E=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=QY/RRH9G0IXgg7ulsLE0LVbc6liy2L3GXSm8Yc6ajrDBlsCYj4bOoDiydkHItIP71\n\teneyySVTGQhpGtY/wQ+pTcZ7TPOeti1Ufi0twJFA+5KGK1IyAnsi/o+R2sN3bfXJJE\n\t9vcXOEX1e1W4decCGiYOwnTKhHswX52LLSwz/xp6nRsU3NpgFpNRJQz3vPCM0bjB9L\n\tryJnz9R6XbbWiXAdf0zz6amXBBh++55jCeDGsiZxLIkyVqld6pNaIqjXFa3uKhTkGn\n\tOiVbcc3rBwp92Dumo+PGF62XXyNUFkhvO2/C1DeQUbB1zrpLSjc654mEKLDDTVW9vN\n\tWnW8U3Vf3SkMA==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Jul 2022 20:43:50 +0200", "Message-Id": "<20220705184350.31369-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.36.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] test: delayed_controls: Remove\n\tsequenceOffset", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Commit 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\nremoved support for frame number start offset from the DelayedControls\nclass, as it is now guaranteed that the first sequence number as it comes\nfrom the V4L2VideoDevice will always be 0.\n\nHowever the delayed_controls.cpp unit still has two tests that passes\na non-zero first sequence number to the DelayedControl class, causing\nthe test to spin forever and consequentially fail.\n\nRemove the two tests from the unit to fix this.\n\nThe first removed test was testing the class against frame start\nsequence numbers greater than zero and can safely be removed.\n\nThe second test was instead validating the class against sequence number\noverflow, which is now not possible to test anymore as the DelayedControls\nclass now assumes 0 as first frame sequence number.\n\nFixes: 6f539a6d2fa9 (\"delayed_controls: Remove reduandant firstSequence_\")\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n test/delayed_controls.cpp | 23 ++++++-----------------\n 1 file changed, 6 insertions(+), 17 deletions(-)", "diff": "diff --git a/test/delayed_controls.cpp b/test/delayed_controls.cpp\nindex c6f195b7bc7f..a8ce9828d73d 100644\n--- a/test/delayed_controls.cpp\n+++ b/test/delayed_controls.cpp\n@@ -155,7 +155,7 @@ protected:\n \t\treturn TestPass;\n \t}\n \n-\tint dualControlsWithDelay(uint32_t startOffset)\n+\tint dualControlsWithDelay()\n \t{\n \t\tstatic const unsigned int maxDelay = 2;\n \n@@ -175,25 +175,24 @@ protected:\n \t\tdelayed->reset();\n \n \t\t/* Trigger the first frame start event */\n-\t\tdelayed->applyControls(startOffset);\n+\t\tdelayed->applyControls(0);\n \n \t\t/* Test dual control with delay. */\n \t\tfor (unsigned int i = 1; i < 100; i++) {\n-\t\t\tuint32_t frame = startOffset + i;\n \t\t\tint32_t value = 10 + i;\n \n \t\t\tctrls.set(V4L2_CID_BRIGHTNESS, value);\n \t\t\tctrls.set(V4L2_CID_CONTRAST, value + 1);\n \t\t\tdelayed->push(ctrls);\n \n-\t\t\tdelayed->applyControls(frame);\n+\t\t\tdelayed->applyControls(i);\n \n-\t\t\tControlList result = delayed->get(frame);\n+\t\t\tControlList result = delayed->get(i);\n \t\t\tint32_t brightness = result.get(V4L2_CID_BRIGHTNESS).get<int32_t>();\n \t\t\tint32_t contrast = result.get(V4L2_CID_CONTRAST).get<int32_t>();\n \t\t\tif (brightness != expected || contrast != expected + 1) {\n \t\t\t\tcerr << \"Failed dual controls\"\n-\t\t\t\t << \" frame \" << frame\n+\t\t\t\t << \" frame \" << i\n \t\t\t\t << \" brightness \" << brightness\n \t\t\t\t << \" contrast \" << contrast\n \t\t\t\t << \" expected \" << expected\n@@ -283,17 +282,7 @@ protected:\n \t\t\treturn ret;\n \n \t\t/* Test dual controls with different delays. */\n-\t\tret = dualControlsWithDelay(0);\n-\t\tif (ret)\n-\t\t\treturn ret;\n-\n-\t\t/* Test dual controls with non-zero sequence start. */\n-\t\tret = dualControlsWithDelay(10000);\n-\t\tif (ret)\n-\t\t\treturn ret;\n-\n-\t\t/* Test dual controls with sequence number wraparound. */\n-\t\tret = dualControlsWithDelay(UINT32_MAX - 50);\n+\t\tret = dualControlsWithDelay();\n \t\tif (ret)\n \t\t\treturn ret;\n \n", "prefixes": [ "libcamera-devel" ] }