Patch Detail
Show a patch.
GET /api/1.1/patches/16533/?format=api
{ "id": 16533, "url": "https://patchwork.libcamera.org/api/1.1/patches/16533/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16533/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220704152318.221213-4-fsylvestre@baylibre.com>", "date": "2022-07-04T15:23:17", "name": "[libcamera-devel,3/4] ipa: rkisp1: Add support of Demosaicing control", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3abd03ce0c96e98eefc495d19a5969a5ce1fec4d", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16533/mbox/", "series": [ { "id": 3247, "url": "https://patchwork.libcamera.org/api/1.1/series/3247/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3247", "date": "2022-07-04T15:23:14", "name": "Add Demosaicing and Color Processing control for rkisp1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3247/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16533/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16533/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 821E9BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 4 Jul 2022 15:23:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 340BC65658;\n\tMon, 4 Jul 2022 17:23:28 +0200 (CEST)", "from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BC4F6564A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 4 Jul 2022 17:23:26 +0200 (CEST)", "by mail-wr1-x42d.google.com with SMTP id k7so13928242wrc.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 04 Jul 2022 08:23:26 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:ca4a:68b5:560f:5682])\n\tby smtp.gmail.com with ESMTPSA id\n\tp15-20020a05600c204f00b0039c5cecf206sm19603199wmg.4.2022.07.04.08.23.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 04 Jul 2022 08:23:24 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656948208;\n\tbh=iXL+jHJnilrNPSpBrMwT2ff6nImvQJ84SN4WCPAgZqo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=L0Fg1eWaaJm7eYbESJ9jgWXa5FRv2puLerCzR9awaCp6TTvBSUwITtHbwxkUhUVIc\n\tntroXFYibVzHz3l4lpCi85XbXEJgBO5291Xl8htXY/VYL0/Y1mCrD5+ufOP939vNUc\n\tgahSEOWH9JDap8WxeOdYTYkME4XJpplCna2ZrAfFugPP17uacYeUKGQMDxgyInF0NZ\n\tmYxKf+cviUjOb67sd2Hdec4SBUal0AVJ2VQFMz4bwDQzERsSyNC5o6xb8vKSmcvmqy\n\tblZ+3zvfpLhF7050zIcbss1T1aqMjt8MkPeHc5nx/KhKIVGcesmEy6pPpMQ8N6GT0a\n\tYNVHKwQnDIKjw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=CDoBwHVa9kSCalHII9c48Kh0yJn7kLuxldxFCHrqLsk=;\n\tb=4bt4nhVLLB2dtLfzW7lWUl/MjabsXVhLwp4dI8RS1i8GzfBDTOu6VQq+lmDOQJaEs3\n\tzyVFAlKhFm8Cm9WJNj/9h+qtcrbRGz97TeRMWYRNjUjH+pT2CC/iaGc1DiwE9Gt5ivyf\n\tN99pXAGADY+qi8eJV9xNSZEv2lRoLVRIzXiDrBWUCBSTmoghPKMhwdmmSdUwBCcTobGB\n\tFhTJEfQWb2fqyOxnwZ7iiH6WDFfXLRQ1KmyuIEhLnXQgvdwYGLFC+S/JHGYTusj7F9Vk\n\tjPjm/P139C1oCapomWqi/d7k+rYwMvARDOUBX7m35cajn5yoJKe1im7RffleMJxFcVCy\n\tXKuA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"4bt4nhVL\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=CDoBwHVa9kSCalHII9c48Kh0yJn7kLuxldxFCHrqLsk=;\n\tb=T9/j3LZj5uPhH09Ga+QGruEYYBKYbdLV+vtGE04KCpDasdu2PYw020lXqTE5ldmyW5\n\tTR+X2IAl+9s6dyHdJJp2zAq0SQsX+QiMBxpDsSv5AnDWMHZjQjSQ8/lW7EObgRvGFgT8\n\t9pxO5fK5nSlVayS20ISLGcAlgXVIAb9wGIjY+L27V/VW6sTjtfqayZy0BkJznQreOHyN\n\tam6sDqQhmFs8Xq+Vn1wzAuzCDeLuNajI/Ds6qClORNU6k7xblTotlMkYHoRITvK0SX1i\n\teRNl8Gu77ScRGLux2qTPTB6Gm4lRmIeraMw4bayj5cMchw4V32dt+rHnYsh3baqgnxUX\n\te0MQ==", "X-Gm-Message-State": "AJIora+EuXs9uwQo87n+8fWYWSVdSnIODRlAYImeItXdqsmXAW4BNfvA\n\t7t9ieDhA8joN/Lmibp0xN8mEJ7OnogcXWA==", "X-Google-Smtp-Source": "AGRyM1vzpqDwQ/0bDwyjtnLesjrtZoPr6z8ylLUqD+WWAz4pdMw8u8CfB2tGnXUP+t5GKbvBblpsfA==", "X-Received": "by 2002:a5d:6da3:0:b0:21b:aaf5:b814 with SMTP id\n\tu3-20020a5d6da3000000b0021baaf5b814mr27176867wrs.140.1656948205424; \n\tMon, 04 Jul 2022 08:23:25 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 4 Jul 2022 17:23:17 +0200", "Message-Id": "<20220704152318.221213-4-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220704152318.221213-1-fsylvestre@baylibre.com>", "References": "<20220704152318.221213-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/4] ipa: rkisp1: Add support of\n\tDemosaicing control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "During the demosaicing step, rkisp1 ISP is processing denoising and sharpness\ncontrol.\nAdd demosaicing algorithm with denoise and sharpness values based on user\ncontrols.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\n---\n src/ipa/rkisp1/algorithms/demosaicing.cpp | 208 ++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/demosaicing.h | 37 ++++\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/data/ov5640.yaml | 1 +\n src/ipa/rkisp1/rkisp1.cpp | 1 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +\n 6 files changed, 256 insertions(+)\n create mode 100644 src/ipa/rkisp1/algorithms/demosaicing.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/demosaicing.h", "diff": "diff --git a/src/ipa/rkisp1/algorithms/demosaicing.cpp b/src/ipa/rkisp1/algorithms/demosaicing.cpp\nnew file mode 100644\nindex 00000000..2597735e\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/demosaicing.cpp\n@@ -0,0 +1,208 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021-2022, Ideas On Board\n+ *\n+ * lsc.cpp - RkISP1 Defect Pixel Cluster Correction control\n+ */\n+\n+#include \"demosaicing.h\"\n+\n+#include <libcamera/base/log.h>\n+\n+#include <libcamera/control_ids.h>\n+\n+#include \"libcamera/internal/yaml_parser.h\"\n+\n+/**\n+ * \\file demosaicing.h\n+ */\n+\n+#define ISP_FILT_LUM_WEIGHT_DEFAULT 0x00022040\n+#define ISP_FILT_MODE_DEFAULT 0x000004f2\n+\n+/* Default values : should be updated with automatic control implementation. */\n+#define SHARPNESS_DEFAULT 2\n+#define DENOISE_DEFAULT 2\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+/**\n+ * \\class Demosaicing\n+ * \\brief RkISP1 Demosaicing control\n+ *\n+ * The Demosaicing algorithm is responsible to reconstruct a full color image\n+ * from the sensor raw data. During the demosaicing step, rkisp1 ISP is\n+ * processing denoising and sharpness control.\n+ *\n+ * /todo In current version the denoise and sharpness control is based on user\n+ * controls. In a future version it should be controlled automatically by the\n+ * algorithm.\n+ */\n+\n+LOG_DEFINE_CATEGORY(RkISP1Demosaicing)\n+\n+Demosaicing::Demosaicing()\n+\t: userSharpness_(SHARPNESS_DEFAULT), userDenoise_(DENOISE_DEFAULT),\n+\t updateUserControls_(true)\n+{\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::queueRequest\n+ */\n+void Demosaicing::queueRequest([[maybe_unused]] IPAContext &context,\n+\t\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t\t const ControlList &controls)\n+{\n+\tfor (auto const &ctrl : controls) {\n+\t\tif (ctrl.first == controls::SHARPNESS) {\n+\t\t\tuserSharpness_ = ctrl.second.get<float>();\n+\t\t\tupdateUserControls_ = true;\n+\n+\t\t\tLOG(RkISP1Demosaicing, Debug)\n+\t\t\t\t<< \"Set sharpness to: \"\n+\t\t\t\t<< int(userSharpness_);\n+\t\t} else if (ctrl.first == controls::NOISE_REDUCTION_MODE) {\n+\t\t\tint32_t denoiseControl = ctrl.second.get<int32_t>();\n+\n+\t\t\tswitch (denoiseControl) {\n+\t\t\tcase controls::draft::NoiseReductionModeOff:\n+\t\t\t\tuserDenoise_ = 0;\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::NoiseReductionModeMinimal:\n+\t\t\t\tuserDenoise_ = 1;\n+\t\t\t\tbreak;\n+\t\t\tcase controls::draft::NoiseReductionModeHighQuality:\n+\t\t\tcase controls::draft::NoiseReductionModeFast:\n+\t\t\t\tuserDenoise_ = 3;\n+\t\t\t\tbreak;\n+\t\t\tdefault:\n+\t\t\t\tLOG(RkISP1Demosaicing, Error)\n+\t\t\t\t\t<< \"Unsupported denoise value: \"\n+\t\t\t\t\t<< int(denoiseControl);\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\n+\t\t\tupdateUserControls_ = true;\n+\n+\t\t\tLOG(RkISP1Demosaicing, Debug)\n+\t\t\t\t<< \"Set denoise to: \"\n+\t\t\t\t<< int(userDenoise_);\n+\t\t}\n+\t}\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::prepare\n+ */\n+void Demosaicing::prepare([[maybe_unused]] IPAContext &context,\n+\t\t\t rkisp1_params_cfg *params)\n+{\n+\t/* Check if the algorithm configuration has been updated. */\n+\tif (!updateUserControls_)\n+\t\treturn;\n+\n+\tupdateUserControls_ = false;\n+\n+\tstatic constexpr uint16_t filt_fac_sh0[] = {\n+\t\t0x04, 0x07, 0x0A, 0x0C, 0x10, 0x14, 0x1A, 0x1E, 0x24, 0x2A, 0x30\n+\t};\n+\n+\tstatic constexpr uint16_t filt_fac_sh1[] = {\n+\t\t0x04, 0x08, 0x0C, 0x10, 0x16, 0x1B, 0x20, 0x26, 0x2C, 0x30, 0x3F\n+\t};\n+\n+\tstatic constexpr uint16_t filt_fac_mid[] = {\n+\t\t0x04, 0x06, 0x08, 0x0A, 0x0C, 0x10, 0x13, 0x17, 0x1D, 0x22, 0x28\n+\t};\n+\n+\tstatic constexpr uint16_t filt_fac_bl0[] = {\n+\t\t0x02, 0x02, 0x04, 0x06, 0x08, 0x0A, 0x0C, 0x10, 0x15, 0x1A, 0x24\n+\t};\n+\n+\tstatic constexpr uint16_t filt_fac_bl1[] = {\n+\t\t0x00, 0x00, 0x00, 0x02, 0x04, 0x04, 0x06, 0x08, 0x0D, 0x14, 0x20\n+\t};\n+\n+\tstatic constexpr uint16_t filt_thresh_sh0[] = {\n+\t\t0, 18, 26, 36, 41, 75, 90, 120, 170, 250, 1023\n+\t};\n+\n+\tstatic constexpr uint16_t filt_thresh_sh1[] = {\n+\t\t0, 33, 44, 51, 67, 100, 120, 150, 200, 300, 1023\n+\t};\n+\n+\tstatic constexpr uint16_t filt_thresh_bl0[] = {\n+\t\t0, 8, 13, 23, 26, 50, 60, 80, 140, 180, 1023\n+\t};\n+\n+\tstatic constexpr uint16_t filt_thresh_bl1[] = {\n+\t\t0, 2, 5, 10, 15, 20, 26, 51, 100, 150, 1023\n+\t};\n+\n+\tstatic constexpr uint16_t stage1_select[] = {\n+\t\t6, 6, 4, 4, 3, 3, 2, 2, 2, 2, 2\n+\t};\n+\n+\tstatic constexpr uint16_t filt_chr_v_mode[] = {\n+\t\t1, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3\n+\t};\n+\n+\tstatic constexpr uint16_t filt_chr_h_mode[] = {\n+\t\t0, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3\n+\t};\n+\n+\tparams->others.flt_config.fac_sh0 = filt_fac_sh0[userSharpness_];\n+\tparams->others.flt_config.fac_sh1 = filt_fac_sh1[userSharpness_];\n+\tparams->others.flt_config.fac_mid = filt_fac_mid[userSharpness_];\n+\tparams->others.flt_config.fac_bl0 = filt_fac_bl0[userSharpness_];\n+\tparams->others.flt_config.fac_bl1 = filt_fac_bl1[userSharpness_];\n+\n+\tparams->others.flt_config.lum_weight = ISP_FILT_LUM_WEIGHT_DEFAULT;\n+\tparams->others.flt_config.mode = ISP_FILT_MODE_DEFAULT;\n+\tparams->others.flt_config.thresh_sh0 = filt_thresh_sh0[userDenoise_];\n+\tparams->others.flt_config.thresh_sh1 = filt_thresh_sh1[userDenoise_];\n+\tparams->others.flt_config.thresh_bl0 = filt_thresh_bl0[userDenoise_];\n+\tparams->others.flt_config.thresh_bl1 = filt_thresh_bl1[userDenoise_];\n+\tparams->others.flt_config.grn_stage1 = stage1_select[userDenoise_];\n+\tparams->others.flt_config.chr_v_mode = filt_chr_v_mode[userDenoise_];\n+\tparams->others.flt_config.chr_h_mode = filt_chr_h_mode[userDenoise_];\n+\n+\tif (userDenoise_ == 9) {\n+\t\tif (userSharpness_ > 3)\n+\t\t\tparams->others.flt_config.grn_stage1 = 2;\n+\t\telse\n+\t\t\tparams->others.flt_config.grn_stage1 = 1;\n+\t} else if (userDenoise_ == 10) {\n+\t\tif (userSharpness_ > 5)\n+\t\t\tparams->others.flt_config.grn_stage1 = 2;\n+\t\telse if (userSharpness_ > 3)\n+\t\t\tparams->others.flt_config.grn_stage1 = 1;\n+\t\telse\n+\t\t\tparams->others.flt_config.grn_stage1 = 0;\n+\t} else if (userDenoise_ > 7) {\n+\t\tif (userSharpness_ > 7) {\n+\t\t\tparams->others.flt_config.fac_bl0 =\n+\t\t\t\tparams->others.flt_config.fac_bl0 / 2;\n+\t\t\tparams->others.flt_config.fac_bl1 =\n+\t\t\t\tparams->others.flt_config.fac_bl1 / 4;\n+\t\t} else if (userSharpness_ > 4) {\n+\t\t\tparams->others.flt_config.fac_bl0 =\n+\t\t\t\tparams->others.flt_config.fac_bl0 * 3 / 4;\n+\t\t\tparams->others.flt_config.fac_bl1 =\n+\t\t\t\tparams->others.flt_config.fac_bl1 / 2;\n+\t\t}\n+\t}\n+\n+\tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_FLT;\n+\tparams->module_ens |= RKISP1_CIF_ISP_MODULE_FLT;\n+\tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_FLT;\n+}\n+\n+REGISTER_IPA_ALGORITHM(Demosaicing, \"Demosaicing\")\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/demosaicing.h b/src/ipa/rkisp1/algorithms/demosaicing.h\nnew file mode 100644\nindex 00000000..6d05b0e4\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/demosaicing.h\n@@ -0,0 +1,37 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021-2022, Ideas On Board\n+ *\n+ * dpcc.h - RkISP1 Demosaicing control\n+ */\n+\n+#pragma once\n+\n+#include <sys/types.h>\n+#include <linux/rkisp1-config.h>\n+\n+#include \"algorithm.h\"\n+\n+namespace libcamera {\n+\n+struct IPACameraSensorInfo;\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+class Demosaicing : public Algorithm\n+{\n+public:\n+\tDemosaicing();\n+\t~Demosaicing() = default;\n+\n+\tvoid queueRequest(IPAContext &context, const uint32_t frame,\n+\t\t\t const ControlList &controls) override;\n+\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n+private:\n+\tuint32_t userSharpness_;\n+\tuint32_t userDenoise_;\n+\tbool updateUserControls_;\n+};\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\nindex 87007493..7e078b0d 100644\n--- a/src/ipa/rkisp1/algorithms/meson.build\n+++ b/src/ipa/rkisp1/algorithms/meson.build\n@@ -4,6 +4,7 @@ rkisp1_ipa_algorithms = files([\n 'agc.cpp',\n 'awb.cpp',\n 'blc.cpp',\n+ 'demosaicing.cpp',\n 'dpcc.cpp',\n 'gsl.cpp',\n 'lsc.cpp',\ndiff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\nindex 51228218..4ae0ffc0 100644\n--- a/src/ipa/rkisp1/data/ov5640.yaml\n+++ b/src/ipa/rkisp1/data/ov5640.yaml\n@@ -157,4 +157,5 @@ algorithms:\n rnd-offsets:\n green: 2\n red-blue: 2\n+ - Demosaicing:\n ...\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 9b0d675c..85a75070 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -31,6 +31,7 @@\n #include \"algorithms/algorithm.h\"\n #include \"algorithms/awb.h\"\n #include \"algorithms/blc.h\"\n+#include \"algorithms/demosaicing.h\"\n #include \"algorithms/dpcc.h\"\n #include \"algorithms/gsl.h\"\n #include \"algorithms/lsc.h\"\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 72689c88..3d0075ee 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -953,6 +953,14 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \t\tstd::make_unique<RkISP1CameraData>(this, &mainPath_, &selfPath_);\n \n \tControlInfoMap::Map ctrls;\n+\tctrls.emplace(std::piecewise_construct,\n+\t\t std::forward_as_tuple(&controls::Sharpness),\n+\t\t std::forward_as_tuple(0.0f, 10.0f, 1.0f));\n+\n+\tctrls.emplace(std::piecewise_construct,\n+\t\t std::forward_as_tuple(&controls::draft::NoiseReductionMode),\n+\t\t std::forward_as_tuple(controls::draft::NoiseReductionModeValues));\n+\n \tctrls.emplace(std::piecewise_construct,\n \t\t std::forward_as_tuple(&controls::AeEnable),\n \t\t std::forward_as_tuple(false, true));\n", "prefixes": [ "libcamera-devel", "3/4" ] }