Patch Detail
Show a patch.
GET /api/1.1/patches/16526/?format=api
{ "id": 16526, "url": "https://patchwork.libcamera.org/api/1.1/patches/16526/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16526/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220703073358.76643-3-rishikeshdonadkar@gmail.com>", "date": "2022-07-03T07:33:56", "name": "[libcamera-devel,v1,3/5] gstreamer:Install the colorimetry property", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "26c96e34171b7302f870963903e3690cdcfe846a", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/1.1/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16526/mbox/", "series": [ { "id": 3245, "url": "https://patchwork.libcamera.org/api/1.1/series/3245/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3245", "date": "2022-07-03T07:33:54", "name": "[libcamera-devel,v1,1/5] gstreamer: Convert form colorspace to colorimetry.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3245/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16526/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16526/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D568BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 3 Jul 2022 07:34:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45CD565650;\n\tSun, 3 Jul 2022 09:34:29 +0200 (CEST)", "from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com\n\t[IPv6:2607:f8b0:4864:20::1033])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4F9E6564A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 3 Jul 2022 09:34:28 +0200 (CEST)", "by mail-pj1-x1033.google.com with SMTP id fz10so390991pjb.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 03 Jul 2022 00:34:28 -0700 (PDT)", "from localhost.localdomain\n\t([2402:8100:30af:f358:3ebf:ad3f:f834:3344])\n\tby smtp.googlemail.com with ESMTPSA id\n\tl11-20020a170903120b00b0016b953872a7sm10300285plh.201.2022.07.03.00.34.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 03 Jul 2022 00:34:26 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656833669;\n\tbh=kCce0/Hrh4NafDou48L6iKh47MxvPkotjv5ywVVuOA4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=j1r3HodhQVE/rCdQI/gxz8ZpoY9Wc9zYnGaj+JsMGr3SRTwLXTek4spAqfg+7CPdC\n\tWLgag9vRNn8v7XQoeAzjTnHjYHp6E/YYJN1E+2Xw1S1NJrcjKfQNCGiLMhX6w1dxW+\n\t18FP8a/CRHVb1QQq/RSB38qnakme8kEnNNfQf4X12GLnfL+ua4mvnixDphWI89TWA3\n\tvCyo8rQEZFSGsib2DUbvJBHx5a9CqIZRo24slSHHiIKlVAQ4aavqJLfUkxNxHZGCyQ\n\ty0hGZkiQeHhNGvkZU3/Q4eJucr3kLCICP/qHM5AGmsTHqceV72ZMjEUraI2s9XxQCk\n\tFdpQk3uJRWb7Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Tb+P9IAJbs/5lWvtGt1UxkTi4iLo+typkPrJkm9ogY4=;\n\tb=o8/RPUxq9T87vvQbLIDkKhQ9N9jB7H0mktF0ziXqHXcmUIQCIZ9yQ0P3WIUE1cj0XT\n\tfEqy5Zh2hJ/n3I/BU4JpIb7sgyxBYOFQ53fhZ+E64oXTfr58sqDys36YJ6sBX+FuEcXL\n\t+Dne9eCpOf9RhT7rYjn/MTk6oVFdS5eRK9rWCNZGYRi5ocW5vxTZmF5cw93WU6Atr/tk\n\trgXyKh85EqKPbs/Z+8SUv1CNBPppPPigHaMOEvfGDjZWmiMsY70aYBHM/BzlNjKZMUIH\n\to+ZaYhUffk0BcbzpV8pcjH5HlebR6PpRa/aMzqwnH/fhxn765Es3rN1rJ97ZczOdcQ1h\n\tUWdg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"o8/RPUxq\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Tb+P9IAJbs/5lWvtGt1UxkTi4iLo+typkPrJkm9ogY4=;\n\tb=ux73wW+V37zlnq5LZXl34/IUpVHeYmHS6GYZJuNAvNutBJHrkdy4P6vzLC3/FTiGpS\n\t4/p+nGCAgrJXOp06dGg01UdaUYkQQx21139dKU6glMnsEe9oqUU4RSWhHfjmhYpw3/b6\n\tbvpwgoQ/hZ7HqCVjb7bxAjAfncHbMY+3Vp6rE+2kQZN4VmlwJczeXbTMCeRdHgQEzXJ7\n\tnLTS9WSeyH+vYboM4cGd+E9GpqAYlbqqRaU3EhJJlLo1UjcKG88Oxy12I5RmFpUFAQw1\n\tkCneuVnREL1y47hFVR6BMf1Gp37Yu5HFlvf6q2oqhsOSuQXWM8OZvg7mk5ZFruCh3LNA\n\t9Pzg==", "X-Gm-Message-State": "AJIora8yFl5rL4VrKbgQf+EQnqNQvxtUkyeQqISM7hj1SwBW8c9P9eEr\n\tSLMZCpRXLyxqEiu/zpfD57ykQHk7QfvX8QB3", "X-Google-Smtp-Source": "AGRyM1ticpmnaKsxqD3pBrUJPEMu8LYV3Z6OtFPc4WDhogPQ8oaxYAW9Wh+ZL5qM/HIySp8m6bywxA==", "X-Received": "by 2002:a17:90b:1bcc:b0:1ed:361b:702a with SMTP id\n\toa12-20020a17090b1bcc00b001ed361b702amr29592910pjb.1.1656833667149; \n\tSun, 03 Jul 2022 00:34:27 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 3 Jul 2022 13:03:56 +0530", "Message-Id": "<20220703073358.76643-3-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "References": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 3/5] gstreamer:Install the colorimetry\n\tproperty", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add the colorimetry field in the _GstLibcameraSrc. Add switch cases in\ngst_libcamera_src_set_property() and gst_libcamera_src_get_property() to\naccess and modify the property.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 18 +++++++++++++++++-\n 1 file changed, 17 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 46fd02d2..120319b3 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -121,6 +121,7 @@ struct _GstLibcameraSrc {\n \tGstTask *task;\n \n \tgchar *camera_name;\n+\tgchar *colorimetry;\n \n \tGstLibcameraSrcState *state;\n \tGstLibcameraAllocator *allocator;\n@@ -129,7 +130,8 @@ struct _GstLibcameraSrc {\n \n enum {\n \tPROP_0,\n-\tPROP_CAMERA_NAME\n+\tPROP_CAMERA_NAME,\n+\tPROP_COLORIMETRY,\n };\n \n G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n@@ -532,6 +534,10 @@ gst_libcamera_src_set_property(GObject *object, guint prop_id,\n \t\tg_free(self->camera_name);\n \t\tself->camera_name = g_value_dup_string(value);\n \t\tbreak;\n+\tcase PROP_COLORIMETRY:\n+\t\tg_free(self->colorimetry);\n+\t\tself->colorimetry = g_value_dup_string(value);\n+\t\tbreak;\n \tdefault:\n \t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n \t\tbreak;\n@@ -549,6 +555,9 @@ gst_libcamera_src_get_property(GObject *object, guint prop_id, GValue *value,\n \tcase PROP_CAMERA_NAME:\n \t\tg_value_set_string(value, self->camera_name);\n \t\tbreak;\n+\tcase PROP_COLORIMETRY:\n+\t\tg_value_set_string(value, self->colorimetry);\n+\t\tbreak;\n \tdefault:\n \t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n \t\tbreak;\n@@ -717,4 +726,11 @@ gst_libcamera_src_class_init(GstLibcameraSrcClass *klass)\n \t\t\t\t\t\t\t | G_PARAM_READWRITE\n \t\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n \tg_object_class_install_property(object_class, PROP_CAMERA_NAME, spec);\n+\n+\tGParamSpec *spec2 = g_param_spec_string(\"colorimetry\", \"Coloirmetry\",\n+\t\t\t\t\t\t\"Colorimetry that will be applied to the StreamConfiguration\", nullptr,\n+\t\t\t\t\t (GParamFlags)(GST_PARAM_MUTABLE_READY\n+\t\t\t\t\t\t\t | G_PARAM_READWRITE\n+\t\t\t\t\t\t\t | G_PARAM_STATIC_STRINGS));\n+\tg_object_class_install_property(object_class,PROP_COLORIMETRY,spec2);\n }\n", "prefixes": [ "libcamera-devel", "v1", "3/5" ] }