Patch Detail
Show a patch.
GET /api/1.1/patches/16525/?format=api
{ "id": 16525, "url": "https://patchwork.libcamera.org/api/1.1/patches/16525/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16525/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220703073358.76643-2-rishikeshdonadkar@gmail.com>", "date": "2022-07-03T07:33:55", "name": "[libcamera-devel,v1,2/5] gstreamer: Update the obtained colorimetry in caps.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "939a1a7b5c31d4218b2efdc542bd8cd5b524a6f8", "submitter": { "id": 118, "url": "https://patchwork.libcamera.org/api/1.1/people/118/?format=api", "name": "Rishikesh Donadkar", "email": "rishikeshdonadkar@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16525/mbox/", "series": [ { "id": 3245, "url": "https://patchwork.libcamera.org/api/1.1/series/3245/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3245", "date": "2022-07-03T07:33:54", "name": "[libcamera-devel,v1,1/5] gstreamer: Convert form colorspace to colorimetry.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3245/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16525/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16525/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CCD3BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 3 Jul 2022 07:34:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CCF706564D;\n\tSun, 3 Jul 2022 09:34:20 +0200 (CEST)", "from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com\n\t[IPv6:2607:f8b0:4864:20::1036])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 850AA6564A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 3 Jul 2022 09:34:19 +0200 (CEST)", "by mail-pj1-x1036.google.com with SMTP id\n\tg16-20020a17090a7d1000b001ea9f820449so10481855pjl.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 03 Jul 2022 00:34:19 -0700 (PDT)", "from localhost.localdomain\n\t([2402:8100:30af:f358:3ebf:ad3f:f834:3344])\n\tby smtp.googlemail.com with ESMTPSA id\n\tl11-20020a170903120b00b0016b953872a7sm10300285plh.201.2022.07.03.00.34.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 03 Jul 2022 00:34:17 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656833660;\n\tbh=HBN0zhzfgevyKBGy8V3w5seZyiIHkcYKXESY1RADJgw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XNoU8eTJgvYqsbLrbeIgaL94xmdLYRO9HkBoxMOC8HVwDQWNu4z1ngcQJdr2tVNLy\n\t8vtX3mlTSMP4mmnJMKQhEfoQRIzYj6Yz4GkKM8XY5fVpvN08y4sllTrTuv16H5cLVN\n\t8OplWEARt7n+TyJQbab3JOpIFKGTlCRjgrjpyO+/UcH+sZ57THLOzee8f+VrIEOqmW\n\tQzWz3B7aMwSgxtkzXwXAaRlu3eyCbOdR86Df7IK5ETrFXwTjwLHE0Gp8Bf+VaGvCXW\n\tEet1nu26qmNRQ9CuRug1adAzP6CcuT0vwoeEaIm42d05/TzISVktFVCfpFhQqhqhTN\n\tRbcFrvGktxaIg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=BVRpnbi43YEWEksgXVhZVaj+0wwRHaTrgC6U8PWM9hQ=;\n\tb=d1fYrcIoHdBUfE2bv32UPUR3bhQtKByakijqFmwF3vghaGFbBs/5TIC+RkLMHriUrc\n\tKE10m4R5xPykFrVD8/YrUbuZS5PwOz07CzMHN1Hxp9BBkSPy3PNMoBoDX8rZbUOh3yJX\n\tj8M38zpn31lWMlw9d/LAJ7AhePGEcf+0/FWJbG96A1Whn9fthCIncEP4CFODemV7trL9\n\tbBxLRzb7bXUcpkPYrldLveD179yyW2W/8y4R3KGJcogHIfyvKEO8QmoezvlPYIXXeUqS\n\tpkw1wVOEYLedP1jwj0HK2J/EauNs1c4gkogY6V9hkBBJcSKZa+6nAnxFSPtOf+AWLIzD\n\tXE6Q==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d1fYrcIo\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=BVRpnbi43YEWEksgXVhZVaj+0wwRHaTrgC6U8PWM9hQ=;\n\tb=B2kvatwpz2P4sWD9ShpUhrx1gPipBxbHAq4WLZue7eShuGQ3bHPagZRRN9P3YJ+CkN\n\tYFgrVJWlqLynKL4JTmBtaKcey8cRKIO1xkJyPyBEUPIGjv5gjR30Bpb6ETshIoKi80dW\n\t1pozEnNzkvyf5AkaGLpiyalqwdBFZX6TVJJYeX5u8Jdg7MgXU588rdEVKcGktUSR4T0R\n\tlNWzo+/zHl0A7CSJlHWaEqztWCDEHwz9w53sQvOPvkbFNwhpz8wSAaQJH7xXbnpWIyDt\n\tCKsS4c/1uptfOjvBiXTnuytDsQ1XtRHc7ELHLJFUd916ZAiNed4qkJLd/r0nBPHZsF3h\n\tvotQ==", "X-Gm-Message-State": "AJIora8j0gQg7+qSLdU/tFgaraqg4QgZEnCmBW8RCTzAXp6heNdUvh6S\n\taYdTXgqNhBAISIUz11t9F6cEqcJaEUDwCwaP", "X-Google-Smtp-Source": "AGRyM1vuACPD+Mt34E+de2Z2oNJsvKPNok2SvvuqJBsUPEhVZcjZWZ/eBc4OBIdoSUyvtvLW70adlw==", "X-Received": "by 2002:a17:90b:3850:b0:1ed:7d1:f0a with SMTP id\n\tnl16-20020a17090b385000b001ed07d10f0amr27903943pjb.67.1656833657952; \n\tSun, 03 Jul 2022 00:34:17 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 3 Jul 2022 13:03:55 +0530", "Message-Id": "<20220703073358.76643-2-rishikeshdonadkar@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "References": "<20220703073358.76643-1-rishikeshdonadkar@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1 2/5] gstreamer: Update the obtained\n\tcolorimetry in caps.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Rishikesh Donadkar via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>", "Cc": "Rishikesh Donadkar <rishikeshdonadkar@gmail.com>,\n\tnicolas.dufresne@collabora.com, vedantparanjape160201@gmail.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Get the colorimetry as a result conversion in the previous patch and\nupdate the colorimetry in the gstreamer caps.\n\nSigned-off-by: Rishikesh Donadkar <rishikeshdonadkar@gmail.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 20c39919..690a9f43 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -205,10 +205,17 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n {\n \tGstCaps *caps = gst_caps_new_empty();\n \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n+\tconst gchar *colorimetry;\n+\tstd::optional<ColorSpace> colorspace = stream_cfg.colorSpace;\n+\tif (colorspace)\n+\t\tcolorimetry = colorimerty_from_colorspace(colorspace);\n+\telse\n+\t\tcolorimetry = g_strdup(\"Unset\");\n \n \tgst_structure_set(s,\n \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n+\t\t\t \"colorimetry\", G_TYPE_STRING, colorimetry,\n \t\t\t nullptr);\n \tgst_caps_append_structure(caps, s);\n \n", "prefixes": [ "libcamera-devel", "v1", "2/5" ] }