Patch Detail
Show a patch.
GET /api/1.1/patches/16463/?format=api
{ "id": 16463, "url": "https://patchwork.libcamera.org/api/1.1/patches/16463/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16463/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630133902.321099-5-jacopo@jmondi.org>", "date": "2022-06-30T13:38:43", "name": "[libcamera-devel,v3,04/23] libcamera: control_serializer: Support internal controls", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "c53c62857cf2f9a8a913eebad8709a6a19a7e269", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16463/mbox/", "series": [ { "id": 3238, "url": "https://patchwork.libcamera.org/api/1.1/series/3238/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3238", "date": "2022-06-30T13:38:39", "name": "Internal controls, sensor delays and IPA rework", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3238/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16463/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16463/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 553FAC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 13:39:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 941A16565E;\n\tThu, 30 Jun 2022 15:39:27 +0200 (CEST)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12AF565653\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 15:39:22 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 4C327240003;\n\tThu, 30 Jun 2022 13:39:21 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656596367;\n\tbh=YRcrjHMXZIwdFvwX6ssq+Ra4PbFZJC596koAMpw3dT8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=AdfxTYI1rQgEAiHf32vDLfhhaz/IKo07wuWyieilKBMMHb0ar78MAAyzsiEnXiwt4\n\tENhfcgrTh90EBjI7KGzZxDrnw6JgpkDP1y7Tsxdy2LhD25qRMISEjlFWyVkdFpsblz\n\tNo2SS78eIp/N1xQZRuyChe+gZ+tuQF3cOgFihMVoPRE/r6fUpfXI1XMKes0Mq2Beys\n\tpDB0EdogBtIFaXqFDp6wLDxM9smlaa7aw9efIXlh5tq5Z/LzFkfLmNDEljWahbg9LP\n\tAedC+7WpnkMDFLjV/s4ZdR+yNdw/R9f7PeHfYb5VLMnnNRh6E8V7VgN7O4MHeadta4\n\tXrzIfuTj22oWw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 15:38:43 +0200", "Message-Id": "<20220630133902.321099-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.36.1", "In-Reply-To": "<20220630133902.321099-1-jacopo@jmondi.org>", "References": "<20220630133902.321099-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 04/23] libcamera: control_serializer:\n\tSupport internal controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The control serializer class uses tags to identify which ControlIdMap\nto use to de-serialize a ControlList.\n\nAdd a value for internal controls to the ipa_controls_id_map_type\nenumeration and use it to identify lists of internal controls.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/ipa/ipa_controls.h | 1 +\n src/libcamera/control_serializer.cpp | 6 ++++++\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/ipa/ipa_controls.h b/include/libcamera/ipa/ipa_controls.h\nindex e5da1946ce1d..609e28197f50 100644\n--- a/include/libcamera/ipa/ipa_controls.h\n+++ b/include/libcamera/ipa/ipa_controls.h\n@@ -20,6 +20,7 @@ extern \"C\" {\n enum ipa_controls_id_map_type {\n \tIPA_CONTROL_ID_MAP_CONTROLS,\n \tIPA_CONTROL_ID_MAP_PROPERTIES,\n+\tIPA_CONTROL_ID_MAP_INTERNAL_CONTROLS,\n \tIPA_CONTROL_ID_MAP_V4L2,\n };\n \ndiff --git a/src/libcamera/control_serializer.cpp b/src/libcamera/control_serializer.cpp\nindex e87d23625ed2..c5b691a981a2 100644\n--- a/src/libcamera/control_serializer.cpp\n+++ b/src/libcamera/control_serializer.cpp\n@@ -21,6 +21,7 @@\n #include <libcamera/ipa/ipa_controls.h>\n \n #include \"libcamera/internal/byte_stream_buffer.h\"\n+#include \"libcamera/internal/control_ids.h\"\n \n /**\n * \\file control_serializer.h\n@@ -335,6 +336,8 @@ int ControlSerializer::serialize(const ControlList &list,\n \t\tidMapType = IPA_CONTROL_ID_MAP_CONTROLS;\n \telse if (idmap == &properties::properties)\n \t\tidMapType = IPA_CONTROL_ID_MAP_PROPERTIES;\n+\telse if (idmap == &controls::internal::controls)\n+\t\tidMapType = IPA_CONTROL_ID_MAP_INTERNAL_CONTROLS;\n \telse\n \t\tidMapType = IPA_CONTROL_ID_MAP_V4L2;\n \n@@ -461,6 +464,9 @@ ControlInfoMap ControlSerializer::deserialize<ControlInfoMap>(ByteStreamBuffer &\n \tcase IPA_CONTROL_ID_MAP_PROPERTIES:\n \t\tidMap = &properties::properties;\n \t\tbreak;\n+\tcase IPA_CONTROL_ID_MAP_INTERNAL_CONTROLS:\n+\t\tidMap = &controls::internal::controls;\n+\t\tbreak;\n \tcase IPA_CONTROL_ID_MAP_V4L2:\n \t\tcontrolIdMaps_.emplace_back(std::make_unique<ControlIdMap>());\n \t\tlocalIdMap = controlIdMaps_.back().get();\n", "prefixes": [ "libcamera-devel", "v3", "04/23" ] }