Patch Detail
Show a patch.
GET /api/1.1/patches/16408/?format=api
{ "id": 16408, "url": "https://patchwork.libcamera.org/api/1.1/patches/16408/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16408/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220629070416.17550-3-tomi.valkeinen@ideasonboard.com>", "date": "2022-06-29T07:04:04", "name": "[libcamera-devel,v2,02/14] py: Add Python logging category", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a168d53203888f3ae1e6caa00697e538aeb1c198", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16408/mbox/", "series": [ { "id": 3230, "url": "https://patchwork.libcamera.org/api/1.1/series/3230/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3230", "date": "2022-06-29T07:04:02", "name": "Python bindings event handling", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3230/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16408/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16408/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01B1EBE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 Jun 2022 07:04:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D615365638;\n\tWed, 29 Jun 2022 09:04:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB07865635\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 Jun 2022 09:04:40 +0200 (CEST)", "from deskari.lan (91-158-154-79.elisa-laajakaista.fi\n\t[91.158.154.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6A5E76F0;\n\tWed, 29 Jun 2022 09:04:40 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656486285;\n\tbh=GApko8Xk7fqa9bcs/6OBQN3OzWVj2WUfL+sa81qKAlw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=JjP6a5mrM8rjl2ANwxFMYt+uAMmJBnyMCwj3v5y7oUUS8tLouUNCto3elFxusO592\n\tYALk9SIjSEiibaf4iy/PTY2whCxilct4wpI8oReBywijyhG+olBMKzLLrrvvzI0FGw\n\tBGDLRG4Tgm7VTPdmSR39V5OmwMWM1Gc1wRTCcx3i6hq4BohOgpeZoSVoejrNHnIH5G\n\tH3s+FkLssgbOT4oZb7vt4nu5fNeStb9bxsR/A2A2TZ0+wKoG4nrPB9V664URrELONL\n\tmTf9IgCslxyQ/J6G5BZsYhyCsWnIREjOjHta7JYVJwAHMTebjMH8sWAOrdmflXp+b3\n\thAkRg2FqkVs8g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656486280;\n\tbh=GApko8Xk7fqa9bcs/6OBQN3OzWVj2WUfL+sa81qKAlw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DGwnBM4RX0woFczNqiqwQwyClG+eC5DO5k4sGrRx/qEjqM1BPpGI2jEMXz51vytZA\n\tjdM7Szwhwjha97wMT0Yr4VoDd0ep+56Fx3oL70B4Kga0+/PzD2UOBNM+DjesrkN20u\n\tmekYO9igeYp1axVw7GY/0C8Hvv4gUr5InXAPL5ts=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DGwnBM4R\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Wed, 29 Jun 2022 10:04:04 +0300", "Message-Id": "<20220629070416.17550-3-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220629070416.17550-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220629070416.17550-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 02/14] py: Add Python logging category", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add Python logging category, and use it in handleRequestCompleted().\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/py/libcamera/py_main.cpp | 12 ++++++++++--\n src/py/libcamera/py_main.h | 14 ++++++++++++++\n 2 files changed, 24 insertions(+), 2 deletions(-)\n create mode 100644 src/py/libcamera/py_main.h", "diff": "diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\nindex 505cc3dc..4b698f77 100644\n--- a/src/py/libcamera/py_main.cpp\n+++ b/src/py/libcamera/py_main.cpp\n@@ -5,6 +5,8 @@\n * Python bindings\n */\n \n+#include \"py_main.h\"\n+\n #include <mutex>\n #include <stdexcept>\n #include <sys/eventfd.h>\n@@ -23,6 +25,12 @@ namespace py = pybind11;\n \n using namespace libcamera;\n \n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(Python)\n+\n+}\n+\n template<typename T>\n static py::object valueOrTuple(const ControlValue &cv)\n {\n@@ -120,10 +128,10 @@ static void handleRequestCompleted(Request *req)\n \tsize_t s = write(gEventfd, &v, 8);\n \t/*\n \t * We should never fail, and have no simple means to manage the error,\n-\t * so let's use LOG(Fatal).\n+\t * so let's log a fatal error.\n \t */\n \tif (s != 8)\n-\t\tLOG(Fatal) << \"Unable to write to eventfd\";\n+\t\tLOG(Python, Fatal) << \"Unable to write to eventfd\";\n }\n \n void init_py_enums(py::module &m);\ndiff --git a/src/py/libcamera/py_main.h b/src/py/libcamera/py_main.h\nnew file mode 100644\nindex 00000000..5bb5f2d1\n--- /dev/null\n+++ b/src/py/libcamera/py_main.h\n@@ -0,0 +1,14 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n+ */\n+\n+#pragma once\n+\n+#include <libcamera/base/log.h>\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Python)\n+\n+}\n", "prefixes": [ "libcamera-devel", "v2", "02/14" ] }