Patch Detail
Show a patch.
GET /api/1.1/patches/16405/?format=api
{ "id": 16405, "url": "https://patchwork.libcamera.org/api/1.1/patches/16405/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16405/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220628191355.78408-1-kunalagarwal1072002@gmail.com>", "date": "2022-06-28T19:13:55", "name": "[libcamera-devel,v2,2/2] qcam: assets: shader: bayer_8.vert: Add precision", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "facdabb20500c2dc582c19a618fe08ff391db7ad", "submitter": { "id": 116, "url": "https://patchwork.libcamera.org/api/1.1/people/116/?format=api", "name": "Kunal Agarwal", "email": "kunalagarwal1072002@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16405/mbox/", "series": [ { "id": 3229, "url": "https://patchwork.libcamera.org/api/1.1/series/3229/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3229", "date": "2022-06-28T19:12:38", "name": "[libcamera-devel,v2,1/2] qcam: assets: shader: bayer_8.frag: Add precision", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3229/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16405/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16405/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DB89BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Jun 2022 19:14:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EEC8665636;\n\tTue, 28 Jun 2022 21:14:07 +0200 (CEST)", "from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com\n\t[IPv6:2607:f8b0:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E2CA6059D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Jun 2022 21:14:06 +0200 (CEST)", "by mail-pf1-x42a.google.com with SMTP id bo5so12871640pfb.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Jun 2022 12:14:06 -0700 (PDT)", "from pop-os.localdomain ([115.96.77.129])\n\tby smtp.googlemail.com with ESMTPSA id\n\tip11-20020a17090b314b00b001ec84b0f199sm3735734pjb.1.2022.06.28.12.14.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 28 Jun 2022 12:14:04 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656443648;\n\tbh=NQgf6qPGjnzxrYD2YPTAErO123NwF9aVgaK7WxAm9d4=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=2AnuI3e9sn36PvEG6RRQznV5cejH/cqCjJDuVG0Fj1rLCW4FNYEza5pP9d4cqp04m\n\tUyk1m5KWZ5HjJGdOSALXwKU/3cD/eWaWpLwQnilGGC5EEAFEhRUepBJRvrQeEXFIMl\n\t/89pWR1EpvbVd110qPDdGrM+6xEu4InoSRu8p4AEkuhx1+O4YDE3UyzsiGGh2xRrnR\n\tBten7qDdBbCXSj8ZL10gjHNrIGcrcv7hvz6KHcPx/odzpq8FcZxFEsbM+9yJyguDW3\n\tgIypTafu7GLv+ElGn1jkOwzri8CkV/ZT+OhQ3Psc51ZmNMgauydiOV+KlNKgvR6V/P\n\t5zAtGfmEL9xVA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=dMIBwlwYowQ0jdgp6EKzWK+jbT4c7WO9v6fcDOzdnX0=;\n\tb=SxithIvt71E0csIyD1ULfButiHFPZlbCxlBdI7zzh0zXPH+4hWJJqyiTghaWWz3rs8\n\tm6TOIy3U4Irt1kWhw53GmMn0KuK3FZyvcWr2QoSw/c1prGlCiIhliYbZcwsZWxnMAhUE\n\tEwEfUASwbHqDD/pY1w5d8Pw+iUaEJkwgygkh/U4DmFi0ds//FxbPlmMzj/2OhNoVCXIo\n\t5E7NsbDPX/ocOmFeHBg73ySIcXqpCTukVShjAUsXcqCq0pXwmQfKLCDdI2v9kS+jub/l\n\tPdg2FFNgDCiow01qomU6TK5atwHWLxiL1QiRdB1yRjubZqHigddIsP4VImuZepSsdckz\n\tyoaw==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SxithIvt\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=dMIBwlwYowQ0jdgp6EKzWK+jbT4c7WO9v6fcDOzdnX0=;\n\tb=wa4BV6btJO5XyC1ZgUkFQC9Qci2PdNhHGN8zZUa876Y5YwwKHPTlqaRL+gu2p0CaNG\n\tFYILNvxnxt9CI9+v7Wnr/RkP+0FrbIjz3As9mUwhy1p88f6ksoEDYqLh2tlsffXsL3sG\n\t895A4Dua6g55SoRz419bQRXNuTjtOMmmPW9t7nYwqtPXm32DuvWsmN+h7407MyHhEqmJ\n\trLzsPTuUEbNIEdJgYnuuQCMq5BPKlXqAG7LKNdh9lwCgpX83610IUAgwaCqgfshg/RRO\n\tUkIu4AcsnvlTJVu3zB1/u+Lsdu7/ewaPUjzwlryZWDJMdElqe8PHGWHXmBYvGWdD0hGE\n\txINg==", "X-Gm-Message-State": "AJIora8iGJhx6/3aoQFq20GEqd3Rtjc+a3CuPnRuVw2dQR1yodt7akD/\n\t/+LlrNqRE4vw2Q/diz/g6ITerytgxnzVEg==", "X-Google-Smtp-Source": "AGRyM1uyw2oPoyvlLVg36ZOxA+AIiNTV/na27UQFuM/ucjxholKvCPFxbkbLHWjTIoCFmA94iAt2Rg==", "X-Received": "by 2002:a65:6c0a:0:b0:3fa:c20c:cbe7 with SMTP id\n\ty10-20020a656c0a000000b003fac20ccbe7mr18957800pgu.611.1656443644859; \n\tTue, 28 Jun 2022 12:14:04 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 29 Jun 2022 00:43:55 +0530", "Message-Id": "<20220628191355.78408-1-kunalagarwal1072002@gmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] qcam: assets: shader:\n\tbayer_8.vert: Add precision", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Kunal Agarwal via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Kunal Agarwal <kunalagarwal1072002@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently there is no defined precision for data types\nwhich results in compilation errors for shader.\n\nAdding precision mediump for sufficient and required\nrange and accuracy. Also suitable for textures.\nPrecision highp also works but is not supported by some\nolder hardware devices and consumes more memory.\n\nSigned-off-by: Kunal Agarwal <kunalagarwal1072002@gmail.com>\n---\n src/qcam/assets/shader/bayer_8.vert | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/qcam/assets/shader/bayer_8.vert b/src/qcam/assets/shader/bayer_8.vert\nindex 3695a5e9..a250bb81 100644\n--- a/src/qcam/assets/shader/bayer_8.vert\n+++ b/src/qcam/assets/shader/bayer_8.vert\n@@ -15,6 +15,9 @@ Copyright (C) 2021, Linaro\n */\n \n //Vertex Shader\n+#ifdef GL_ES\n+precision mediump float;\n+#endif\n \n attribute vec4 vertexIn;\n attribute vec2 textureIn;\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }