Patch Detail
Show a patch.
GET /api/1.1/patches/16369/?format=api
{ "id": 16369, "url": "https://patchwork.libcamera.org/api/1.1/patches/16369/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16369/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220624130523.41535-3-dse@thaumatec.com>", "date": "2022-06-24T13:05:23", "name": "[libcamera-devel,v2,2/2] cam: capture_script: Check parseFrames() return value for errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "58f04f52f2dc77f2d4dd2027f846adf25c97e370", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/1.1/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16369/mbox/", "series": [ { "id": 3218, "url": "https://patchwork.libcamera.org/api/1.1/series/3218/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3218", "date": "2022-06-24T13:05:21", "name": "cam: Add Rectangle type parsing in capture script", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3218/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16369/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16369/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23CD3BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jun 2022 13:05:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B88C86563B;\n\tFri, 24 Jun 2022 15:05:35 +0200 (CEST)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30FA365639\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jun 2022 15:05:34 +0200 (CEST)", "by mail-wr1-x433.google.com with SMTP id e10so3027282wra.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jun 2022 06:05:34 -0700 (PDT)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tm20-20020a05600c4f5400b0039747cf8354sm2889703wmq.39.2022.06.24.06.05.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jun 2022 06:05:33 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656075935;\n\tbh=d95mMs6hm6GgG5cjWABdkLrLZGey2LNeU7PLMnvySqA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=GetJ0fiPNwSndayOPp0Fbu0Rk1KkrWMKv+dkJMY5KqoBZ9GPxlXJwsIjsTvXio3Ok\n\tu4MQhmR/ScXSyJ6BOV/g8ELAWkRLfimHLPQ1YYgXJv+tFPEBcMqMH+6XRhgIHQDevy\n\tadsDO0AO2QkvlRw84kRgBNZONBEpRxia22QPdEp9z30N2BLYd3c1TZE5lC7j/eaMjd\n\t18dOfgRVf2dKyRB5QsLWdg2fG8oH/SDvCPkX6VwLWNXtBkkFyBSYbV04maUYTsoPAV\n\tIPT87DXD8mF+hAR6XE3snwj5iHtqVJYfSf4ByRj25SDUw2/+b2j9pvR84L++lb1bys\n\tRZQ1j+jI4vcDA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jRQokZ1ijv8UYkszDObakGRM38Bj5VK5Dq47DLgN7Yc=;\n\tb=akLZDA74aoBdnjXvlx5DyLVBO3iVZKjEJCOSsNmQx9wldV/XiPNbPfA8PBlQVc2XKL\n\tQNkFASTUCQ3DTlDmSjFy9nUKyIIX5pVltOrmwDjkSVs+cwQtXuH3gPCZ/sI6Jf0TOmEZ\n\tur0915cUxIw9poujeg+y9MPglF0N46Yfux43gNj2OJQ/j0fKPf4qgOMTUG0SWI8RWV8k\n\t71KpA0tXyQx/rEXua8dD9Kr1B24+Df7dERghjmPP1JFVqdLdNCiinj3hUZXlylFf0s99\n\tnfFgC8UQDA5PXbd70EO7H0Z69bKvUrK65mOoBkIORqRLKL3YHiJCH666L7H9mTProeGK\n\tMuoQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"akLZDA74\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=jRQokZ1ijv8UYkszDObakGRM38Bj5VK5Dq47DLgN7Yc=;\n\tb=jjkZ2H1l64pImT2YD6WN0IlG79TI7RyHrk5vlm/7wY7F3i7UYBeeqcLhsQcC+jtFSN\n\tCBdjwVCqIczLY8u3e8lFy3SHGZxJBzah7aKmGFbGrCy0sYajyXu7YUO+hhhzmkyBlmIP\n\tuMK8IRxqIYiQTJjAgfY8Ic/BzWDbO1HDL6fPH6Cz1RlAdWtTV4l/5dMPIQx2+SHw50D5\n\tuOiatkPwFxnF7P1+ZFdESM1sgXzPzWsNBGLWukYxvMZq/xD9gbU91cVa1UkkermFXT9J\n\tWznyZFFuvt0gThwBTIGWvgTN7OzfuYVZTcG0QkMI+u9N8kAFSFKVcjhTWeEq1EsnK2+a\n\t0Tvg==", "X-Gm-Message-State": "AJIora/tAz8H+0Gz6Oo+pmKfXTJE6CDYELYNCP/Ii8TiVFmj41CXEbvw\n\tF1kUMQTflg5U7luI7QtffvMdy/0lBoAA7gRR", "X-Google-Smtp-Source": "AGRyM1uvH5Znq4N03NbmOehpbvXHb1ccAXJjPrGkrLjWlZtb4IK7kBSduaCcFDxUCXWADJpq1TtUHQ==", "X-Received": "by 2002:a05:6000:1541:b0:219:c470:186c with SMTP id\n\t1-20020a056000154100b00219c470186cmr13367321wry.34.1656075933681; \n\tFri, 24 Jun 2022 06:05:33 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 24 Jun 2022 15:05:23 +0200", "Message-Id": "<20220624130523.41535-3-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220624130523.41535-1-dse@thaumatec.com>", "References": "<20220624130523.41535-1-dse@thaumatec.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/2] cam: capture_script: Check\n\tparseFrames() return value for errors", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "parseFrames() return value was ignored. If there was an error during\nframe parsing, parsing was not stopped correctly.\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n src/cam/capture_script.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/cam/capture_script.cpp b/src/cam/capture_script.cpp\nindex 5812b122..9f7ab2af 100644\n--- a/src/cam/capture_script.cpp\n+++ b/src/cam/capture_script.cpp\n@@ -150,7 +150,9 @@ int CaptureScript::parseScript(FILE *script)\n \t\tstd::string section = eventScalarValue(event);\n \n \t\tif (section == \"frames\") {\n-\t\t\tparseFrames();\n+\t\t\tret = parseFrames();\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n \t\t} else {\n \t\t\tstd::cerr << \"Unsupported section '\" << section << \"'\"\n \t\t\t\t << std::endl;\n", "prefixes": [ "libcamera-devel", "v2", "2/2" ] }