Patch Detail
Show a patch.
GET /api/1.1/patches/16327/?format=api
{ "id": 16327, "url": "https://patchwork.libcamera.org/api/1.1/patches/16327/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16327/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220622151918.451635-4-fsylvestre@baylibre.com>", "date": "2022-06-22T15:19:16", "name": "[libcamera-devel,3/5] ipa: rkisp1: Add support of Lens Shading Correction control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f67426c5a7ffd8f96b4ef47e7a04a395a8e074c8", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16327/mbox/", "series": [ { "id": 3208, "url": "https://patchwork.libcamera.org/api/1.1/series/3208/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3208", "date": "2022-06-22T15:19:13", "name": "Add GSL, LSC and DPCC tuning support for rkisp1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3208/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16327/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16327/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25623BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 22 Jun 2022 15:19:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C00ED65639;\n\tWed, 22 Jun 2022 17:19:30 +0200 (CEST)", "from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB7D165633\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Jun 2022 17:19:24 +0200 (CEST)", "by mail-wr1-x433.google.com with SMTP id k22so17458767wrd.6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 22 Jun 2022 08:19:24 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:4175:47f:ec:c265])\n\tby smtp.gmail.com with ESMTPSA id\n\tbi11-20020a05600c3d8b00b0039c362311d2sm1745388wmb.9.2022.06.22.08.19.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 22 Jun 2022 08:19:23 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655911170;\n\tbh=yqq+UBp20k1C+9wZ1HmBhedkGwYdaBaRwvsHvWjiKvM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=xSxBManRyQkRT2fcA0VESDa0o5vyatVMrt7XDSoKmqqfJC6m+ACjcG5ZImzRxfddK\n\tN0igSLL8Appadyfrg0zaNS3G7dP5v8/PrckFg5NIrgg2boLuVONDkS1lTd53PRN8Ix\n\tscOUX54h0mGo6y+HeSms+0r/JId9YUuWYFaDovdmlLVU6VmxivZ5Cw5qUhlx6FoAQb\n\trjKvYv8G1FfmZnT7vPN4iO6DbBOwABD8sKEgLVtcIZYjCJg22J+dbu2X2z6jFOFeYF\n\tRKGbDH/3+SQdymwq0Cy14ubpmKpEVvrEYo22lrPgUohGrzDm+X2lS3U73/0KSlaJea\n\t6+unZ3Lny+Plw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=0RPtkDZxBIg4j/flfTGF68aYP828g80Oux51XyfzmZc=;\n\tb=Xlf8UMKYp7hoKwbt9UqvWlhFHKo73iyC0kN6608fmbX7/ZfM00zHlxBFbWaqJYVRQp\n\tYu/RT8sF6WRyEQs0QIamAfo4uwrLlHyWd8QUCwRoSAKGzJUQNfw3PjiOk46C44JxXRlE\n\tE5tMMSwdY0Og90UAGJ7Ez30SD5W9lKizgf6geXQEyA1MXJPj32ToAMUmURNq+b4JKnud\n\tgttvrojwsT3zdCdeOGoC8PIIpzmCobsVE6QXJGLRSyWPIytuEJCg3loGfhtEgb0s70Mi\n\tO4I+tn9Mz09yG377YUwwVB99xsTQxpHapjgjf+wiEkam06YkBY/qukBvNjuogsZavykt\n\tk4CA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"Xlf8UMKY\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=0RPtkDZxBIg4j/flfTGF68aYP828g80Oux51XyfzmZc=;\n\tb=lLzAF3ahv/TbIMtvOGnvsvKgXVEqfUb/+9uABUX5Bz2bx2pVT4ihvm+HadLUhkApyq\n\t27tHWXfDIdsWVh8jzACZ36duZ5BJJCZEykFMUIyT6IFf08XlSUDVIMpeIFZIBRQZDQQI\n\tH4Gq2yZ8Ph7wGvOZpIphODLkmA/l5LZidYTPWgRuaovtjMK+A1Hu9JngLj/YqnQIV3if\n\tSnifSo80zlCTVDVmKbxbTj7ZBg/HpwxoWDBcuSKY7uDKGokrarS58X+LUw0DAEnZ4SUt\n\tCs2Gwxou6U2Q2NuUqiPh0Zwy2nbjc0JmU3hvpQIXx92ZTzWvVjETVXzU8YMwSgnmgSg6\n\tbsgg==", "X-Gm-Message-State": "AJIora+VQoxMpKvgGTVrvAi6KhmLMxxoAKXlGk0sN7zNvqcwuPQc2z+c\n\tHRHwxlCL7RS1gRT8+QKvxc9OJlD6SIM7Xw==", "X-Google-Smtp-Source": "AGRyM1tAWObT9B/gbDWK9OMKLTlJdIoY9RbP6tWwswLX/vgE3Wn5lfs6yROixXN4Fof4564BaIWD8A==", "X-Received": "by 2002:adf:e4c9:0:b0:21b:9336:16b9 with SMTP id\n\tv9-20020adfe4c9000000b0021b933616b9mr3989479wrm.696.1655911163863; \n\tWed, 22 Jun 2022 08:19:23 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 22 Jun 2022 17:19:16 +0200", "Message-Id": "<20220622151918.451635-4-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220622151918.451635-1-fsylvestre@baylibre.com>", "References": "<20220622151918.451635-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 3/5] ipa: rkisp1: Add support of Lens\n\tShading Correction control", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Lens Shading Correction algorithm applies a correction on the pixels based\non values defined in the YAML tuning file.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 171 ++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/lsc.h | 44 +++++++\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/data/ov5640.yaml | 81 ++++++++++++\n src/ipa/rkisp1/rkisp1.cpp | 1 +\n 5 files changed, 298 insertions(+)\n create mode 100644 src/ipa/rkisp1/algorithms/lsc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/lsc.h", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nnew file mode 100644\nindex 00000000..f68243a1\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -0,0 +1,171 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021-2022, Ideas On Board\n+ *\n+ * lsc.cpp - RkISP1 Lens Shading Correction control\n+ */\n+\n+#include \"lsc.h\"\n+\n+#include <libcamera/base/log.h>\n+\n+#include \"libcamera/internal/yaml_parser.h\"\n+#include \"linux/rkisp1-config.h\"\n+\n+/**\n+ * \\file lsc.h\n+ */\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+/**\n+ * \\class LensShadingCorrection\n+ * \\brief RkISP1 Lens Shading Correction control\n+ *\n+ * Due to the optical characteristics of the lens, the light intensity received\n+ * by the sensor is not uniform.\n+ *\n+ * The Lens Shading Correction algorithm applies a correction on the pixels for\n+ * each component based on measurement done during the camera tuning process.\n+ */\n+\n+LOG_DEFINE_CATEGORY(RkISP1Lsc)\n+\n+LensShadingCorrection::LensShadingCorrection()\n+\t: tuningParameters_(false)\n+{\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::init\n+ */\n+int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n+\t\t\t\tconst YamlObject &tuningData)\n+{\n+\txSizeTbl_ = tuningData[\"x-size\"].getList<uint16_t>();\n+\tif (xSizeTbl_.size() != RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'x-size'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< xSizeTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tySizeTbl_ = tuningData[\"y-size\"].getList<uint16_t>();\n+\tif (ySizeTbl_.size() != RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'y-size'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< ySizeTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\txGradTbl_ = tuningData[\"x-grad\"].getList<uint16_t>();\n+\tif (xGradTbl_.size() != RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'x-grad'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< xGradTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tyGradTbl_ = tuningData[\"y-grad\"].getList<uint16_t>();\n+\tif (yGradTbl_.size() != RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'y-grad'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< yGradTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SECTORS_TBL_SIZE << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\trDataTbl_ = tuningData[\"r\"].getList<uint16_t>();\n+\tif (rDataTbl_.size() != RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'r'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< rDataTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tgrDataTbl_ = tuningData[\"gr\"].getList<uint16_t>();\n+\tif (grDataTbl_.size() != RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'gr'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< grDataTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tgbDataTbl_ = tuningData[\"gb\"].getList<uint16_t>();\n+\tif (gbDataTbl_.size() != RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'gb'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< gbDataTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tbDataTbl_ = tuningData[\"b\"].getList<uint16_t>();\n+\tif (bDataTbl_.size() != RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX) {\n+\t\tLOG(RkISP1Lsc, Error)\n+\t\t\t<< \"Issue while parsing 'b'\"\n+\t\t\t<< \"in tuning file (list size:\"\n+\t\t\t<< bDataTbl_.size() << \"/\"\n+\t\t\t<< RKISP1_CIF_ISP_LSC_SAMPLES_MAX * RKISP1_CIF_ISP_LSC_SAMPLES_MAX << \")\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\ttuningParameters_ = true;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::prepare\n+ */\n+void LensShadingCorrection::prepare(IPAContext &context,\n+\t\t\t\t rkisp1_params_cfg *params)\n+{\n+\tif (context.frameContext.frameCount > 0)\n+\t\treturn;\n+\n+\tif (!tuningParameters_)\n+\t\treturn;\n+\n+\tstd::copy(xSizeTbl_.begin(), xSizeTbl_.end(),\n+\t\t params->others.lsc_config.x_size_tbl);\n+\tstd::copy(ySizeTbl_.begin(), ySizeTbl_.end(),\n+\t\t params->others.lsc_config.y_size_tbl);\n+\tstd::copy(xGradTbl_.begin(), xGradTbl_.end(),\n+\t\t params->others.lsc_config.x_grad_tbl);\n+\tstd::copy(yGradTbl_.begin(), yGradTbl_.end(),\n+\t\t params->others.lsc_config.y_grad_tbl);\n+\n+\tstd::copy(rDataTbl_.begin(), rDataTbl_.end(),\n+\t\t ¶ms->others.lsc_config.r_data_tbl[0][0]);\n+\tstd::copy(grDataTbl_.begin(), grDataTbl_.end(),\n+\t\t ¶ms->others.lsc_config.gr_data_tbl[0][0]);\n+\tstd::copy(gbDataTbl_.begin(), gbDataTbl_.end(),\n+\t\t ¶ms->others.lsc_config.gb_data_tbl[0][0]);\n+\tstd::copy(bDataTbl_.begin(), bDataTbl_.end(),\n+\t\t ¶ms->others.lsc_config.b_data_tbl[0][0]);\n+\n+\tparams->module_en_update |= RKISP1_CIF_ISP_MODULE_LSC;\n+\tparams->module_ens |= RKISP1_CIF_ISP_MODULE_LSC;\n+\tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_LSC;\n+}\n+\n+REGISTER_IPA_ALGORITHM(LensShadingCorrection)\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\nnew file mode 100644\nindex 00000000..7f620ffa\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/lsc.h\n@@ -0,0 +1,44 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021-2022, Ideas On Board\n+ *\n+ * gsl.h - RkISP1 Lens Shading Correction control\n+ */\n+\n+#pragma once\n+\n+#include <linux/rkisp1-config.h>\n+\n+#include \"algorithm.h\"\n+\n+namespace libcamera {\n+\n+struct IPACameraSensorInfo;\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+class LensShadingCorrection : public Algorithm\n+{\n+public:\n+\tLensShadingCorrection();\n+\t~LensShadingCorrection() = default;\n+\n+\tint init(IPAContext &context, const YamlObject &tuningData) override;\n+\tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n+\n+private:\n+\tbool tuningParameters_;\n+\n+\tstd::vector<uint16_t> rDataTbl_;\n+\tstd::vector<uint16_t> grDataTbl_;\n+\tstd::vector<uint16_t> gbDataTbl_;\n+\tstd::vector<uint16_t> bDataTbl_;\n+\n+\tstd::vector<uint16_t> xGradTbl_;\n+\tstd::vector<uint16_t> yGradTbl_;\n+\tstd::vector<uint16_t> xSizeTbl_;\n+\tstd::vector<uint16_t> ySizeTbl_;\n+};\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+} /* namespace libcamera */\ndiff --git a/src/ipa/rkisp1/algorithms/meson.build b/src/ipa/rkisp1/algorithms/meson.build\nindex 0597c353..64e11dce 100644\n--- a/src/ipa/rkisp1/algorithms/meson.build\n+++ b/src/ipa/rkisp1/algorithms/meson.build\n@@ -5,4 +5,5 @@ rkisp1_ipa_algorithms = files([\n 'awb.cpp',\n 'blc.cpp',\n 'gsl.cpp',\n+ 'lsc.cpp',\n ])\ndiff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\nindex 6cb84ed9..154ed3b5 100644\n--- a/src/ipa/rkisp1/data/ov5640.yaml\n+++ b/src/ipa/rkisp1/data/ov5640.yaml\n@@ -16,4 +16,85 @@ algorithms:\n red: [ 0, 256, 512, 768, 1024, 1280, 1536, 1792, 2048, 2304, 2560, 2816, 3072, 3328, 3584, 3840, 4096 ]\n green: [ 0, 256, 512, 768, 1024, 1280, 1536, 1792, 2048, 2304, 2560, 2816, 3072, 3328, 3584, 3840, 4096 ]\n blue: [ 0, 256, 512, 768, 1024, 1280, 1536, 1792, 2048, 2304, 2560, 2816, 3072, 3328, 3584, 3840, 4096 ]\n+ - LensShadingCorrection:\n+ x-size: [ 512, 1024, 1536, 2048, 2560, 3072, 3584, 4096 ]\n+ y-size: [ 512, 1024, 1536, 2048, 2560, 3072, 3584, 4096 ]\n+ x-grad: [ 0, 0, 0, 0, 0, 0, 0, 0 ]\n+ y-grad: [ 0, 0, 0, 0, 0, 0, 0, 0 ]\n+ r: [\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ ]\n+ gr: [\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ ]\n+ gb: [\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ ]\n+ b: [\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,\n+ ]\n ...\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 622a0d61..996edc0a 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -32,6 +32,7 @@\n #include \"algorithms/awb.h\"\n #include \"algorithms/blc.h\"\n #include \"algorithms/gsl.h\"\n+#include \"algorithms/lsc.h\"\n #include \"libipa/camera_sensor_helper.h\"\n \n #include \"ipa_context.h\"\n", "prefixes": [ "libcamera-devel", "3/5" ] }