Patch Detail
Show a patch.
GET /api/1.1/patches/16295/?format=api
{ "id": 16295, "url": "https://patchwork.libcamera.org/api/1.1/patches/16295/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16295/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220620210658.20288-3-laurent.pinchart@ideasonboard.com>", "date": "2022-06-20T21:06:56", "name": "[libcamera-devel,2/4] utils: rkisp1: Fix sensor format parsing", "commit_ref": "9007d37939b971930252fd74b973b0d9c0c83eed", "pull_url": null, "state": "accepted", "archived": false, "hash": "c901a6bb6d22dfd8d779a97a595fa4dee91f8afb", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16295/mbox/", "series": [ { "id": 3197, "url": "https://patchwork.libcamera.org/api/1.1/series/3197/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3197", "date": "2022-06-20T21:06:54", "name": "utils: rkisp1: Miscellaneous capture script updates", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3197/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16295/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16295/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76D2DBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jun 2022 21:07:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16D3F65642;\n\tMon, 20 Jun 2022 23:07:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CD4A65632\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jun 2022 23:07:18 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4F3DE5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jun 2022 23:07:17 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655759243;\n\tbh=D1OMN0SUrV0qHqWFe357kEXLc2M9F/1Q5I2WDT7fLgE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PkMYKPMWHVfUH4V/nn0wE4ilrrwTtRzO2Wa8Cp9P6TAOTtjtqc+Go7FG1x6y7P5G4\n\tRGMBQbZ7YnqB582muI2B+oxOS2ZWDXlZ+qgd6yX4n5fhfyA65+rf3Hcua282NX7d/0\n\tHDcbN5Ln7LhHCTypVcKo6m6tihmdSdCgGB3C7zFKvED1B7W+wAK/Tv8qoVxpQiJBSH\n\tIB+o7/yHQTVWuW32kvp/v0LfAAwWhnmu1Rgyhx1FVH+Lk4BDuhRyDNXIjMW/wBduFW\n\tFZfGxCuefte4biSKa62oC+rHVmqHz0u7HZu/jJKw3XftXsqQsn22uyfyMYaYDAYh8s\n\tWltFbUs3ff5iQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655759237;\n\tbh=D1OMN0SUrV0qHqWFe357kEXLc2M9F/1Q5I2WDT7fLgE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pNpaWLteuBDyGXRvT1YJ2PSGx3dpjFXcMKL/v0eNPTWqchwgTFT/dPzaDcsLQkauh\n\tSPNn6XixOGE6EFOxeVGFyyilUDn2L/JYNlLh7Iu49qD1T7wQ+EWJtAsPDlzzfYy3WU\n\tlV7yy9InJ6bu7tkPAkojXEhPYe4VkoV91swB5iTI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pNpaWLte\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 21 Jun 2022 00:06:56 +0300", "Message-Id": "<20220620210658.20288-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220620210658.20288-1-laurent.pinchart@ideasonboard.com>", "References": "<20220620210658.20288-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/4] utils: rkisp1: Fix sensor format\n\tparsing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With sensors supporting crop, the regexp used to parse the media-ctl\noutput isn't correct as the pad configuration may span multiple lines\nand contain other parameters. Fix it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n utils/rkisp1/rkisp1-capture.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/rkisp1/rkisp1-capture.sh b/utils/rkisp1/rkisp1-capture.sh\nindex d5ebe5b1d1ba..eee6b8027261 100755\n--- a/utils/rkisp1/rkisp1-capture.sh\n+++ b/utils/rkisp1/rkisp1-capture.sh\n@@ -51,7 +51,7 @@ get_sensor_format() {\n \tlocal format\n \tlocal sensor=$1\n \n-\tformat=$($mediactl --get-v4l2 \"'$sensor':0\" | sed 's/\\[\\([^ ]*\\).*/\\1/')\n+\tformat=$($mediactl --get-v4l2 \"'$sensor':0\" | grep 'fmt:' | sed 's/.*\\(fmt:\\S*\\).*/\\1/')\n \tsensor_mbus_code=$(echo $format | sed 's/fmt:\\([A-Z0-9_]*\\).*/\\1/')\n \tsensor_size=$(echo $format | sed 's/[^\\/]*\\/\\([0-9x]*\\).*/\\1/')\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }