Patch Detail
Show a patch.
GET /api/1.1/patches/16291/?format=api
{ "id": 16291, "url": "https://patchwork.libcamera.org/api/1.1/patches/16291/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16291/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220620165027.549085-5-umang.jain@ideasonboard.com>", "date": "2022-06-20T16:50:26", "name": "[libcamera-devel,v2,4/5] v4l2: v4l2_camera_proxy: Apply clang thread safety annotation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9e308694b374d94700b61e436b84db9c8fd10f8d", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16291/mbox/", "series": [ { "id": 3196, "url": "https://patchwork.libcamera.org/api/1.1/series/3196/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3196", "date": "2022-06-20T16:50:22", "name": "Apply clang thread safety annotation libcamera-core and v4l2", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3196/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16291/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16291/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 331B1BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jun 2022 16:50:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDC8A65641;\n\tMon, 20 Jun 2022 18:50:46 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97A8F65640\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jun 2022 18:50:45 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:e389:cb58:4104:f66:a571])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C4B0883;\n\tMon, 20 Jun 2022 18:50:44 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655743846;\n\tbh=UAJykEr45Nf0wkT3z56vMjcJNiCLAm/eR/9iX6k9oDc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=yuyWgZMZWvfH53EOY8bw8SIRxVfZ5iu0XM0veE/XpOm6VlRTmm5vW6cKNmUMb8HMo\n\tIHqeGn4mKxxJrUJ7ZQXv9KUn2RewezL1wwx7pRsCt5hDhwOY15i58QnmNUXChf1QvQ\n\tin8kLjBtYCB5xu4sSd37WPfbkXJHP4MvM2w88Tq4ZJFhgruX2ZKsKJuOVQX8OagW6+\n\tTNvtYHkqj7C9qyIR0+I1FiV5ctmvBBiuioSa0fF/uQkKZTLc5K/F6LllKtIM7psAHR\n\teYwdTjlUiGYq7hEeL6+RppfmdcCyfsuptvv81oKTh9Q0U7DQA7OiPGCiy2uEub4ypH\n\tPz8AxGBU4iVrw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655743845;\n\tbh=UAJykEr45Nf0wkT3z56vMjcJNiCLAm/eR/9iX6k9oDc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZC4mHayRmMCy5CxWDmJDAAva9UBlCPQMrJdBhxR2ResLE3mAG2PJcXX6eg2E6Dr8b\n\t4mKfehjgjYFef9JbNmKAbab7CKtqZ8nCurKb2bT0oCzKNQUcIdxtb0xRJkIeii6T6i\n\tzzIGpEtRmm4TKoBmOQIRpsBdPilA/qEaZgpGbUpI=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZC4mHayR\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jun 2022 22:20:26 +0530", "Message-Id": "<20220620165027.549085-5-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220620165027.549085-1-umang.jain@ideasonboard.com>", "References": "<20220620165027.549085-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/5] v4l2: v4l2_camera_proxy: Apply\n\tclang thread safety annotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hirokazu Honda <hiroh@chromium.org>\n\nThis annotates member functions of V4L2CameraProxy by clang\nthread safety annotations.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/v4l2/v4l2_camera_proxy.h | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\nindex 76ca2d8a..8a0195e1 100644\n--- a/src/v4l2/v4l2_camera_proxy.h\n+++ b/src/v4l2/v4l2_camera_proxy.h\n@@ -27,13 +27,15 @@ class V4L2CameraProxy\n public:\n \tV4L2CameraProxy(unsigned int index, std::shared_ptr<libcamera::Camera> camera);\n \n-\tint open(V4L2CameraFile *file);\n-\tvoid close(V4L2CameraFile *file);\n+\tint open(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tvoid close(V4L2CameraFile *file) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \tvoid *mmap(V4L2CameraFile *file, void *addr, size_t length, int prot,\n-\t\t int flags, off64_t offset);\n-\tint munmap(V4L2CameraFile *file, void *addr, size_t length);\n+\t\t int flags, off64_t offset) LIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n+\tint munmap(V4L2CameraFile *file, void *addr, size_t length)\n+\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \n-\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg);\n+\tint ioctl(V4L2CameraFile *file, unsigned long request, void *arg)\n+\t\tLIBCAMERA_TSA_EXCLUDES(proxyMutex_);\n \n private:\n \tbool validateBufferType(uint32_t type);\n", "prefixes": [ "libcamera-devel", "v2", "4/5" ] }