Patch Detail
Show a patch.
GET /api/1.1/patches/16289/?format=api
{ "id": 16289, "url": "https://patchwork.libcamera.org/api/1.1/patches/16289/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16289/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220620165027.549085-3-umang.jain@ideasonboard.com>", "date": "2022-06-20T16:50:24", "name": "[libcamera-devel,v2,2/5] libcamera: base: thread: Apply clang thread safety annotation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "529ef859b03e46336a972e5cefb5736637f86a08", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16289/mbox/", "series": [ { "id": 3196, "url": "https://patchwork.libcamera.org/api/1.1/series/3196/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3196", "date": "2022-06-20T16:50:22", "name": "Apply clang thread safety annotation libcamera-core and v4l2", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3196/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16289/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16289/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2299BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jun 2022 16:50:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74B416563A;\n\tMon, 20 Jun 2022 18:50:43 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F74A65634\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jun 2022 18:50:41 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:e389:cb58:4104:f66:a571])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 595A9883;\n\tMon, 20 Jun 2022 18:50:40 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655743843;\n\tbh=re4OBnNCW5TdEGTRkkjM/RrhyqeVTtPo5/e/DE+wZ4s=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Y5WY31OR16WUZFBV+idZ9UBz6mSdSeRi78UAOmez1k9B6UqLQoMFskKGZCPZKURFA\n\tUgCvYvO8JNhFg4EoKkXX9tBLVLgNhBQI/OddP2qsSB3KBKjaFuzfaEuEDu50QA0d5U\n\tM382VwdIciVQcg7lBIHe+U2kndEwaX6UCV2arXKy9wLwPhGO80qMBKWNXsVcPfckaM\n\td/wZM4MF9ANMO0a4gk3/fHP8WaCXD2JDoK17Q2FlYRMc/CDLpmvf9H2jKtv8ymIP9k\n\t3ABIIOefrkV2scz/TfKm3beUD8zyqj6lT7RBg0h1WaYKqx9yKAk+uyM8B+uKY8tbjN\n\teyyS59+hIRJeg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655743841;\n\tbh=re4OBnNCW5TdEGTRkkjM/RrhyqeVTtPo5/e/DE+wZ4s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ek7W0TgTkcTq2f1G1Wb5gAmkHAgRJqaDz6tSsITL9WoW6Fca+HEalLeqTtfxoV83T\n\theUqlzsK58pu4GdoVxDmJ8aPo5S9zPKmxK0g+YOrsSW79mYiZxabjMxQ/s1+sXibUm\n\t2E8DTSe61wjczo7rH/c+ikvPnSPgWkd/Dhtp5Y7k=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ek7W0TgT\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jun 2022 22:20:24 +0530", "Message-Id": "<20220620165027.549085-3-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220620165027.549085-1-umang.jain@ideasonboard.com>", "References": "<20220620165027.549085-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/5] libcamera: base: thread: Apply\n\tclang thread safety annotation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hirokazu Honda <hiroh@chromium.org>\n\nThis annotates member variables of ThreadData by clang thread\nsafety annotations.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/base/thread.cpp | 22 +++++++++++++++-------\n 1 file changed, 15 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/base/thread.cpp b/src/libcamera/base/thread.cpp\nindex 6bda9d14..2e26b83c 100644\n--- a/src/libcamera/base/thread.cpp\n+++ b/src/libcamera/base/thread.cpp\n@@ -151,7 +151,7 @@ private:\n \tfriend class ThreadMain;\n \n \tThread *thread_;\n-\tbool running_;\n+\tbool running_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \tpid_t tid_;\n \n \tMutex mutex_;\n@@ -160,7 +160,7 @@ private:\n \n \tConditionVariable cv_;\n \tstd::atomic<bool> exit_;\n-\tint exitCode_;\n+\tint exitCode_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \n \tMessageQueue messages_;\n };\n@@ -422,11 +422,19 @@ bool Thread::wait(utils::duration duration)\n \t{\n \t\tMutexLocker locker(data_->mutex_);\n \n-\t\tif (duration == utils::duration::max())\n-\t\t\tdata_->cv_.wait(locker, [&]() { return !data_->running_; });\n-\t\telse\n-\t\t\thasFinished = data_->cv_.wait_for(locker, duration,\n-\t\t\t\t\t\t\t [&]() { return !data_->running_; });\n+\t\tif (duration == utils::duration::max()) {\n+\t\t\tdata_->cv_.wait(\n+\t\t\t\tlocker,\n+\t\t\t\t[&]() LIBCAMERA_TSA_REQUIRES(data_->mutex_) {\n+\t\t\t\t\treturn !data_->running_;\n+\t\t\t\t});\n+\t\t} else {\n+\t\t\thasFinished = data_->cv_.wait_for(\n+\t\t\t\tlocker, duration,\n+\t\t\t\t[&]() LIBCAMERA_TSA_REQUIRES(data_->mutex_) {\n+\t\t\t\t\treturn !data_->running_;\n+\t\t\t\t});\n+\t\t}\n \t}\n \n \tif (thread_.joinable())\n", "prefixes": [ "libcamera-devel", "v2", "2/5" ] }