Patch Detail
Show a patch.
GET /api/1.1/patches/16284/?format=api
{ "id": 16284, "url": "https://patchwork.libcamera.org/api/1.1/patches/16284/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16284/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220620055809.392808-1-umang.jain@ideasonboard.com>", "date": "2022-06-20T05:58:09", "name": "[libcamera-devel] libcamera: camera_manager: Protect cameras_ by mutex in cleanup()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "049e3d552aacf147b2ac2d2e7a0fe4e8afc68966", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/1.1/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/16284/mbox/", "series": [ { "id": 3193, "url": "https://patchwork.libcamera.org/api/1.1/series/3193/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3193", "date": "2022-06-20T05:58:09", "name": "[libcamera-devel] libcamera: camera_manager: Protect cameras_ by mutex in cleanup()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3193/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16284/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16284/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C51D2BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jun 2022 05:58:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1641465633;\n\tMon, 20 Jun 2022 07:58:17 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E82F86048F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jun 2022 07:58:15 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:e389:cb58:4104:f66:a571])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60537104;\n\tMon, 20 Jun 2022 07:58:14 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655704697;\n\tbh=4pxHvjr/zfTQFucgQtE1IVkBZxBUYhAsFcI7ggwb/0I=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=e+nC0vyUN3o80Z6RAFCdaLkFTR03vQd4FGXM/tpf4KB0OmVgdouqrnonCjEc36/D/\n\tl/TutcwBLJvTM5uLQwiQOvMYblNS3OMXGw5NBhAZaU6uEHSBk/S2B2Nzib+xN03WRA\n\teRdfi284YRraoDZhrGlN+JlZq//JHRmaiugR1kGtiWp3dOj0GNheecv3C6FzHlxH8R\n\tyqY7JamhRRBy9BOS789SzBGjebHlTYcespfuEdEfpJWIU5gyPe2aPM/DOb5uiY728s\n\tQiMR/lAJliTf9bpEzAsQsAUkmP09Q3z4i/Q5xGNbSttir8pJOQjcDQeFRPgi3Ft/Pn\n\tbYiZrRdzUTBWg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655704695;\n\tbh=4pxHvjr/zfTQFucgQtE1IVkBZxBUYhAsFcI7ggwb/0I=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XeWNddj6oV6Nxw0NAKuyKVZGv8KxpOjz4Yv5PlzSUWe4mfar1weC6XubLn8kzBPe3\n\tcUTmkcGze/V55WpNUbZU/YamXVTJjXNADkhalufpsmp/fVbUFso7dlpzEi8MjFhpYs\n\tVefFueuZod6j/yTfnzPCwlMlkcyRfu2S4wkIn9F4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XeWNddj6\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jun 2022 11:28:09 +0530", "Message-Id": "<20220620055809.392808-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: camera_manager: Protect\n\tcameras_ by mutex in cleanup()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hirokazu Honda <hiroh@chromium.org>\n\nCameraManager::Private::cleanup() accesses cameras_ without acquiring\nmutex_. Fix it.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/libcamera/camera_manager.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 70d73822..4492edc3 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -178,7 +178,10 @@ void CameraManager::Private::cleanup()\n \t * process deletion requests from the thread's message queue as the event\n \t * loop is not in action here.\n \t */\n+\tmutex_.lock();\n \tcameras_.clear();\n+\tmutex_.unlock();\n+\n \tdispatchMessages(Message::Type::DeferredDelete);\n \n \tenumerator_.reset(nullptr);\n", "prefixes": [ "libcamera-devel" ] }