Patch Detail
Show a patch.
GET /api/1.1/patches/16272/?format=api
{ "id": 16272, "url": "https://patchwork.libcamera.org/api/1.1/patches/16272/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16272/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220620014305.26778-3-laurent.pinchart@ideasonboard.com>", "date": "2022-06-20T01:42:55", "name": "[libcamera-devel,v4,02/12] ipa: libipa: Move ipa namespace documentation to module.cpp", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "af0a6d95ac6de1b205f7065b056d897c2793ab8b", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16272/mbox/", "series": [ { "id": 3191, "url": "https://patchwork.libcamera.org/api/1.1/series/3191/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3191", "date": "2022-06-20T01:42:53", "name": "Add tuning file support for the RkISP1 IPA module", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3191/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16272/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16272/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A04B0BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jun 2022 01:43:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E88C65648;\n\tMon, 20 Jun 2022 03:43:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4A9F601F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jun 2022 03:43:25 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A27B892;\n\tMon, 20 Jun 2022 03:43:25 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655689409;\n\tbh=oCOhFtxVSryoQnb8LtgrbwXQVOLE/FSIDXX+AGuIDP4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jlwxklg5eKBi0+fDE8dVDmlNEkF2GzKM6xCVYk4D5PtKHwHcygMfsrfh4GwwuMtE6\n\tiFDXwc836ELh6qYQbpgdL8W8142h0cSACIm/83Hzp/L+4ZzdQ52To6trIxs2j+JQyx\n\tumcIGRPrALE/GU4vdqNeUe8RtoEN1ttSV4VW8xEwhOczYXMhqeyTsZVXtLtEiZGLe7\n\tmTG597c06KwCHOB/93WG9kTkpphKOzw7HII0yg3H90ZrfsV+eksErXHdUBqJqz5dSb\n\tDH5A8n+3NaSiah26rJh4Z0t4+XXMCvf2YFN/inzs84yItgCuunsrSxcmnnsBFPTrQR\n\t0gIsMsif5e6qA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655689405;\n\tbh=oCOhFtxVSryoQnb8LtgrbwXQVOLE/FSIDXX+AGuIDP4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Dfjrqor4bwgLvytWEkHMk138RPeJ0xHankh9ny+DPL3p29ZzF8OIMudfhLrYdD4jk\n\tMAByyJ15P07I4Gdi8F4UXgVCQIHEsKhqK5ixh0OcEvowoV3U0McM4eRKt8cXbpcgAT\n\tAsF4JBwEOCZgSLmlFZOBd2+M0kUQS8CiAHcSKNLY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Dfjrqor4\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 20 Jun 2022 04:42:55 +0300", "Message-Id": "<20220620014305.26778-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>", "References": "<20220620014305.26778-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 02/12] ipa: libipa: Move ipa namespace\n\tdocumentation to module.cpp", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libipa.cpp file exists for the sole purpose of documentating the ipa\nnamespace. As we now have a top-level module.cpp file in libipa, move\nthe documentation there, and drop libipa.cpp.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/libipa.cpp | 22 ----------------------\n src/ipa/libipa/meson.build | 1 -\n src/ipa/libipa/module.cpp | 7 +++++++\n 3 files changed, 7 insertions(+), 23 deletions(-)\n delete mode 100644 src/ipa/libipa/libipa.cpp", "diff": "diff --git a/src/ipa/libipa/libipa.cpp b/src/ipa/libipa/libipa.cpp\ndeleted file mode 100644\nindex 08bc3541f4eb..000000000000\n--- a/src/ipa/libipa/libipa.cpp\n+++ /dev/null\n@@ -1,22 +0,0 @@\n-/* SPDX-License-Identifier: LGPL-2.1-or-later */\n-/*\n- * Copyright (C) 2021, Ideas On Board\n- *\n- * libipa.cpp - libipa interface\n- */\n-\n-namespace libcamera {\n-\n-/**\n- * \\brief The IPA namespace\n- *\n- * The IPA namespace groups all types specific to IPA modules. It serves as the\n- * top-level namespace for the IPA library libipa, and also contains\n- * module-specific namespaces for IPA modules.\n- */\n-namespace ipa {\n-\n-} /* namespace ipa */\n-\n-} /* namespace libcamera */\n-\ndiff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\nindex 465cf7d6c4a7..fb894bc614af 100644\n--- a/src/ipa/libipa/meson.build\n+++ b/src/ipa/libipa/meson.build\n@@ -11,7 +11,6 @@ libipa_sources = files([\n 'algorithm.cpp',\n 'camera_sensor_helper.cpp',\n 'histogram.cpp',\n- 'libipa.cpp',\n 'module.cpp',\n ])\n \ndiff --git a/src/ipa/libipa/module.cpp b/src/ipa/libipa/module.cpp\nindex 5a6f49a80e6d..d03cc8ef03ed 100644\n--- a/src/ipa/libipa/module.cpp\n+++ b/src/ipa/libipa/module.cpp\n@@ -14,6 +14,13 @@\n \n namespace libcamera {\n \n+/**\n+ * \\brief The IPA namespace\n+ *\n+ * The IPA namespace groups all types specific to IPA modules. It serves as the\n+ * top-level namespace for the IPA library libipa, and also contains\n+ * module-specific namespaces for IPA modules.\n+ */\n namespace ipa {\n \n /**\n", "prefixes": [ "libcamera-devel", "v4", "02/12" ] }