Patch Detail
Show a patch.
GET /api/1.1/patches/16266/?format=api
{ "id": 16266, "url": "https://patchwork.libcamera.org/api/1.1/patches/16266/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16266/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220617143549.35442-2-dse@thaumatec.com>", "date": "2022-06-17T14:35:47", "name": "[libcamera-devel,v2,1/3] Documentation: Add the missing const to the example code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04c385c35dcc5d7abd9e447706792d998023d381", "submitter": { "id": 126, "url": "https://patchwork.libcamera.org/api/1.1/people/126/?format=api", "name": "Daniel Semkowicz", "email": "dse@thaumatec.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16266/mbox/", "series": [ { "id": 3189, "url": "https://patchwork.libcamera.org/api/1.1/series/3189/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3189", "date": "2022-06-17T14:35:46", "name": "Documentation: Update code examples in Application Writer's Guide", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3189/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16266/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16266/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AB91C3273\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Jun 2022 14:36:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B516E65633;\n\tFri, 17 Jun 2022 16:36:01 +0200 (CEST)", "from mail-ej1-x630.google.com (mail-ej1-x630.google.com\n\t[IPv6:2a00:1450:4864:20::630])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFC8465634\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jun 2022 16:35:59 +0200 (CEST)", "by mail-ej1-x630.google.com with SMTP id kq6so9131727ejb.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jun 2022 07:35:59 -0700 (PDT)", "from localhost.localdomain (ip092042140082.rev.nessus.at.\n\t[92.42.140.82]) by smtp.gmail.com with ESMTPSA id\n\tu20-20020aa7d554000000b0042a2d9af0f8sm3746189edr.79.2022.06.17.07.35.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jun 2022 07:35:58 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655476561;\n\tbh=bfC5m4po1aXHCHv8kSDq/G+Xmwx2dfvIIEqCdfLnAS8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=p0WT7IGMl6fgeSufBpCbbsua/QaKjISdQuginTi1R36oA6kg7X5lMjHWdO+FhDqLL\n\tcUlC7H5EpJi2I26GM2vrEa8IP/m2zbEG3y/0Db88KjfucxcVSd4uuSTSho6sYAXiND\n\tvdXVxzztyYFz6zJhG0oQAnRVN3bkpOcBgWH5A1zFiS4AxGA6YMp3ORUup9sOu3E/Eo\n\tI9oJeYO+g6M8In6P6+XvLVoR3PY7tDkCFJmsA3b0jHUM2/BDoVTWSJw1vND/Nl40/o\n\tJe8MGoL8tmwq7V9XtbuAepcq2O4KSN5YuDTmRhpZUHC+uAtWrbLB93iaBanbaU8Hnw\n\tRBz3RKDxAEjvg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=oCovsv3VFF1beHyZ5aPXj8YqDmLQsuqKHjhWl1wvOrc=;\n\tb=lGWKN/pYNeq1c8YZ7SikO9RcsCpNZYHEueWjYce/OGhs6TNNmzI1kbslebAg/wtkWJ\n\tkt+Kldlwo79PxzQ8RYyjmsblL7KtC9cpzjG1EiCGu28bzNmx4sKJtA4vV+0+/Xco0XGq\n\tg2PUAbmMmyzwOvUXsBOBVv7y7ZTN7VrZRECbW2qCBXi9N8p9cbNk+9xfKsCSt2rCn8wS\n\tnKKEtLk16khZqfKXTCdT4DQ23pXIjlMHsJofsaspQmhCJ40WY1h/pyAlm0gnxOt9l/qc\n\tzHaTUBXCnFF6ttHLkoN0GJi8qF5wSxZyoBNbT+VEltcOZ3EKhzveUBkzwTL4Td6khAtH\n\tKECg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"lGWKN/pY\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=oCovsv3VFF1beHyZ5aPXj8YqDmLQsuqKHjhWl1wvOrc=;\n\tb=gpk4Cmrx5MLjW/I4AbFdZ02Sp39mftDxjQplf3ueZTQoaEbipnfkeKk9X9Gaf5wDPj\n\tVXfYZttU5jQNARfEUlIBKozz/KA0ORmRW7hJ68Tr3Xx0yfZX58AENBt0F/sImcncGuc7\n\tDbE3pY/hHNiWduCi0/F8BnCSp+NYZKnQZGuhBxkhCqcAZJpnxGA0HnywKmBe3MfkmxKB\n\tGbQQykVcHXf2+ndzksuXH4UvLzZSGG96F9+5WoWCvgPyZ60kpVAxK9jASt18Z58QVXj/\n\txgF84nFNTXqhS6/dTbnD51MD2/29x7wzV/9qxCqXZ/x/eB0Ohtr0GY2HkEVJxke+hkF2\n\tM07w==", "X-Gm-Message-State": "AJIora8w7cQczDYwxCEUCeIgaMCEMD+HmcCS/yL4SONvZKTx9sZ8N69N\n\tROWVPm2ErjGE4cM2AlP0MhfhVB1BaIAWFA==", "X-Google-Smtp-Source": "AGRyM1sXuL+Yy/O43aosiDKPvuE6EBwMcboL27q5Yx/aLDN1ORH/KWy90tDzlT63frWWo4a918PhHA==", "X-Received": "by 2002:a17:907:7fa5:b0:711:c8e2:2f4c with SMTP id\n\tqk37-20020a1709077fa500b00711c8e22f4cmr9599427ejc.49.1655476559291; \n\tFri, 17 Jun 2022 07:35:59 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 17 Jun 2022 16:35:47 +0200", "Message-Id": "<20220617143549.35442-2-dse@thaumatec.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220617143549.35442-1-dse@thaumatec.com>", "References": "<20220617143549.35442-1-dse@thaumatec.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/3] Documentation: Add the missing\n\tconst to the example code", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Daniel Semkowicz via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Daniel Semkowicz <dse@thaumatec.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Request::BufferMap key type is now const\n\nSigned-off-by: Daniel Semkowicz <dse@thaumatec.com>\n---\n Documentation/guides/application-developer.rst | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst\nindex 8d12a208..6ab8b7e5 100644\n--- a/Documentation/guides/application-developer.rst\n+++ b/Documentation/guides/application-developer.rst\n@@ -410,7 +410,7 @@ images.\n \n .. code:: cpp\n \n- const std::map<Stream *, FrameBuffer *> &buffers = request->buffers();\n+ const std::map<const Stream *, FrameBuffer *> &buffers = request->buffers();\n \n Iterating through the map allows applications to inspect each completed buffer\n in this request, and access the metadata associated to each frame.\n@@ -518,7 +518,7 @@ and queue all the previously created requests.\n \n camera->start();\n for (std::unique_ptr<Request> &request : requests)\n- camera->queueRequest(request.get());\n+ camera->queueRequest(request.get());\n \n Start an event loop\n ~~~~~~~~~~~~~~~~~~~\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }