Patch Detail
Show a patch.
GET /api/1.1/patches/16258/?format=api
{ "id": 16258, "url": "https://patchwork.libcamera.org/api/1.1/patches/16258/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16258/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220617092315.120781-2-fsylvestre@baylibre.com>", "date": "2022-06-17T09:23:11", "name": "[libcamera-devel,v3,1/5] pipeline: rkisp1: Support IPA tuning file", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e9c751d5924aa1802f6ae44bf673378af071c4f5", "submitter": { "id": 123, "url": "https://patchwork.libcamera.org/api/1.1/people/123/?format=api", "name": "Florian Sylvestre", "email": "fsylvestre@baylibre.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16258/mbox/", "series": [ { "id": 3186, "url": "https://patchwork.libcamera.org/api/1.1/series/3186/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3186", "date": "2022-06-17T09:23:10", "name": "Add tuning file support for rkisp1 blc algo", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3186/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16258/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16258/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12BEDC3273\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Jun 2022 09:23:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6D916563B;\n\tFri, 17 Jun 2022 11:23:50 +0200 (CEST)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25E0D60471\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jun 2022 11:23:49 +0200 (CEST)", "by mail-wr1-x42b.google.com with SMTP id s1so4964723wra.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Jun 2022 02:23:49 -0700 (PDT)", "from BL087.. ([2a01:e34:eea9:e630:4718:73b:d035:3786])\n\tby smtp.gmail.com with ESMTPSA id\n\th81-20020a1c2154000000b0039c41686421sm7962328wmh.17.2022.06.17.02.23.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Jun 2022 02:23:48 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655457830;\n\tbh=DjyNdnTjUnAW1opZVIE82vr1Mv6cwC8MwFO6kdAKzKg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=WwphsiiyZOljfH2s7VkoBn5n60NQWwm4sE5IocvIpQMwHXmxiK3E6dhE+3om0nKyk\n\tz1zf3OjF8qgcS2lg0vBhMCwNDVsZvVJmp6yS9On9oetsg3Awyz7C85af/n1AWswK+g\n\tLGXjms2iV4cC9Y6xwtnttNk44dPQVfZ67woLsjg+st2yNwd1eaHLD7oVHqEewF0qPD\n\thLAduombWlBYNkcdbXyamREb007zq7XeAuhAthGrMk85t0tdCjL2EDGq3dFJz2G5qR\n\tkOycmWjLJMV9WZ/FKYVsZQ+JSf8cY90RNLHPpQFctY1ZSB7dw8NvnsFgmiouZv/D2g\n\t1zYLcKSGDawJw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MfOFzFspTP5zz9WTQrdkPOXwqbKdm9Kl7i0KNHA6q+0=;\n\tb=7vzgEbMA9aIeBJ2W8WX/4KGUVQFeNl5o6SgYHlzvZIE0+eJUm4vPFsxFyICFBw6yx8\n\tdeTt6YOheeLLpi0jdjcFiACm5X+//JDLLDtYn8VWzEaNAWWcS4A1MXtXzQMGxvvRkHZm\n\tPJnT3ZaF/7HMivLK6bbgSCU+3hvyJ2ESCPwz46HydpBVkEPWOt2SnQjbC926Bnu6SAdc\n\tZ/8a1SpTuhpB4aLQRZY33fGMOCLxDJso+5IV0nYHIWCumaFFi8447lbOUXOwIN5JmrEM\n\tn/gJZbX64GKT6JI9A/eelsP2tXKVrTnpmr2oXUcWaEqnHerggeHANvBhqtIp4GEUzFYz\n\tNnWg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"7vzgEbMA\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MfOFzFspTP5zz9WTQrdkPOXwqbKdm9Kl7i0KNHA6q+0=;\n\tb=xBWFQPIk6mnUr21Umz0LNPk/IAu9Au5DXYv76wkILy1sWxMwA8lNnI56NdDr7QxfE3\n\thQz8dq8wGDs8314Q4pfFw4LSoqXJYOOjdKT5162jXME5tHuS0eqc8jkujFiwbY0etq2D\n\tDq04ab18ArLJOUdW5yvjIvEiJxstf43tnkOxO3X6I8oZWmgpOBlW42O0ZQw5OayJ61bI\n\tlwxOZtnIWkEUylN44FIcbfeaSS6qHheVuyPiWZr+mks3rpnSm0c+oeVEd2wWBcMkfIGm\n\tHj0t6qMUKJPEXeptxJ29H9fstL/qq4RdM5VZJAUrHDjCJMtP+067qKwipSDbMIfDBYAy\n\tRvYA==", "X-Gm-Message-State": "AJIora/0Uhl1iRwEWG15l8E7v5Xb/Q/FeEr4Il+N5zLQWDUo2O37k5QM\n\tKFZDsmf7OYTsWJZ8PiP04VZDGKKXvuZ7Jg==", "X-Google-Smtp-Source": "AGRyM1snul7ONZLTTguMSftT3GIUlC1AvEkmR18IF8IRO8dCfw5RzCekKEUIJHPPwfr8BGhA7xCsMw==", "X-Received": "by 2002:a5d:6dae:0:b0:218:4a3a:3623 with SMTP id\n\tu14-20020a5d6dae000000b002184a3a3623mr8523455wrs.524.1655457828487; \n\tFri, 17 Jun 2022 02:23:48 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 17 Jun 2022 11:23:11 +0200", "Message-Id": "<20220617092315.120781-2-fsylvestre@baylibre.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220617092315.120781-1-fsylvestre@baylibre.com>", "References": "<20220617092315.120781-1-fsylvestre@baylibre.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 1/5] pipeline: rkisp1: Support IPA\n\ttuning file", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Florian Sylvestre via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Florian Sylvestre <fsylvestre@baylibre.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Allow the usage of a YAML IPA tuning file that is either defined by\nthe sensor name (sensor_name.yaml) or defined by\nLIBCAMERA_RKISP1_TUNING_FILE environment variable.\n\nSigned-off-by: Florian Sylvestre <fsylvestre@baylibre.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 4b3d2cf7..59ded513 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -322,7 +322,18 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n \tipa_->paramsBufferReady.connect(this, &RkISP1CameraData::paramFilled);\n \tipa_->metadataReady.connect(this, &RkISP1CameraData::metadataReady);\n \n-\tint ret = ipa_->init(IPASettings{ \"\", sensor_->model() }, hwRevision);\n+\t/*\n+\t * The API tuning file is made from the sensor name unless\n+\t * the environment variable overrides it.\n+\t */\n+\tstd::string ipaTunigFile;\n+\tchar const *configFromEnv = utils::secure_getenv(\"LIBCAMERA_RKISP1_TUNING_FILE\");\n+\tif (!configFromEnv || *configFromEnv == '\\0')\n+\t\tipaTunigFile = ipa_->configurationFile(sensor_->model() + \".yaml\");\n+\telse\n+\t\tipaTunigFile = std::string(configFromEnv);\n+\n+\tint ret = ipa_->init({ ipaTunigFile, sensor_->model() }, hwRevision);\n \tif (ret < 0) {\n \t\tLOG(RkISP1, Error) << \"IPA initialization failure\";\n \t\treturn ret;\n", "prefixes": [ "libcamera-devel", "v3", "1/5" ] }