Patch Detail
Show a patch.
GET /api/1.1/patches/16202/?format=api
{ "id": 16202, "url": "https://patchwork.libcamera.org/api/1.1/patches/16202/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16202/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220612152311.8408-5-laurent.pinchart@ideasonboard.com>", "date": "2022-06-12T15:23:10", "name": "[libcamera-devel,v2,4/5] libcamera: pipeline: simple: Store sensor resolution in configuration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "04a9757e7e94b36635a8d216ab50f2af3db92a02", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16202/mbox/", "series": [ { "id": 3170, "url": "https://patchwork.libcamera.org/api/1.1/series/3170/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3170", "date": "2022-06-12T15:23:06", "name": "libcamera: pipeline: simple: Support scaling on the camea sensor", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3170/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16202/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16202/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81A27C3277\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 12 Jun 2022 15:23:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EBD065646;\n\tSun, 12 Jun 2022 17:23:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3936165633\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 12 Jun 2022 17:23:26 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B615EDFC;\n\tSun, 12 Jun 2022 17:23:25 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1655047409;\n\tbh=r+X7VYZUsM/hMS4pjICoikt95yUzv6PyR6QOHrIcKIg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XNCzIkgGcqCQNVPLMqXTtjBZK8mwVZRG6zZ97Fb/xK6c2i9g/1w5TPXRXGDEsi7o4\n\t8sdTp7Ww0otOz0yd14R7HCIFhlnfOHjM+8JozmMgO7Fa5ORZuzvgV+4/pCEyFsfYBZ\n\tGxVf4TlOFLQrtGJGKUARnvpC/o2mgEVVQ3u36bgZwGQfeNl1xtK26yQQAFeD03eX1i\n\tFl5WDayblMk4N2NEaxDzIgTcx/dFUSH9GMwjNxWfeNYsc5xJQIT/B+eGXLcUa39pZ4\n\ta7O9GFW8yTnd3h9AiJAlvvWYBDXC0enl5NdJ9ueUWSA2mLk2BuuuEI0qgIj1mTFh/8\n\tMOper4bAtin2w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1655047406;\n\tbh=r+X7VYZUsM/hMS4pjICoikt95yUzv6PyR6QOHrIcKIg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PF5aME+00CGVyfyvLuY2vKvwBnmUrPYdtEUKAyinN8Xhw3F5ipmoNe670LA/XnDQs\n\tNYiAGovZkLXQDFV2xgepCNFViEHRQaIvTEbB104wyGg1xgWTN475QUsCJqQgafKDmp\n\tH3BiEogjOco2W0QH7dWtLjYojMti0qFrFGeivLos=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PF5aME+0\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 12 Jun 2022 18:23:10 +0300", "Message-Id": "<20220612152311.8408-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>", "References": "<20220612152311.8408-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/5] libcamera: pipeline: simple: Store\n\tsensor resolution in configuration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tBenjamin Schaaf <ben.schaaf@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When enumerating the supported configurations, store the corresponding\nsensor resolution in the SimpleCameraData::Configuration structure and\nuse it when configuring the camera, instead of hardcoding the sensor\nfull resolution. This prepares for support of downscaling in the camera\nsensor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 3c90bdec60e0..8c48162d7ff0 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -225,6 +225,7 @@ public:\n \n \tstruct Configuration {\n \t\tuint32_t code;\n+\t\tSize sensorSize;\n \t\tPixelFormat captureFormat;\n \t\tSize captureSize;\n \t\tstd::vector<PixelFormat> outputFormats;\n@@ -542,6 +543,7 @@ void SimpleCameraData::tryPipeline(unsigned int code, const Size &size)\n \n \t\tConfiguration config;\n \t\tconfig.code = code;\n+\t\tconfig.sensorSize = size;\n \t\tconfig.captureFormat = pixelFormat;\n \t\tconfig.captureSize = format.size;\n \n@@ -943,7 +945,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tconst SimpleCameraData::Configuration *pipeConfig = config->pipeConfig();\n \tV4L2SubdeviceFormat format{};\n \tformat.mbus_code = pipeConfig->code;\n-\tformat.size = data->sensor_->resolution();\n+\tformat.size = pipeConfig->sensorSize;\n \n \tret = data->setupFormats(&format, V4L2Subdevice::ActiveFormat);\n \tif (ret < 0)\n", "prefixes": [ "libcamera-devel", "v2", "4/5" ] }