Patch Detail
Show a patch.
GET /api/1.1/patches/16174/?format=api
{ "id": 16174, "url": "https://patchwork.libcamera.org/api/1.1/patches/16174/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16174/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220604211148.188421-5-Rauch.Christian@gmx.de>", "date": "2022-06-04T21:11:47", "name": "[libcamera-devel,v7,4/5] libcamera: controls: Generate fixed- and variable-sized Span Controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "abbda95a9e49e6401aeb5995bb1b3e26a6a73a0c", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/1.1/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16174/mbox/", "series": [ { "id": 3162, "url": "https://patchwork.libcamera.org/api/1.1/series/3162/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3162", "date": "2022-06-04T21:11:43", "name": "generate and use fixed-sized Span Control types", "version": 7, "mbox": "https://patchwork.libcamera.org/series/3162/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16174/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16174/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B751C3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jun 2022 21:11:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1860F6563E;\n\tSat, 4 Jun 2022 23:11:56 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9ABE165635\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jun 2022 23:11:52 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1M3DJv-1nwDcD14fN-003fSg; Sat, 04 Jun 2022 23:11:52 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654377116;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ka/tYQclf2A2jdAKscy0PiwdhkghDk5xrMBu6c0qKIXIkJsB7YNOeYwX11EVcFDJh\n\ttR3qaw3HRiS/LgN3ja+259JQhOTzGlmRU9dL6io+h7lSxrTEm7InsPPy7xakrxPkxh\n\tsC5W6jFUsFmckWq1HZlVxEIo/9/t98zjo5p2IW1jLbEtuklM9p44ehKKafNVRP4PdN\n\tSHZNmCGgm9ExASxTuQcONHhIlHg6Y97dq4EzQAML5hz7zKTzldXU10qCwE5HsOMGR7\n\t2sVPi6CYlyL1ZZwy9k0w2J5lg/aM838XQWFLH+s+4A9jbe1DhFSXvBO0P4Hg8NAph7\n\tYzJzQALagj24A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654377112;\n\tbh=UqwmX7+yMaOqSyR96KduBQpxFaCTOfHvdMO6MxtFX8g=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=G1vPW9uvo4WlLg91e50rjghkZCQbhTrnYSUPgBCL+TJF2dfMqWnry0eDyyB02FSDm\n\tIjoUsAGzem60fh/fLvALvb2gzGuzhgo20eqO7CcY+GNI/iPi0PDh7naMvm2rfLQrvS\n\tYZr+Ro1X5witO9AR0kyPJ5vDnCq+1WG9u75OK5Qs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"G1vPW9uv\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jun 2022 22:11:47 +0100", "Message-Id": "<20220604211148.188421-5-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220604211148.188421-1-Rauch.Christian@gmx.de>", "References": "<20220604211148.188421-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:dj24ZkDnChGySjTVCWFewBr46xBhIq3fWed+/gV5Rub+SxYQ5rC\n\tw1l0qAFh6z0MGQ2OagmM4T8HkN8sOfVU6dtEu7VksiSaL8qR8AMha7OAXRpq4AMUrt18BSm\n\tbNhw29pllit/R2zNfMPQMu8ycHBC2e2YxoPCGRHbXsx9HcM49Naey8+cwMti11/eLKbSuZD\n\t0Wuva4jSGwSPa6ZL30bJQ==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:VmKbKDsj+zA=:f3f1lyiDzRx70Ve2Ab+ffs\n\tryB69Jb9L37EHUZU+peEHbRKEHzsncgI1I2/K9sDNI6fAttuoKhskFe2DDPVJNPMVT2qCBplV\n\tHoK7xKs653xTwWBUxo+UihSGeNalxwnVX/cmynATOVwEHws2lNRGKCiDRaF6+rMH99id0OvOb\n\tiVh9qrzmIW68QZMq5UJZ4Kx8Ayh8LgLQYUGMH74niZrZoUwJ3NhFqJdPj8NgvE6vihS/EIql+\n\t2Z1jizmjAE6QKT/7m1XNrt6Rq9MC1YpyVp4+N9RD15BzWSplI8RfM6PWkHh3jC4v9eBk0BE33\n\tssDjW+F4Akzl9nT+Q7NQbr6Wq6/E9KED2bb8tIedqhXOtQKlS0PWgAuy9FmcEta0Rug0eM7J7\n\t3S1aLAclavC3Ovb/S7pq2hOxPy0Wj105On6nHDv/DkIbfq2nYKrOfFKZqmJTtXmgWChXORKhE\n\tMXlbCLQ60EffWPmuRWAEKW9zJr0AH+T4UyLxR3RF89O34fbc4xAqoXWB0NXTDyF8CjwvvohWW\n\tMKzD4VYfhl5WDSA9Re5/y78dSCxGcYhGhOvTTaIPYh8QVj93ZwDWqqTzW9Urkt7As37EUsISk\n\teAeJGv+N+rDgnywv/ktiV5Odcrizv6cDAiKCJC5ZnOSTFap0HCElKzpxvHBMCl4BHWz33nMzp\n\tDQLUe0ZJRlEk+qLVvm5K21On5Pa3e3xlXsBx62egOuv0QSj+ljFbPk3q2KcfTtv4r6WH+K8AV\n\tPO0T4pPgE2COH0pNxqoIYQ0cNM2Zhwik1uuPsNA9ZAz46bacVlv5cPxWsYyGq7dmMHf/yKEc/\n\tWyZvAPPOyUYtpoC6rJV/LWsAGfXD2Q7EQ+0W4Bn2AE8eWonhgW95SDjs+VFSLYKL011A1iNdN\n\tLFBWd9edEZE0gR9rWzmPfUcqhQG+OYZjgo5o/uG9M3qTWyLEW4ehsfzA6ri+IcaRFmQJ/8Z+c\n\t32ojBRBhVpt4mIw+sWRI9xAX9UzcwIQQMKaIbNBhjtDjeQlZC40o9jeTd8iASss8gAgJrdkUv\n\tKE7854w0RhJCOX7YyYU1LPcTqj8VoHAawxGh9mAoOJ0SNZyPHVy00D0lIIR1ysfnlQEpQvQ3Z\n\tT8DAcVBAtSQHSdciIzvGmAA37wN4Z3oFxc/maNI2nI2gzoEPIJu9HauWQ==", "Subject": "[libcamera-devel] [PATCH v7 4/5] libcamera: controls: Generate\n\tfixed- and variable-sized Span Controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This defines Controls with a 'size' as either variable-sized Span<T> or as\nfixed-sized Span<T,N>.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n utils/gen-controls.py | 32 ++++++++++++++++++++++----------\n 1 file changed, 22 insertions(+), 10 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 3f99b5e2..46ba4394 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -7,6 +7,8 @@\n # gen-controls.py - Generate control definitions from YAML\n\n import argparse\n+from functools import reduce\n+import operator\n import string\n import sys\n import yaml\n@@ -22,6 +24,24 @@ def format_description(description):\n return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n\n\n+def get_ctrl_type(ctrl):\n+ ctrl_type = ctrl['type']\n+ ctrl_size_arr = ctrl.get('size')\n+\n+ if ctrl_type == 'string':\n+ return 'std::string'\n+ elif ctrl_size_arr is not None:\n+ if len(ctrl_size_arr) > 0:\n+ # fixed-sized Span\n+ ctrl_span_size = reduce(operator.mul, ctrl_size_arr)\n+ return f\"Span<const {ctrl_type}, {ctrl_span_size}>\"\n+ else:\n+ # variable-sized Span\n+ return f\"Span<const {ctrl_type}>\"\n+ else:\n+ return ctrl_type\n+\n+\n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n * \\\\enum ${name}Enum\n@@ -50,11 +70,7 @@ ${description}\n name, ctrl = ctrl.popitem()\n id_name = snake_case(name).upper()\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span<const %s>' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n@@ -135,11 +151,7 @@ def generate_h(controls):\n\n ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n\n- ctrl_type = ctrl['type']\n- if ctrl_type == 'string':\n- ctrl_type = 'std::string'\n- elif ctrl.get('size'):\n- ctrl_type = 'Span<const %s>' % ctrl_type\n+ ctrl_type = get_ctrl_type(ctrl)\n\n info = {\n 'name': name,\n", "prefixes": [ "libcamera-devel", "v7", "4/5" ] }