Patch Detail
Show a patch.
GET /api/1.1/patches/1617/?format=api
{ "id": 1617, "url": "https://patchwork.libcamera.org/api/1.1/patches/1617/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1617/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190704145942.17879-5-kieran.bingham@ideasonboard.com>", "date": "2019-07-04T14:59:40", "name": "[libcamera-devel,v4,4/6] qcam: Add the version string to the title", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5925a128b0de407de6078f702556c27c4f4234a9", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1617/mbox/", "series": [ { "id": 405, "url": "https://patchwork.libcamera.org/api/1.1/series/405/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=405", "date": "2019-07-04T14:59:36", "name": "Automatic Version Generation ++", "version": 4, "mbox": "https://patchwork.libcamera.org/series/405/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1617/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1617/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90E7C6156A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jul 2019 16:59:47 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E1D824B;\n\tThu, 4 Jul 2019 16:59:47 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562252387;\n\tbh=+toJ6tFIT3NmctEyT3PS89aPx4+CdywtxJrmszY7Znw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GUrr5jDgOUhPoWjGWZ9L0fk7SwOghMuRZybwpDPcTlQstDHSPAvLm9rrBBBCKEAtD\n\tHyF8SRax49Ukr1olTAjB2ujPUXtdGkw/dTwnCGg76V2Ng/63XPa08duCcPg7iqEH0w\n\tvXGY5QV/jxU18nPkeqrxrJPNjrsc8Rlvtreow9YU=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 4 Jul 2019 15:59:40 +0100", "Message-Id": "<20190704145942.17879-5-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190704145942.17879-1-kieran.bingham@ideasonboard.com>", "References": "<20190704145942.17879-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 4/6] qcam: Add the version string to\n\tthe title", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 04 Jul 2019 14:59:48 -0000" }, "content": "Provide the version string reported by the libcamera library on the qcam\ntest utility.\n\nThis helps confirm the exact version of the library that is being used\nwhile testing.\n\nThe version string is stored in the MainWindow so that it can be reused\nwithout reconstructing.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 4 ++++\n src/qcam/main_window.h | 1 +\n 2 files changed, 5 insertions(+)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 0f737d852960..d61369109d66 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -14,6 +14,7 @@\n #include <QTimer>\n \n #include <libcamera/camera_manager.h>\n+#include <libcamera/version.h>\n \n #include \"main_window.h\"\n #include \"viewfinder.h\"\n@@ -25,6 +26,9 @@ MainWindow::MainWindow(const OptionsParser::Options &options)\n {\n \tint ret;\n \n+\ttitle_ = \"QCam \" + QString::fromStdString(libcamera::version);\n+\tsetWindowTitle(title_);\n+\n \tviewfinder_ = new ViewFinder(this);\n \tsetCentralWidget(viewfinder_);\n \tviewfinder_->setFixedSize(500, 500);\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 345bdaaed354..46a494a9d783 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -42,6 +42,7 @@ private:\n \t\t\t const std::map<Stream *, Buffer *> &buffers);\n \tint display(Buffer *buffer);\n \n+\tQString title_;\n \tconst OptionsParser::Options &options_;\n \n \tstd::shared_ptr<Camera> camera_;\n", "prefixes": [ "libcamera-devel", "v4", "4/6" ] }