Patch Detail
Show a patch.
GET /api/1.1/patches/16165/?format=api
{ "id": 16165, "url": "https://patchwork.libcamera.org/api/1.1/patches/16165/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16165/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220604185939.29163-11-laurent.pinchart@ideasonboard.com>", "date": "2022-06-04T18:59:35", "name": "[libcamera-devel,RFC,v2,10/14] libcamera: yaml_parser: Remove memberNames() function", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "7600a1c7ba5d1ca51904d2c2c5d27704ede9da7f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16165/mbox/", "series": [ { "id": 3161, "url": "https://patchwork.libcamera.org/api/1.1/series/3161/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3161", "date": "2022-06-04T18:59:25", "name": "Replace boost JSON parser with libyaml in Raspberry Pi IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3161/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16165/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16165/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEEF9C327A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jun 2022 19:00:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 070626564C;\n\tSat, 4 Jun 2022 21:00:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C154A65639\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jun 2022 21:00:14 +0200 (CEST)", "from pendragon.ideasonboard.com (85-76-79-203-nat.elisa-mobile.fi\n\t[85.76.79.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 000BD6D4;\n\tSat, 4 Jun 2022 21:00:12 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654369216;\n\tbh=v1mnG3JXPIC1r12cJ7UCp9XicED3HrFTGWy07p9m4bQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=uB0K26aBQZJI+0J1oKYBrrcaTkhLIFFLLenA+kRJxX5+U7tStIfZ7AGmYHkveg4fZ\n\tFhugbqeiPHIhhgJyJaOD8uRafEVjr9c7jTTViBAXMsW+QkcoKEiL1MflD++QfHgsc9\n\tM+YftH9SIsQ54ni0VlxfMt57sQuXKSzWduz9+l9wMJnYD+OamNBrUD7S81L1D2bYnt\n\tnE71yXQ5qx1Tvv2R4NyBgx3ZeB9ugr3nW9BTGpZ4dj19zWiMWFUPPPgmonJJuWqgY9\n\tovwYGAlTbKnUqKZqdHPPwHwDA8efzuuwArH10bhwq0/timEq83WBM3ZErQFn+yxYbu\n\tQbn7d/O6+Gl/A==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654369214;\n\tbh=v1mnG3JXPIC1r12cJ7UCp9XicED3HrFTGWy07p9m4bQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JNa1WUlgMeAWiTOJ19lyXn30tpoMc2uEV8vW9ZWOFqPU0+72QU34vYMQcsovTUo3V\n\tqmIeoiYAmmvFUMkRWSXBksiVv8WkH/C6BVbZGW2QBEPeTgSV+LJxzDxYCkN9C0u7kO\n\tRaOq45sDpQcg/zTXj6OU0ScqSON69X9DCB98bBbs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"JNa1WUlg\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jun 2022 21:59:35 +0300", "Message-Id": "<20220604185939.29163-11-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>", "References": "<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 10/14] libcamera: yaml_parser:\n\tRemove memberNames() function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that YamlObject supports iteration, the memberNames() function isn't\nuseful anymore as it can be implemented using utils::map_keys() if\nreally needed. Drop it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/internal/yaml_parser.h | 1 -\n src/libcamera/yaml_parser.cpp | 22 ----------------------\n test/yaml-parser.cpp | 9 ---------\n 3 files changed, 32 deletions(-)", "diff": "diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h\nindex e142cde0fb6f..d0ddb5f682b2 100644\n--- a/include/libcamera/internal/yaml_parser.h\n+++ b/include/libcamera/internal/yaml_parser.h\n@@ -179,7 +179,6 @@ public:\n \n \tbool contains(const std::string &key) const;\n \tconst YamlObject &operator[](const std::string &key) const;\n-\tstd::vector<std::string> memberNames() const;\n \n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(YamlObject)\ndiff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex 9cdb370d0f2e..97104ac118a8 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -332,28 +332,6 @@ bool YamlObject::contains(const std::string &key) const\n \treturn true;\n }\n \n-/**\n- * \\fn YamlObject::memberNames()\n- * \\brief Retrieve all member names of the dictionary\n- *\n- * This function retrieve member names of a YamlObject. Only YamlObject\n- * instances of Dictionary type associate elements with names, calling this\n- * function on other types of instances is invalid and results in undefined\n- * behaviour.\n- *\n- * \\todo Replace this function with an iterator-based API\n- *\n- * \\return A vector of string as the member names\n- */\n-std::vector<std::string> YamlObject::memberNames() const\n-{\n-\tstd::vector<std::string> memberNames;\n-\tfor (auto &[key, _] : list_)\n-\t\tmemberNames.push_back(key);\n-\n-\treturn memberNames;\n-}\n-\n /**\n * \\fn YamlObject::operator[](const std::string &key) const\n * \\brief Retrieve a member by name from the dictionary\ndiff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp\nindex 6dfec49d6be0..bd92869a4cb3 100644\n--- a/test/yaml-parser.cpp\n+++ b/test/yaml-parser.cpp\n@@ -489,15 +489,6 @@ protected:\n \t\t\ti++;\n \t\t}\n \n-\t\tauto memeberNames = dictObj.memberNames();\n-\n-\t\tif (memeberNames[0] != \"a\" ||\n-\t\t memeberNames[1] != \"c\" ||\n-\t\t memeberNames[2] != \"b\") {\n-\t\t\tcerr << \"Dictionary object fail to parse member names\" << std::endl;\n-\t\t\treturn TestFail;\n-\t\t}\n-\n \t\t/* Test leveled objects */\n \t\tauto &level1Obj = (*root)[\"level1\"];\n \n", "prefixes": [ "libcamera-devel", "RFC", "v2", "10/14" ] }