Patch Detail
Show a patch.
GET /api/1.1/patches/16164/?format=api
{ "id": 16164, "url": "https://patchwork.libcamera.org/api/1.1/patches/16164/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16164/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220604185939.29163-10-laurent.pinchart@ideasonboard.com>", "date": "2022-06-04T18:59:34", "name": "[libcamera-devel,RFC,v2,09/14] android: Use the YamlObject iterator API", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "58bb05a9959a9a2cb366acb133b71e06cd8fea75", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16164/mbox/", "series": [ { "id": 3161, "url": "https://patchwork.libcamera.org/api/1.1/series/3161/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3161", "date": "2022-06-04T18:59:25", "name": "Replace boost JSON parser with libyaml in Raspberry Pi IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3161/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16164/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16164/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99255C3279\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 4 Jun 2022 19:00:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1ECAF65646;\n\tSat, 4 Jun 2022 21:00:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D3ED633A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jun 2022 21:00:12 +0200 (CEST)", "from pendragon.ideasonboard.com (85-76-79-203-nat.elisa-mobile.fi\n\t[85.76.79.203])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE32BE0F;\n\tSat, 4 Jun 2022 21:00:10 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654369213;\n\tbh=Ic3F3Afbq5cwq4A8ifAQhqKg4w3eXeU4Dm+xJoUklrM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FB0NORvWhjRiUZoCQ9R8TgS+RJwPqkhkMROjEagI8h17cL50HO1eskrDbrhM54/Sp\n\t9zoKulddGCeSwzV2tvENtm+KfoW6X9Bw5foRKtsqs2UApMPjF7vZVr/9YurPN0ANOT\n\tinw2C4wgukqrQctFIvgrHpmqkyZeMoWhBVLk5JRCT0QQ9tT2ajAGTi0SXSg/A5Wdy3\n\tZdFR0+ZQaSrorwyiuU+129bFxZKjw9el+3SmRifxdYvrV2+TLvtBD+LjeXoxfoXsGp\n\tNYZamgpLrML4B9PvoW7hZ++cFn2m8WpTF1OC8PFXNspLRb7ORcPCazAFWqvW5vGVHm\n\tHzk75ml6LUWKw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1654369212;\n\tbh=Ic3F3Afbq5cwq4A8ifAQhqKg4w3eXeU4Dm+xJoUklrM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CoW4zHeby2LL1j+tOBPhLCQabDG+zaMfnBKczgXxSguih2ndGMWafq5Pc1JuBPuly\n\tOJIESbKLbCKzzZ4Jza+bQouPD/eRB9VExzBbxZPKEwqaXo4dvV9BP+uoIiPBrlKKvS\n\tqI7dIxkdJyVFBD9AplI/b2kzp8R3O3vpuGFZcxKA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CoW4zHeb\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 4 Jun 2022 21:59:34 +0300", "Message-Id": "<20220604185939.29163-10-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>", "References": "<20220604185939.29163-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 09/14] android: Use the YamlObject\n\titerator API", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace usage of YamlObject::memberNames() with the more efficient\niterator API.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_hal_config.cpp | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_hal_config.cpp b/src/android/camera_hal_config.cpp\nindex ac484b8df1bd..bacfe4b9c505 100644\n--- a/src/android/camera_hal_config.cpp\n+++ b/src/android/camera_hal_config.cpp\n@@ -82,10 +82,8 @@ int CameraHalConfig::Private::parseConfigFile(File &file,\n \tif (!yamlObjectCameras.isDictionary())\n \t\treturn -EINVAL;\n \n-\tstd::vector<std::string> cameraIds = yamlObjectCameras.memberNames();\n-\tfor (const std::string &cameraId : cameraIds) {\n-\t\tif (parseCameraConfigData(cameraId,\n-\t\t\t\t\t yamlObjectCameras[cameraId]))\n+\tfor (const auto &[cameraId, configData] : yamlObjectCameras.asDict()) {\n+\t\tif (parseCameraConfigData(cameraId, configData))\n \t\t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "libcamera-devel", "RFC", "v2", "09/14" ] }