Patch Detail
Show a patch.
GET /api/1.1/patches/1611/?format=api
{ "id": 1611, "url": "https://patchwork.libcamera.org/api/1.1/patches/1611/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1611/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190704130347.9372-9-kieran.bingham@ideasonboard.com>", "date": "2019-07-04T13:03:46", "name": "[libcamera-devel,v2,4/5] qcam: Add the version string to the title", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5925a128b0de407de6078f702556c27c4f4234a9", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1611/mbox/", "series": [ { "id": 404, "url": "https://patchwork.libcamera.org/api/1.1/series/404/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=404", "date": "2019-07-04T13:03:46", "name": null, "version": 2, "mbox": "https://patchwork.libcamera.org/series/404/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1611/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1611/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 864716156E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Jul 2019 15:03:54 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D4F12AF;\n\tThu, 4 Jul 2019 15:03:54 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562245434;\n\tbh=9jt9ECg5d8u9WDVYRjR6zfsO3RO9ryAkDlqqRP2IOP4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=f88vpU1qzV19UXbtJ5MYhMoZoCf1u3EId16sHkGiYlbEd5kjbAymNV8bVBonpJ9uD\n\t8zXiO5NN+fLf3qxHHw8rksY+Qbh6EHUKHYM7Skvo/TWJx/sH6SiNGy91PWECffH2ar\n\tF5beSIyx/eFllBmnS+G7JPU5DTMlRsqxVdWcAyIA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 4 Jul 2019 14:03:46 +0100", "Message-Id": "<20190704130347.9372-9-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190704130347.9372-1-kieran.bingham@ideasonboard.com>", "References": "<20190704130347.9372-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 4/5] qcam: Add the version string to\n\tthe title", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 04 Jul 2019 13:03:55 -0000" }, "content": "Provide the version string reported by the libcamera library on the qcam\ntest utility.\n\nThis helps confirm the exact version of the library that is being used\nwhile testing.\n\nThe version string is stored in the MainWindow so that it can be reused\nwithout reconstructing.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/main_window.cpp | 4 ++++\n src/qcam/main_window.h | 1 +\n 2 files changed, 5 insertions(+)", "diff": "diff --git a/src/qcam/main_window.cpp b/src/qcam/main_window.cpp\nindex 0f737d852960..d61369109d66 100644\n--- a/src/qcam/main_window.cpp\n+++ b/src/qcam/main_window.cpp\n@@ -14,6 +14,7 @@\n #include <QTimer>\n \n #include <libcamera/camera_manager.h>\n+#include <libcamera/version.h>\n \n #include \"main_window.h\"\n #include \"viewfinder.h\"\n@@ -25,6 +26,9 @@ MainWindow::MainWindow(const OptionsParser::Options &options)\n {\n \tint ret;\n \n+\ttitle_ = \"QCam \" + QString::fromStdString(libcamera::version);\n+\tsetWindowTitle(title_);\n+\n \tviewfinder_ = new ViewFinder(this);\n \tsetCentralWidget(viewfinder_);\n \tviewfinder_->setFixedSize(500, 500);\ndiff --git a/src/qcam/main_window.h b/src/qcam/main_window.h\nindex 345bdaaed354..46a494a9d783 100644\n--- a/src/qcam/main_window.h\n+++ b/src/qcam/main_window.h\n@@ -42,6 +42,7 @@ private:\n \t\t\t const std::map<Stream *, Buffer *> &buffers);\n \tint display(Buffer *buffer);\n \n+\tQString title_;\n \tconst OptionsParser::Options &options_;\n \n \tstd::shared_ptr<Camera> camera_;\n", "prefixes": [ "libcamera-devel", "v2", "4/5" ] }