Patch Detail
Show a patch.
GET /api/1.1/patches/16109/?format=api
{ "id": 16109, "url": "https://patchwork.libcamera.org/api/1.1/patches/16109/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16109/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220530142722.57618-3-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-30T14:27:08", "name": "[libcamera-devel,v4,02/16] py: unittests: Fix test_select()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "89b4c65ef9fc5898242bf33d12eb42412199d910", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16109/mbox/", "series": [ { "id": 3149, "url": "https://patchwork.libcamera.org/api/1.1/series/3149/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3149", "date": "2022-05-30T14:27:06", "name": "More misc Python patches", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3149/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16109/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16109/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D792DC326D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 May 2022 14:27:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FB3B65644;\n\tMon, 30 May 2022 16:27:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4718360411\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 May 2022 16:27:40 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC154E57;\n\tMon, 30 May 2022 16:27:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653920864;\n\tbh=WH3FanN0B7wtHyKVOVazV8b7jBn/0LRb+mJc3K8kM9A=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hzyZOpwHoYYYylz/WBBam5S9DdLRlgp7+laoKs99oUnV8tYZ4WV++cyhTyDWc7g4G\n\tTfs4pnNDFdAmP1r0I2TjHpmhXYROwegJ9qAODMe8cC4j59FyF8IBv0nWHh3FcL+Sd4\n\tIrHPFEcnFa2c5NsfaxA5d43qHPgPSLnUwqczaVTHga5ecp4VUwUsCXL9+KnNjlS9uh\n\tMGrkitctNLr0CxAiyYadTVvsYJlos4dMv+uEjMJHMK2j4spOpuLmj1zORQjqO0WJ4G\n\t+xoOemxX3hUA4dKVyQui6n4yc7qJ11LwXNPilbSv3Hg7Dd17afiTR9oJOBilwmH9ec\n\t9VsR24AJt60KA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653920860;\n\tbh=WH3FanN0B7wtHyKVOVazV8b7jBn/0LRb+mJc3K8kM9A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nfky05hofx59QsDJIDBnXisd7kSrYb+rWxSXAtjkDhmBNG6jy0CZk5Xy6C2Nf8EGl\n\tkRwf2wk98PeGG/0m/DDTRY/DyAJNEi5SMyW9iexitrpWRd0KAEgRSyf88zIOvL4mdb\n\tBjVnIKABLFh3APqhCJ8XbxjNKvqnOLzFWO3gTHwU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nfky05ho\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Mon, 30 May 2022 17:27:08 +0300", "Message-Id": "<20220530142722.57618-3-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220530142722.57618-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220530142722.57618-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 02/16] py: unittests: Fix test_select()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The test_select() currently uses self.assertTrue(len(ready_reqs) > 0) to\nsee that cm.get_ready_requests() returns something. This is not always\nthe case, as there may be two eventfd events queued, and the first call\nto cm.get_ready_requests() returns all the requests, and thus the second\ncall returns none.\n\nRemove the self.assertTrue(len(ready_reqs) > 0) assert.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/py/unittests.py | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 45b35223..33b35a0a 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -287,8 +287,6 @@ class SimpleCaptureMethods(CameraTesterBase):\n \n ready_reqs = cm.get_ready_requests()\n \n- self.assertTrue(len(ready_reqs) > 0)\n-\n reqs += ready_reqs\n \n if len(reqs) == num_bufs:\n", "prefixes": [ "libcamera-devel", "v4", "02/16" ] }