Patch Detail
Show a patch.
GET /api/1.1/patches/16108/?format=api
{ "id": 16108, "url": "https://patchwork.libcamera.org/api/1.1/patches/16108/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16108/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220530142722.57618-2-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-30T14:27:07", "name": "[libcamera-devel,v4,01/16] py: unittests: Fix test_sleep()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "de7668606dba1a62668e0573e2bae3bdf0d539d5", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16108/mbox/", "series": [ { "id": 3149, "url": "https://patchwork.libcamera.org/api/1.1/series/3149/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3149", "date": "2022-05-30T14:27:06", "name": "More misc Python patches", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3149/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16108/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16108/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08FDFC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 May 2022 14:27:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E60A6563F;\n\tMon, 30 May 2022 16:27:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B941F60411\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 May 2022 16:27:39 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 310D3B90;\n\tMon, 30 May 2022 16:27:39 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653920861;\n\tbh=BZb0p4A1aVTXfJycBSMBlwFjjsXco7PjNcFq4WRlQTo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4XthDISsYQzlQ4Dy6aoxBAzT3usIOkCKvChEU2+41LGKUzCDEwoEuq/oVAN7H94X7\n\tuXOcC7mQzA8DeeVCjpip4X1zMwSPU/KmGeJmpH+vEx2st7xGwvi5+kZr5zBioLyg6L\n\t3EQqSTUjd+7EhSSGDuETK3YFURpAOR4hBcOK4ImZsDjKXu8wxxKsH9P9s9LcpV33LM\n\tZnRLfsRhamQsLzWNImytcK7LUHUII+3mojP/Ps3gJ4n4tVcWjyRjT/WIDDwxdii6Yb\n\tAq2ry5+RB5fhxJleVddd4oaIq5gWBq813R3VxR1TvqJlYKmhisENuct+aVJ0LlCwWo\n\tJoNjNVW8aR/sQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653920859;\n\tbh=BZb0p4A1aVTXfJycBSMBlwFjjsXco7PjNcFq4WRlQTo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FvRn04+n5o8xsJnJWoGDaBpPwDnfOfl9+jSqxQ9l2yNb4Ntp+M+6D0OAGgUA9YZo2\n\tvchHFvXDYnStZhoLMvSVUW6tjceEDcmtC75vSh1QD4BIxO1XTnzyJHpG1PHFO55x7Z\n\tQl+LuaxgPpKk5OjBgr+8W936ZcaW5a48yeC0lFHo=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FvRn04+n\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Mon, 30 May 2022 17:27:07 +0300", "Message-Id": "<20220530142722.57618-2-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220530142722.57618-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220530142722.57618-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 01/16] py: unittests: Fix test_sleep()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Waiting for 0.5 secs and expecting that the requests have been completed\nis... bad. Fix the test case by using cam.read_event() as a blocking\nwait, and wait until we have received all the requests that we queued.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/py/unittests.py | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/test/py/unittests.py b/test/py/unittests.py\nindex 426efb06..45b35223 100755\n--- a/test/py/unittests.py\n+++ b/test/py/unittests.py\n@@ -161,7 +161,7 @@ class AllocatorTestMethods(CameraTesterBase):\n \n \n class SimpleCaptureMethods(CameraTesterBase):\n- def test_sleep(self):\n+ def test_blocking(self):\n cm = self.cm\n cam = self.cam\n \n@@ -207,11 +207,17 @@ class SimpleCaptureMethods(CameraTesterBase):\n reqs = None\n gc.collect()\n \n- time.sleep(0.5)\n+ reqs = []\n \n- reqs = cm.get_ready_requests()\n+ while True:\n+ cm.read_event()\n \n- self.assertTrue(len(reqs) == num_bufs)\n+ ready_reqs = cm.get_ready_requests()\n+\n+ reqs += ready_reqs\n+\n+ if len(reqs) == num_bufs:\n+ break\n \n for i, req in enumerate(reqs):\n self.assertTrue(i == req.cookie)\n", "prefixes": [ "libcamera-devel", "v4", "01/16" ] }