Patch Detail
Show a patch.
GET /api/1.1/patches/16100/?format=api
{ "id": 16100, "url": "https://patchwork.libcamera.org/api/1.1/patches/16100/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16100/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220527144447.94891-29-tomi.valkeinen@ideasonboard.com>", "date": "2022-05-27T14:44:45", "name": "[libcamera-devel,v3,28/30] py: examples: Add simple-continuous-capture.py", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6d5670439c5ddc3ca9fa6215f7d4633eeb84eb0c", "submitter": { "id": 109, "url": "https://patchwork.libcamera.org/api/1.1/people/109/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16100/mbox/", "series": [ { "id": 3146, "url": "https://patchwork.libcamera.org/api/1.1/series/3146/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3146", "date": "2022-05-27T14:44:17", "name": "More misc Python patches", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3146/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16100/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16100/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64DBBC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 27 May 2022 14:45:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F430656AE;\n\tFri, 27 May 2022 16:45:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 014F66565F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 27 May 2022 16:45:19 +0200 (CEST)", "from deskari.lan (91-156-85-209.elisa-laajakaista.fi\n\t[91.156.85.209])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6A1AB4D1A;\n\tFri, 27 May 2022 16:45:18 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653662742;\n\tbh=4bUvZI08LJR8WBjJhEchsq9ky0F9ZRthxJqNtX2L1Ag=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oWlTvOo5x2BEQkoSb7yMMoD4AtglG/8Q+5ib6ZSYkmX9xK8iUDRJmyN9KQYeLKBs0\n\t+b6h/ut8aZy+kvXBgfwdHuuqeZ8JK7GHAl9X0GMdZZmavFtb4qBdeIatYhmOkgQzoE\n\tUZMElfXN8F1QzAN8G3xPdlkpMgIkRFLc471fHXZpKWAtjHba4KECcSX1M96HUI6exx\n\tjZNXqGtrzPTTfHlcHe1QP69YIeeMmCR7CfryexJLlIHO7UYPjfRveFtDsDNW7eh49E\n\tkqJBbwMpX6JeNpO8M2cBXeEHPRQ9WonVAA6r5eteQarLFXrLwdh0Du6r+vX+hmwvkW\n\tcNQFcJ+DSfkrg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653662718;\n\tbh=4bUvZI08LJR8WBjJhEchsq9ky0F9ZRthxJqNtX2L1Ag=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YvBrNj83K7gP8nqBN6EaD7WHTnQwJE53SGhSp9dFvoLzaUMDXPyONJ0pOtM06rNsI\n\t/r2TAGfLfeOZyTDYZckR8nH1tU0IOQ6yg4sZSocXtr9FSMluXxcrLc6Ko25eHRjwWG\n\tzohEILLZ0yP09pCzm4FSX1oVjNhChF2GuxH70mqs=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YvBrNj83\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tJacopo Mondi <jacopo@jmondi.org>", "Date": "Fri, 27 May 2022 17:44:45 +0300", "Message-Id": "<20220527144447.94891-29-tomi.valkeinen@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "References": "<20220527144447.94891-1-tomi.valkeinen@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 28/30] py: examples: Add\n\tsimple-continuous-capture.py", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Tomi Valkeinen via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a slightly more complex, and I think a more realistic, example,\nwhere the script reacts to events and re-queues the buffers.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n---\n src/py/examples/simple-continuous-capture.py | 201 +++++++++++++++++++\n 1 file changed, 201 insertions(+)\n create mode 100755 src/py/examples/simple-continuous-capture.py", "diff": "diff --git a/src/py/examples/simple-continuous-capture.py b/src/py/examples/simple-continuous-capture.py\nnew file mode 100755\nindex 00000000..1c4595f6\n--- /dev/null\n+++ b/src/py/examples/simple-continuous-capture.py\n@@ -0,0 +1,201 @@\n+#!/usr/bin/env python3\n+\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright (C) 2022, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>\n+\n+# A simple minimal capture example showing:\n+# - How to setup the camera\n+# - Capture frames using events\n+# - How to requeue requests\n+# - Memory map the frames\n+# - How to stop the camera\n+\n+import argparse\n+import binascii\n+import libcamera as libcam\n+import libcamera.utils\n+import selectors\n+import sys\n+\n+\n+# A simple container class for our objects\n+class CaptureContext:\n+ cm: libcam.CameraManager\n+ cam: libcam.Camera\n+ reqs: list[libcam.Request]\n+ mfbs: dict[libcam.FrameBuffer, libcamera.utils.MappedFrameBuffer]\n+\n+\n+def handle_camera_event(ctx: CaptureContext):\n+ # cm.read_event() will not block here, as we know there is an event to read.\n+ # We have to read the event to clear it.\n+\n+ ctx.cm.read_event()\n+\n+ reqs = ctx.cm.get_ready_requests()\n+\n+ # Process the captured frames\n+\n+ for req in reqs:\n+ handle_request(ctx, req)\n+\n+ return True\n+\n+\n+def handle_request(ctx: CaptureContext, req: libcam.Request):\n+ buffers = req.buffers\n+\n+ assert len(buffers) == 1\n+\n+ # A ready Request could contain multiple buffers if multiple streams\n+ # were being used. Here we know we only have a single stream,\n+ # and we use next(iter()) to get the first and only buffer.\n+\n+ stream, fb = next(iter(buffers.items()))\n+\n+ # Use the MappedFrameBuffer to access the pixel data with CPU. We calculate\n+ # the crc for each plane.\n+\n+ mfb = ctx.mfbs[fb]\n+ crcs = [binascii.crc32(p) for p in mfb.planes]\n+\n+ meta = fb.metadata\n+\n+ print('buf {}, seq {}, bytes {}, CRCs {}'\n+ .format(req.cookie,\n+ meta.sequence,\n+ '/'.join([str(p.bytes_used) for p in meta.planes]),\n+ crcs))\n+\n+ # We want to re-queue the buffer we just handled. Instead of creating\n+ # a new Request, we re-use the old one. We need to call req.reuse()\n+ # to re-initialize the Request before queuing.\n+\n+ req.reuse()\n+ ctx.cam.queue_request(req)\n+\n+\n+def handle_key_event():\n+ sys.stdin.readline()\n+ print('Exiting...')\n+ return False\n+\n+\n+def capture(ctx: CaptureContext):\n+ # Queue the requests to the camera\n+\n+ for req in ctx.reqs:\n+ ret = ctx.cam.queue_request(req)\n+ assert ret == 0\n+\n+ # Use Selector to wait for events from the camera and from the keyboard\n+\n+ sel = selectors.DefaultSelector()\n+ sel.register(ctx.cm.event_fd, selectors.EVENT_READ, lambda: handle_camera_event(ctx))\n+ sel.register(sys.stdin, selectors.EVENT_READ, handle_key_event)\n+\n+ running = True\n+\n+ while running:\n+ events = sel.select()\n+ for key, mask in events:\n+ # If the handler return False, we should exit\n+ if not key.data():\n+ running = False\n+\n+\n+def main():\n+ parser = argparse.ArgumentParser()\n+ parser.add_argument('-c', '--camera', type=str, default='1',\n+ help='Camera index number (starting from 1) or part of the name')\n+ parser.add_argument('-f', '--format', type=str, help='Pixel format')\n+ parser.add_argument('-s', '--size', type=str, help='Size (\"WxH\")')\n+ args = parser.parse_args()\n+\n+ cm = libcam.CameraManager.singleton()\n+\n+ try:\n+ if args.camera.isnumeric():\n+ cam_idx = int(args.camera)\n+ cam = next((cam for i, cam in enumerate(cm.cameras) if i + 1 == cam_idx))\n+ else:\n+ cam = next((cam for cam in cm.cameras if args.camera in cam.id))\n+ except Exception:\n+ print(f'Failed to find camera \"{args.camera}\"')\n+ return -1\n+\n+ # Acquire the camera for our use\n+\n+ ret = cam.acquire()\n+ assert ret == 0\n+\n+ # Configure the camera\n+\n+ cam_config = cam.generate_configuration([libcam.StreamRole.Viewfinder])\n+\n+ stream_config = cam_config.at(0)\n+\n+ if args.format:\n+ fmt = libcam.PixelFormat(args.format)\n+ stream_config.pixel_format = fmt\n+\n+ if args.size:\n+ w, h = [int(v) for v in args.size.split('x')]\n+ stream_config.size = libcam.Size(w, h)\n+\n+ ret = cam.configure(cam_config)\n+ assert ret == 0\n+\n+ stream = stream_config.stream\n+\n+ # Allocate the buffers for capture\n+\n+ allocator = libcam.FrameBufferAllocator(cam)\n+ ret = allocator.allocate(stream)\n+ assert ret > 0\n+\n+ num_bufs = len(allocator.buffers(stream))\n+\n+ print(f'Capturing {stream_config} with {num_bufs} buffers from {cam.id}')\n+\n+ # Create the requests and assign a buffer for each request\n+\n+ reqs = []\n+ for i in range(num_bufs):\n+ # Use the buffer index as the \"cookie\"\n+ req = cam.create_request(i)\n+\n+ buffer = allocator.buffers(stream)[i]\n+ ret = req.add_buffer(stream, buffer)\n+ assert ret == 0\n+\n+ reqs.append(req)\n+\n+ # Start the camera\n+\n+ ret = cam.start()\n+ assert ret == 0\n+\n+ ctx = CaptureContext()\n+ ctx.cm = cm\n+ ctx.cam = cam\n+ ctx.reqs = reqs\n+ ctx.mfbs = dict([(fb, libcamera.utils.MappedFrameBuffer(fb).mmap()) for fb in allocator.buffers(stream)])\n+\n+ capture(ctx)\n+\n+ # Stop the camera\n+\n+ ret = cam.stop()\n+ assert ret == 0\n+\n+ # Release the camera\n+\n+ ret = cam.release()\n+ assert ret == 0\n+\n+ return 0\n+\n+\n+if __name__ == '__main__':\n+ sys.exit(main())\n", "prefixes": [ "libcamera-devel", "v3", "28/30" ] }